FlatGeobuf format support #11833
Open
FlatGeobuf format support #11833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
stefanocudini
force-pushed
the
fix-11749-flatgeobuf
branch
from
9d25ef7 to
19b4fef
Compare
api catalog in metadataexplorer load dynamic fgb module unit tests flatgebouf api FlatGeobuf OL Loader FlatGeobuf Cesium Loader upgrade flatgeobuf 4.3.3 enable Mapinfo identify flatgeobuf layers update docs fix strategy style editor enabled flatgeobuf layer type fix lints
stefanocudini
force-pushed
the
fix-11749-flatgeobuf
branch
from
19b4fef to
c189a73
Compare
stefanocudini
force-pushed
the
fix-11749-flatgeobuf
branch
2 times, most recently
from
db1b800 to
23b4b41
Compare
stefanocudini
force-pushed
the
fix-11749-flatgeobuf
branch
from
23b4b41 to
b62f5c3
Compare
Member
Author
|
@allyoucanmap last commit upgrade flatgeobuf to v4.4.0 and replacement with new optimized readMetadata() method |
allyoucanmap
requested review from
subashtiwari1010
and removed request for
allyoucanmap
subashtiwari1010
requested changes
Jan 19, 2026
| // copy and paste in catalog for testing: https://flatgeobuf.org/test/data/countries.fgb | ||
| // | ||
| export const getCapabilities = (url) => { | ||
| return getFlatGeobufGeneric().then(async flatgeobuf => { // load lib dynamically |
Contributor
There was a problem hiding this comment.
As far as I know, we avoid using async await in mapstore project. So, I would suggest converting it to promise chaining.
cc: @allyoucanmap
| const parts = serviceUrl.split(/\./g); | ||
| // remove query params | ||
| const ext = (parts[parts.length - 1] || '').split(/\?/g)[0]; | ||
| return ext === FGB |
Contributor
There was a problem hiding this comment.
I would suggest to only use:
return ext === FGB| }; | ||
|
|
||
| export const preprocess = commonPreprocess; | ||
| // export const validate = (service) => Observable.of(service); |
Contributor
There was a problem hiding this comment.
Why is this commented? I would suggest to remove it if not necessary.
|
|
||
| const createLayer = (options, map) => { | ||
|
|
||
| // console.log('createLayer FlatGeobuf Cesium', options, map); |
Contributor
There was a problem hiding this comment.
I would suggest to remove the console.log. Check for other console.logs too.
|
|
||
| const geojson = new GeoJSON().writeFeatures(featuresVect); | ||
|
|
||
| // console.log('getFeatures', geojson, featuresVect); |
Contributor
There was a problem hiding this comment.
I would suggest to remove the console.logs.
Contributor
|
@stefanocudini Here are some bugs:
test-flatGeoBuff-1.mp4
test_flatgeobuff_2.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #11749 introducing the FlatGeobuf format support as new layer loaded from remote resource.
Flatgeobuf library version supported is last 4.3.3
added a new .fgb files and metadata sample for CI tests here:
https://github.com/stefanocudini/MapStore2/tree/fix-11749-flatgeobuf/web/client/test-resources/flatgeobuf
and a new public map here: http://localhost:8081/#/viewer/62619
Description
flatgeobuflayer typeWhat kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the new behavior?
Support loading FlatGeobuf (remote .fgb files) from catalog
flatgeobuf.mp4
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
just merged here:
flatgeobuf/flatgeobuf@15f137c