use the external hatanaka lib for crx2rnx

Author: valgur

README.md

@@ -57,8 +57,6 @@ cd georinex
 python -m pip install -e .
 ```
 
-The Hatanaka CRINEX converter automatically compiles if needed and a C compiler is available.
-
 ### Selftest
 
 It can be useful to check the setup of your system with:
@@ -400,8 +398,8 @@ UNAVCO RINEX 2 data:
 
 
 ### Hatanaka compressed RINEX .crx
-The compressed Hatanaka `.crx` or `.crx.gz` files are supported seamlessly via `crx2rnx` as noted in the Install section.
-There are distinct from the supported `.rnx`, `.gz`, or `.zip` RINEX files.
+The compressed Hatanaka `.crx` or `.crx.gz` files are supported seamlessly via `crx2rnx`.
+These are distinct from the supported `.rnx`, `.gz`, or `.zip` RINEX files.
 
 Hatanaka, Y. (2008), A Compression Format and Tools for GNSS Observation
           Data, Bulletin of the Geospatioal Information Authority of Japan, 55, 21-30.

setup.cfg

@@ -31,6 +31,7 @@ install_requires =
   python-dateutil
   numpy
   xarray>=0.11
+  hatanaka
 package_dir=
   =src
 

src/georinex/rio.py

@@ -6,8 +6,11 @@
 from contextlib import contextmanager
 import io
 import logging
+
 import xarray
 
+from hatanaka import crx2rnx
+
 try:
     from unlzw3 import unlzw
 except ImportError:
@@ -45,7 +48,9 @@ def opener(fn: T.TextIO | Path, header: bool = False) -> T.Iterator[T.TextIO]:
                 f.seek(0)
 
                 if is_crinex and not header:
-                    f = io.StringIO(opencrx(f))
+                    # Conversion to string is necessary because of a quirk where gzip.open()
+                    # even with 'rt' doesn't decompress until read.
+                    f = io.StringIO(crx2rnx(f.read()))
                 yield f
         elif suffix == ".zip":
             with zipfile.ZipFile(fn, "r") as z:
@@ -68,7 +73,7 @@ def opener(fn: T.TextIO | Path, header: bool = False) -> T.Iterator[T.TextIO]:
                 f.seek(0)
 
                 if is_crinex and not header:
-                    f = io.StringIO(opencrx(f))
+                    f = io.StringIO(crx2rnx(f))
                 yield f
     else:
         raise OSError(f"Unsure what to do with input of type: {type(fn)}")

src/georinex/tests/test_hatanaka.py

@@ -3,18 +3,10 @@
 from datetime import datetime
 
 import georinex as gr
-from georinex.hatanaka import crxexe
 
 R = Path(__file__).parent / "data"
 
 
-try:
-    exe = crxexe()
-except RuntimeError:
-    exe = None
-
-
-@pytest.mark.skipif(exe is None, reason="Hatanaka converter not working")
 def test_obs2():
 
     fn = R / "york0440.15d"
@@ -29,7 +21,6 @@ def test_obs2():
     assert obs["S1"].values[0, :3] == pytest.approx([44.0, 41.0, 51.0])
 
 
-@pytest.mark.skipif(exe is None, reason="Hatanaka converter not working")
 @pytest.mark.timeout(30)
 def test_obs3_gz():
 
@@ -87,7 +78,6 @@ def test_obs3_gz():
     assert times[-1] == datetime(2018, 7, 19, 1, 10)
 
 
-@pytest.mark.skipif(exe is None, reason="Hatanaka converter not working")
 @pytest.mark.timeout(30)
 def test_obs3():
     fn = R / "P43300USA_R_20190012056_17M_15S_MO.crx"