remove unneeded string()

Author: scivision

+stdlib/file_checksum.m

@@ -11,7 +11,7 @@
 
 function hash = file_checksum(file, method)
 arguments
-  file (1,1) string {mustBeFile}
+  file (1,1) string
   method (1,1) string
 end
 
@@ -28,7 +28,7 @@
 end
 
 fid = fopen(file, 'r');
-assert(fid > 0, "could not open %s", file)
+assert(fid > 0, "could not open file %s", file)
 
 while ~feof(fid)
   % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/security/MessageDigest.html#update(byte)
@@ -41,7 +41,7 @@
 
 hash = sprintf('%.2x', hash);
 
-try %#ok<TRYNC>
+if isa(file, "string")
   hash = string(hash);
 end
 

+stdlib/get_shell.m

@@ -6,7 +6,9 @@
 
 s = getenv("SHELL");
 
-try %#ok<TRYNC>
+d = "";
+
+if isa(d, "string")
   s = string(s);
 end
 

+stdlib/handle2filename.m

@@ -11,10 +11,6 @@
   n = stdlib.posix(fopen(fileHandle));
 end
 
-try %#ok<TRYNC>
-  n = string(n);
-end
-
 end
 
 %!assert(handle2filename(0), "stdin")

+stdlib/read_symlink.m

@@ -21,11 +21,10 @@
   r = stdlib.absolute(p, "", false, true);
 
   % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#readSymbolicLink(java.nio.file.Path)
-  t = string(java.nio.file.Files.readSymbolicLink(java.io.File(r).toPath()));
+  t = java.nio.file.Files.readSymbolicLink(java.io.File(r).toPath());
 else
   [ok, t] = isSymbolicLink(p);
   if ~ok, return, end
-  t = string(t);
 end
 
 r = stdlib.posix(t);

+stdlib/windows_shortname.m

@@ -6,12 +6,12 @@
 %  https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/windows-scripting/ch28h2s7
 %  https://www.mathworks.com/matlabcentral/fileexchange/48950-short-path-name-on-windows-com-server
 
-function short = windows_shortname(p)
+function s = windows_shortname(p)
 arguments
   p (1,1) string
 end
 
-short = string.empty;
+s = string.empty;
 
 if ~ispc
   return
@@ -20,12 +20,12 @@
 fso = actxserver('Scripting.FileSystemObject');
 
 if isfolder(p)
-  short = fso.GetFolder(p).ShortPath;
+  s = fso.GetFolder(p).ShortPath;
 elseif isfile(p)
-  short = fso.GetFile(p).ShortPath;
+  s = fso.GetFile(p).ShortPath;
 end
 
-short = string(short);
+s = string(s);
 
 delete(fso);
 

test/TestCanonical.m

@@ -5,7 +5,7 @@
 {{"", ""}, {"not-exist", "not-exist"}, {"a/../b", "b"}, ...
 {"~", test_homedir()}, {"~/", test_homedir()}, ...
 {"~/..", stdlib.parent(test_homedir())}, ...f
-{mfilename("fullpath") + ".m/..", stdlib.parent(string(mfilename("fullpath")))}};
+{mfilename("fullpath") + ".m/..", stdlib.parent(mfilename("fullpath"))}};
 end
 
 

test/TestFilePure.m

@@ -118,11 +118,11 @@ function test_join(tc, p_join)
 end
 
 function test_filename(tc, p_filename)
-tc.verifyEqual(stdlib.filename(p_filename{1}), string(p_filename{2}))
+tc.verifyEqual(stdlib.filename(p_filename{1}), p_filename{2})
 end
 
 function test_suffix(tc, p_suffix)
-tc.verifyEqual(stdlib.suffix(p_suffix{1}), string(p_suffix{2}))
+tc.verifyEqual(stdlib.suffix(p_suffix{1}), p_suffix{2})
 end
 
 

test/TestResolve.m

@@ -24,7 +24,7 @@ function setup_workdir(tc)
 
 function test_absolute(tc)
 
-td = stdlib.posix(string(pwd()));
+td = stdlib.posix(pwd());
 
 tc.verifyEqual(stdlib.absolute(""), td)
 tc.verifyEqual(stdlib.absolute("",""), td)
@@ -46,7 +46,7 @@ function test_resolve_non_exist(tc)
 import matlab.unittest.constraints.StartsWithSubstring
 import matlab.unittest.constraints.ContainsSubstring
 
-td = stdlib.posix(string(pwd()));
+td = stdlib.posix(pwd());
 
 % all non-existing files
 
@@ -77,11 +77,11 @@ function test_resolve_non_exist(tc)
 
 function test_resolve_exist(tc)
 
-td = stdlib.posix(string(pwd()));
+td = stdlib.posix(pwd());
 
 r = stdlib.parent(mfilename('fullpath'));
 rp = stdlib.parent(r);
-tc.verifyEqual(stdlib.resolve(rp), string(stdlib.parent(r)))
+tc.verifyEqual(stdlib.resolve(rp), stdlib.parent(r))
 
 h = stdlib.homedir();
 tc.verifyEqual(stdlib.resolve("~"), h)

test/TestWindowsCOM.m

@@ -20,14 +20,14 @@ function test_short_folder(tc)
 
 tc.assumeTrue(ispc, "Windows only")
 
-progdir = string(getenv("PROGRAMFILES"));
+progdir = stdlib.posix(getenv("PROGRAMFILES"));
 tc.assumeThat(progdir, IsFolder, "env:PROGRAMFILES is not a directory")
 
 short = stdlib.windows_shortname(progdir);
 
 tc.verifySubstring(short, "PROGRA~1")
 
-tc.verifyEqual(stdlib.canonical(short), stdlib.posix(progdir))
+tc.verifyEqual(stdlib.canonical(short), progdir)
 
 end