absolute: remove expand_tilde option

This was an anti-pattern, as the user can trivially call expanduser in
the same line

Author: scivision

+stdlib/absolute.m

@@ -9,54 +9,37 @@
 %%% Inputs
 % * p: path to make absolute
 % * base: if present, base on this instead of cwd
-% * expand_tilde: expand ~ to username if present
 %%% Outputs
 % * c: absolute path
 %
 % does not normalize path
 % non-existant path is made absolute relative to pwd
 
-function c = absolute(p, base, expand_tilde)
+function c = absolute(p, base)
 arguments
   p {mustBeTextScalar}
-  base {mustBeTextScalar} = ''
-  expand_tilde (1,1) logical = true
-end
-
-if expand_tilde
-  c = stdlib.expanduser(p);
-else
-  c = p;
+  base {mustBeTextScalar} = pwd()
 end
 
+c = p;
 if stdlib.is_absolute(c)
  return
 end
 
-if strlength(base) == 0
-  b = pwd();
-elseif expand_tilde
-  b = stdlib.expanduser(base);
+if strlength(base)
+  b = stdlib.absolute(base);
 else
-  b = base;
-end
-
-if ~stdlib.is_absolute(b)
-  b = strcat(pwd(), '/', b);
+  b = pwd();
 end
 
-if strlength(c) == 0
-  c = b;
-else
+if strlength(c)
   c = strcat(b, '/', c);
-end
-
-if isstring(p)
-  c = string(c);
+else
+  c = b;
 end
 
 end
 
 
-%!assert(absolute('', '', false), pwd)
-%!assert(absolute('a/b', '', false), strcat(pwd(), '/a/b'))
+%!assert(absolute('', ''), pwd)
+%!assert(absolute('a/b', ''), strcat(pwd(), '/a/b'))

+stdlib/is_regular_file.m

@@ -7,7 +7,7 @@
 end
 
 % needs absolute()
-p = stdlib.absolute(p, '', false);
+p = stdlib.absolute(p);
 
 op = javaPathObject(p);
 opt = javaLinkOption();

+stdlib/is_symlink.m

@@ -11,7 +11,7 @@
   ok = isSymbolicLink(p);
 catch e
   switch e.identifier
-    case "MATLAB:UndefinedFunction", ok = java.nio.file.Files.isSymbolicLink(javaPathObject(stdlib.absolute(p, '', false)));
+    case "MATLAB:UndefinedFunction", ok = java.nio.file.Files.isSymbolicLink(javaPathObject(stdlib.absolute(p)));
     case "Octave:undefined-function", ok = S_ISLNK(stat(p).mode);
     otherwise, rethrow(e)
   end

+stdlib/read_symlink.m

@@ -19,7 +19,7 @@
       if stdlib.is_symlink(p)
         % must be absolute path
         % must not be .canonical or symlink is gobbled!
-        r = stdlib.absolute(p, '', false);
+        r = stdlib.absolute(p);
 
         % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#readSymbolicLink(java.nio.file.Path)
         r = java.nio.file.Files.readSymbolicLink(javaPathObject(r)).string;

+stdlib/resolve.m

@@ -15,8 +15,13 @@
   expand_tilde (1,1) logical = true
 end
 
+if expand_tilde
+  c = stdlib.expand_tilde(p);
+else
+  c = p;
+end
 
-r = stdlib.canonical(stdlib.absolute(p, '', expand_tilde), false);
+r = stdlib.canonical(stdlib.absolute(c), false);
 
 end
 

test/TestAbsolute.m

@@ -29,10 +29,6 @@ function test_absolute1arg(tc, p1)
   r = strcat(r, '/', p1);
 end
 
-if isstring(p1)
-  r = string(r);
-end
-
 tc.verifyEqual(stdlib.absolute(p1), r)
 end
 
@@ -49,10 +45,6 @@ function test_absolute2arg(tc, p2)
   r = strcat(r, '/', p2{1});
 end
 
-if isstring(p2{1})
-  r = string(r);
-end
-
 tc.verifyEqual(stdlib.absolute(p2{1}, p2{2}), r)
 end