speed, compatibility

Author: scivision

+stdlib/file_size.m

@@ -9,7 +9,8 @@
 
 s = [];
 
-d = dir(file);
+% char() for Matlab < R2018a
+d = dir(char(file));
 
 if isscalar(d) && ~d.isdir
   s = d.bytes;

+stdlib/get_modtime.m

@@ -9,7 +9,9 @@
 
 t = datetime.empty;
 
-finf = dir(file);
+% char() for Matlab < R2018a
+finf = dir(char(file));
+
 if ~isempty(finf) && finf.isdir
   % find which index of the struct array has member name == '.'
   i = find(strcmp({finf.name}, '.'), 1);

+stdlib/handle2filename.m

@@ -1,8 +1,11 @@
-%% HANDLE2FILENAME Convert a file handle to a filename
+%% HANDLE2FILENAME Convert an integer file handle to a filename
+%
+%%% Inputs
+% * fileHandle: Integer file handle as returned by fopen
+%%% Outputs
+% * n: Filename. Empty if file handle is invalid.
+
 function n = handle2filename(fileHandle)
-arguments
-  fileHandle (1,1) {mustBeInteger}
-end
 
 n = '';
 

+stdlib/makedir.m

@@ -3,25 +3,18 @@
 % This function works around that bug in Matlab mkdir().
 
 function makedir(direc)
-arguments
-  direc string
-end
 
 %% to avoid confusing making ./~/mydir
-for i = numel(direc)
-  direc(i) = stdlib.expanduser(direc(i));
-end
-
-i = ~stdlib.strempty(direc) & ~isfolder(direc);
+direc = stdlib.expanduser(direc);
 
-for d = direc(i)
-  [~] = mkdir(d);
+if ~stdlib.strempty(direc) && ~isfolder(direc)
+  [~] = mkdir(direc);
 end
 
-ok = isfolder(direc(i));
+ok = isfolder(direc);
 
 if nargout == 0
-  assert(all(ok), "Failed to create directories: %s", strjoin(direc(~ok), ", "));
+  assert(ok, "Failed to create directory: %s", direc)
 end
 
 end

+stdlib/private/fileAttribCompatible.m

@@ -10,15 +10,7 @@
   return
 end
 
-
-try
-  [s, r, id] = fileattrib(file);
-catch e
-  if strcmp(e.identifier, 'MATLAB:string')
-    [s, r, id] = fileattrib(char(file));
-  else
-    rethrow(e)
-  end
-end
+% char() for Matlab < R2018a
+[s, r, id] = fileattrib(char(file));
 
 end

AGENTS.md

@@ -21,6 +21,7 @@ The key limitations to minimum Matlab version are:
 
 * R2017b: fileparts() supports string type. fileparts() is used in many places in the code as it's 5-10x faster than regexp() for filename parsing.
 * R2018a: fileattrib() supports string type
+* R2018a: mfilename('fullpath') tells the full path to the matlab .m file currently running (empty for older Matlab)
 * R2019b: function argument validation block "arguments"
 
 

test/TestExists.m

@@ -66,13 +66,24 @@ function test_is_char_device(tc, B_is_char_device)
 
 
 function Ps = init_val()
+
+
 Ps = {
   {pwd(), true}, ...
-  {[mfilename("fullpath"), '.m'], true}, ...
-  {[fileparts(mfilename("fullpath")), '/../Readme.md'], true}, ...
   {tempname(), false}, ...
   {'', false}
 };
+
+o = mfilename('fullpath');
+if ~isempty(o)
+  o = [o, '.m'];
+  Ps = [Ps, {
+    {o, true}, ...
+    {[fileparts(o), '/../Readme.md'], true}
+    }
+  ];
+end
+
 if ispc()
   % On Windows, the root of the system drive is considered to exist
   systemDrive = getenv("SystemDrive");