with_suffix: no coerce

Author: scivision

+stdlib/with_suffix.m

@@ -7,16 +7,13 @@
 % * f: modified filename
 
 function f = with_suffix(p, suffix)
-arguments
-  p string
-  suffix string
-end
 
 f = extractBefore(p, stdlib.suffix(p));
 
-i = stdlib.strempty(f);
-f(i) = p(i);
+if stdlib.strempty(f)
+  f = p;
+end
 
-f = f + suffix;
+f = append(f, suffix);
 
 end

test/TestExpanduser.m

@@ -1,5 +1,5 @@
 classdef (SharedTestFixtures={ matlab.unittest.fixtures.PathFixture(fileparts(fileparts(mfilename('fullpath'))))}, ...
-          TestTags = {'R2019b', 'impure'}) ...
+          TestTags = {'R2019a', 'impure'}) ...
     TestExpanduser < matlab.unittest.TestCase
 
 properties (TestParameter)

test/TestWithSuffix.m

@@ -1,5 +1,5 @@
 classdef (SharedTestFixtures={ matlab.unittest.fixtures.PathFixture(fileparts(fileparts(mfilename('fullpath'))))}, ...
-          TestTags = {'pure'}) ...
+          TestTags = {'R2019a', 'pure'}) ...
     TestWithSuffix < matlab.unittest.TestCase
 
 
@@ -10,32 +10,16 @@
 {"", ".nc", ".nc"}, ...
 {"hello.txt.gz", ".bz", "hello.txt.bz"}, ...
 {"a/b.c/hello.txt", ".gz", "a/b.c/hello.gz"}, ...
-{'a/b/', '.h5', "a/b/.h5"}, ...
+{'a/b/', '.h5', 'a/b/.h5'}, ...
 {"a/b/.h5", '.nc', "a/b/.h5.nc"}, ...
 {".h5", ".nc", ".h5.nc"}, ...
-{'a/b', '.nc', "a/b.nc"}};
+{'a/b', '.nc', 'a/b.nc'}};
 end
 
 
-methods (Test, TestTags={'R2019b'})
+methods (Test)
 function test_with_suffix(tc, p)
-
-r = p{3};
-
-tc.verifyEqual(stdlib.with_suffix(p{1}, p{2}), r)
-end
-end
-
-
-methods (Test, TestTags={'R2020b'})
-
-function test_with_suffix_array(tc)
-tc.assumeFalse(stdlib.matlabOlderThan('R2020b'))
-in = ["", ".txt", "a/b/c.txt", "a/b/c.txt.gz", "a/b/c"];
-new = [".txt", ".gz", "", ".bz", ".nc"];
-exp = [".txt", ".txt.gz", "a/b/c", "a/b/c.txt.bz", "a/b/c.nc"];
-out = stdlib.with_suffix(in, new);
-tc.verifyEqual(out, exp)
+tc.verifyEqual(stdlib.with_suffix(p{1}, p{2}), p{3})
 end
 end