remove unneeded internal use of stdlib.join

Author: scivision

+stdlib/canonical.m

@@ -40,7 +40,7 @@
       return
     else
       % workaround Java/Matlab limitations
-      c = stdlib.join(pwd, c);
+      c = stdlib.posix(pwd()) + "/" + c;
     end
   else
     % for non-existing path, return normalized relative path

+stdlib/expanduser.m

@@ -15,14 +15,21 @@
 
 e = p;
 
+
 if ~startsWith(e, "~") || (strlength(e) > 1 && ~startsWith(e, "~/"))
   return
 end
 
 home = stdlib.homedir(use_java);
 
 if ~isempty(home)
-  e = stdlib.join(home, strip(extractAfter(e, 1), "left", "/"));
+  d = home;
+  if strlength(e) < 2
+    e = d;
+    return
+  end
+
+  e = d + "/" + strip(extractAfter(e, 1), "left", "/");
 end
 
 end %function

+stdlib/which.m

@@ -43,7 +43,7 @@
 for name = names
 
   for p = fpath
-    exe = stdlib.join(p, name);
+    exe = stdlib.posix(p) + "/" + name;
     if stdlib.is_exe(exe, use_java)
       return
     end

+stdlib/with_suffix.m

@@ -6,15 +6,26 @@
 %%% Outputs
 % * filename: modified filename
 
-function filename = with_suffix(filename, suffix)
+function f = with_suffix(filename, suffix)
 arguments
   filename (1,1) string
   suffix (1,1) string
 end
 
-[direc, name, ext] = fileparts(filename);
-if ext ~= suffix
-  filename = stdlib.join(direc, name + suffix);
+p = stdlib.parent(filename);
+s = stdlib.stem(filename);
+
+if strlength(s) == 0
+  f = stdlib.join(filename, suffix);
+  return
+end
+
+if p == "."
+  f = s;
+else
+  f = p + "/" + s;
 end
 
+f = f + suffix;
+
 end

test/TestFilePure.m

@@ -248,6 +248,8 @@ function test_with_suffix(tc)
 tc.verifyEqual(stdlib.with_suffix("c", ""), "c")
 tc.verifyEqual(stdlib.with_suffix("c.nc", ""), "c")
 tc.verifyEqual(stdlib.with_suffix("", ".nc"), ".nc")
+
+tc.verifyEqual(stdlib.with_suffix("a//b///c///", ".h5"), "a/b/c/.h5")
 end