is_removable: correct behavior, added python backend

dotnet was not easily capable of doing this correctly

python: simplify

Author: scivision

+stdlib/+dotnet/is_removable.m

@@ -1,5 +1,7 @@
 %% DOTNET.IS_REMOVABLE detect removable drive
 %
+% This does NOT detect USB flash drives, so we DON'T automatically use it.
+%
 % Ref: https://learn.microsoft.com/en-us/dotnet/api/system.io.drivetype
 
 function y = is_removable(filepath)

+stdlib/+python/create_symlink.m

@@ -1,17 +1,16 @@
 function ok = create_symlink(target, link)
-arguments
-  target (1,1) string
-  link (1,1) string
-end
 
 ok = false;
 
-if ~stdlib.exists(target) || stdlib.strempty(link) || stdlib.exists(link)
+t = py.str(target);
+l = py.str(link);
+
+if ~py.os.path.exists(t) || py.os.path.exists(l)
   return
 end
 
 try
-  py.os.symlink(target, link);
+  py.os.symlink(t, l);
   ok = true;
 catch e
   warning(e.identifier, "create_symlink(%s, %s) failed: %s", target, link, e.message);

+stdlib/+python/device.m

@@ -1,7 +1,4 @@
 function i = device(file)
-arguments
-  file (1,1) string
-end
 
 try
   i = int64(py.os.stat(file).st_dev);

+stdlib/+python/disk_available.m

@@ -1,7 +1,4 @@
 function i = disk_available(file)
-arguments
-  file (1,1) string
-end
 
 i = disk_usage(file, 'free');
 

+stdlib/+python/disk_capacity.m

@@ -1,7 +1,4 @@
 function i = disk_capacity(file)
-arguments
-  file (1,1) string
-end
 
 i = disk_usage(file, 'total');
 

+stdlib/+python/filesystem_type.m

@@ -1,25 +1,26 @@
 function t = filesystem_type(file)
-arguments
-  file (1,1) string
-end
 
 t = '';
 
 % important for heuristic matching
-if ~stdlib.exists(file)
+p = py.str(file);
+if ~py.os.path.exists(p)
   return
 end
 
-pr = stdlib.absolute(file);
+p = py.os.path.abspath(p);
 
-try %#ok<TRYNC>
-  for part = py.psutil.disk_partitions(file)
+% https://psutil.readthedocs.io/en/stable/index.html?highlight=disk_partitions#psutil.disk_partitions
+try
+  for part = py.psutil.disk_partitions()
     prt = part{1};
-    if startsWith(pr, char(prt.mountpoint))
+    if p.startswith(prt.mountpoint)
       t = char(prt.fstype);
       return
     end
   end
+catch e
+  rethrow(e)
 end
 
 end

+stdlib/+python/hard_link_count.m

@@ -1,7 +1,4 @@
 function c = hard_link_count(file)
-arguments
-  file (1,1) string
-end
 
 try
   c = double(py.os.stat(file).st_nlink);

+stdlib/+python/inode.m

@@ -1,7 +1,4 @@
 function i = inode(file)
-arguments
-  file (1,1) string
-end
 
 try
   i = int64(py.os.stat(file).st_ino);

+stdlib/+python/is_removable.m

@@ -0,0 +1,26 @@
+function y = is_removable(file)
+
+y = false;
+
+% important for heuristic matching
+p = py.str(file);
+if ~py.os.path.exists(p)
+  return
+end
+
+p = py.os.path.abspath(p);
+
+% https://psutil.readthedocs.io/en/stable/index.html?highlight=disk_partitions#psutil.disk_partitions
+try
+  for part = py.psutil.disk_partitions()
+    prt = part{1};
+    if p.startswith(prt.mountpoint)
+      y = contains(string(prt.opts), ["cdrom", "removable"]);
+      return
+    end
+  end
+catch e
+  rethrow(e)
+end
+
+end

+stdlib/+python/is_symlink.m

@@ -1,7 +1,4 @@
 function y = is_symlink(file)
-arguments
-  file (1,1) string
-end
 
 try
   y = py.pathlib.Path(file).is_symlink();