read_symlink: choose_method

Author: scivision

+stdlib/+native/read_symlink.m

@@ -0,0 +1,8 @@
+function r = read_symlink(file)
+
+[ok, r] = isSymbolicLink(file);
+if ~ok
+  r = string.empty; 
+end
+
+end

+stdlib/private/choose_method.m

@@ -15,7 +15,7 @@
     case "dotnet"
       has = @stdlib.has_dotnet;
 
-      if endsWith(name, "ram_total")
+      if endsWith(name, ["ram_total", "read_symlink"])
         if stdlib.dotnet_api() < 6, continue, end
       end
     case "java"

+stdlib/read_symlink.m

@@ -3,35 +3,14 @@
 % empty string if path is not a symlink
 % always of string class in Matlab
 
-function r = read_symlink(p)
+function r = read_symlink(file, method)
 arguments
-  p {mustBeTextScalar}
+  file {mustBeTextScalar}
+  method (1,:) string = ["native", "java", "dotnet", "python", "sys"]
 end
 
-if ~isMATLABReleaseOlderThan('R2024b')
-  [ok, r] = isSymbolicLink(p);
-  if ~ok
-    r = string.empty; 
-  end
-elseif stdlib.dotnet_api() >= 6
-  r = stdlib.dotnet.read_symlink(p);
-elseif stdlib.has_java()
-  r = stdlib.java.read_symlink(p);
-elseif stdlib.has_python()
-  r = stdlib.python.read_symlink(p);
-elseif stdlib.isoctave()
-  r = readlink(p);
-else
-  r = stdlib.sys.read_symlink(p);
-end
+fun = choose_method(method, "read_symlink");
 
-end
+r = fun(file);
 
-%!test
-%! if !ispc
-%! p = tempname();
-%! this = strcat(mfilename("fullpath"), '.m');
-%! assert (read_symlink(p), "")
-%! assert (create_symlink(this, p))
-%! assert (read_symlink(p), this)
-%! endif
+end

test/TestSymlink.m

@@ -11,8 +11,8 @@
     {mfilename("fullpath") + ".m", false}, ...
     {"", false}};
 create_symlink_fun = {@stdlib.create_symlink, @stdlib.sys.create_symlink, @stdlib.dotnet.create_symlink, @stdlib.python.create_symlink}
-is_symlink_fun = {'native', 'sys', 'dotnet', 'java', 'python'}
-read_symlink_fun = {@stdlib.read_symlink, @stdlib.sys.read_symlink, @stdlib.dotnet.read_symlink, @stdlib.java.read_symlink, @stdlib.python.read_symlink}
+Pre = {'', "", tempname()}
+rs_fun = {'native', 'sys', 'dotnet', 'java', 'python'}
 end
 
 methods(TestClassSetup)
@@ -44,31 +44,33 @@ function setup_symlink(tc)
 
 methods (Test, TestTags=["impure", "symlink"])
 
-function test_is_symlink(tc, p, is_symlink_fun)
-tc.assertNotEmpty(which("stdlib." + is_symlink_fun + ".is_symlink"))
+function test_is_symlink(tc, p, rs_fun)
+tc.assertNotEmpty(which("stdlib." + rs_fun + ".is_symlink"))
 try
-  tc.verifyTrue(stdlib.is_symlink(tc.link, is_symlink_fun), "failed to detect own link")
-  tc.verifyEqual(stdlib.is_symlink(p{1}, is_symlink_fun), p{2}, p{1})
+  tc.verifyTrue(stdlib.is_symlink(tc.link, rs_fun), "failed to detect own link")
+  tc.verifyEqual(stdlib.is_symlink(p{1}, rs_fun), p{2}, p{1})
 catch e
   tc.verifyEqual(e.identifier, 'stdlib:choose_method:NameError', e.message)
 end
 end
 
 
-function test_read_symlink(tc, read_symlink_fun)
-is_capable(tc, read_symlink_fun)
-
-tc.verifyEmpty(read_symlink_fun(""))
-tc.verifyEmpty(read_symlink_fun(''))
-tc.verifyEmpty(read_symlink_fun(tempname))
-tc.verifyEmpty(read_symlink_fun(tc.target))
-
-link_read = read_symlink_fun(tc.link);
-
-targ = string(tc.target);
+function test_read_symlink_empty(tc, Pre, rs_fun)
+try
+  tc.verifyEmpty(stdlib.read_symlink(Pre, rs_fun))
+catch e
+  tc.verifyEqual(e.identifier, 'stdlib:choose_method:NameError', e.message)
+end
+end
 
-tc.verifyEqual(link_read, targ)
 
+function test_read_symlink(tc, rs_fun)
+tc.assertNotEmpty(which("stdlib." + rs_fun + ".read_symlink"))
+try
+  tc.verifyEqual(stdlib.read_symlink(tc.link, rs_fun), string(tc.target))
+catch e
+  tc.verifyEqual(e.identifier, 'stdlib:choose_method:NameError', e.message)
+end
 end
 
 

test/is_capable.m

@@ -16,7 +16,7 @@ function is_capable(tc, f)
     tc.assumeTrue(ispc(), "Windows only function")
   end
 
-  if endsWith(n, ["create_symlink", "ram_total", "read_symlink"])
+  if endsWith(n, ["create_symlink", "ram_total"])
     tc.assumeGreaterThanOrEqual(dapi, 6);
   end