os_version: return char

Author: scivision

+stdlib/+dotnet/os_version.m

@@ -3,7 +3,8 @@
 v = System.Environment.OSVersion.VersionString;
 % https://learn.microsoft.com/en-us/dotnet/api/system.operatingsystem.versionstring
 vs = split(string(v), ' ');
-version = vs(end);
-os = join(vs(1:end-1));
+
+version = char(vs(end));
+os = char(join(vs(1:end-1)));
 
 end

+stdlib/+java/os_version.m

@@ -1,8 +1,6 @@
 function [os, version] = os_version()
 
-os = javaMethod("getProperty", "java.lang.System", "os.name");
-version = javaMethod("getProperty", "java.lang.System", "os.version");
-os = string(os);
-version = string(version);
+os = char(javaMethod("getProperty", "java.lang.System", "os.name"));
+version = char(javaMethod("getProperty", "java.lang.System", "os.version"));
 
 end

+stdlib/+python/os_version.m

@@ -1,12 +1,12 @@
 function [os, version] = os_version()
 
 try
-  os = string(py.platform.system());
-  version = string(py.platform.version());
+  os = char(py.platform.system());
+  version = char(py.platform.version());
 catch e
   warning(e.identifier, 'Failed to get OS version using Python: %s', e.message)
-  os = string.empty();
-  version = string.empty();
+  os = '';
+  version = '';
 end
 
 end

+stdlib/+sys/os_version.m

@@ -4,22 +4,22 @@
   cmd1 = 'pwsh -c "(Get-CimInstance -ClassName Win32_OperatingSystem).Caption"';
   cmd2 = 'pwsh -c "(Get-CimInstance -ClassName Win32_OperatingSystem).Version"';
 else
-  cmd1 = "uname -s";
-  cmd2 = "uname -r";
+  cmd1 = 'uname -s';
+  cmd2 = 'uname -r';
 end
 
 [s, os] = system(cmd1);
 if s == 0
   os = strip(os);
 else
-  error("Failed to get OS name: %s", os);
+  os = '';
 end
 
 [s, version] = system(cmd2);
 if s == 0
   version = strip(version);
 else
-  error("Failed to get OS version: %s", version);
+  version = '';
 end
 
 end

test/TestSys.m

@@ -117,6 +117,8 @@ function test_os_version(tc, all_fun)
   return
 end
 
+tc.verifyClass(os, 'char')
+tc.verifyClass(ver, 'char')
 tc.verifyGreaterThan(strlength(os), 0, "expected non-empty os")
 tc.verifyGreaterThan(strlength(ver), 0, "expected non-empty version")
 end