hostname: return char

Author: scivision

+stdlib/+dotnet/get_hostname.m

@@ -3,7 +3,7 @@
 
 function n = get_hostname()
 
-n = string(System.Environment.MachineName);
+n = char(System.Environment.MachineName);
 % https://learn.microsoft.com/en-us/dotnet/api/system.environment.machinename
 
 end

+stdlib/+java/get_hostname.m

@@ -1,5 +1,5 @@
 function n = get_hostname()
 
-n = string(javaMethod("getLocalHost", "java.net.InetAddress").getHostName());
+n = char(javaMethod("getLocalHost", "java.net.InetAddress").getHostName());
 
 end

+stdlib/+python/get_hostname.m

@@ -1,7 +1,7 @@
 function n = get_hostname()
 
 try
-  n = string(py.socket.gethostname());
+  n = char(py.socket.gethostname());
 catch e
   warning(e.identifier, "get_hostname failed: %s", e.message);
   n = string.empty;

+stdlib/+sys/get_hostname.m

@@ -1,13 +1,12 @@
 function n = get_hostname()
 
-cmd = "hostname";
+cmd = 'hostname';
 [s, n] = system(cmd);
 
 if s == 0
-  n = string(strtrim(n));
+  n = char(strtrim(n));
 else
-  warning("Failed to get hostname from system %s: %s", cmd, n);
-  n = string.empty;
+  n = '';
 end
 
 end

test/TestSys.m

@@ -138,10 +138,13 @@ function test_hostname(tc, all_fun)
 tc.assertNotEmpty(which("stdlib." + all_fun + ".get_hostname"))
 try
   h = stdlib.hostname(all_fun);
-  tc.verifyGreaterThan(strlength(h), 0)
 catch e
   tc.verifyEqual(e.identifier, 'stdlib:hbackend:NameError', e.message)
+  return
 end
+
+tc.verifyClass(h, 'char')
+tc.verifyGreaterThan(strlength(h), 0)
 end
 
 function test_username(tc, all_fun)