efficiency, doc

Author: scivision

+stdlib/+legacy/is_exe.m

@@ -1,15 +1,14 @@
 function y = is_exe(file)
-arguments
-  file (1,1) string
-end
 
 y = false;
 
 if ispc() && ~stdlib.native.has_windows_executable_suffix(file)
   return
 end
 
-if ~isfile(file), return, end
+if ~isfile(file)
+  return
+end
 
 a = stdlib.legacy.file_attributes(file);
 y = a.UserExecute || a.GroupExecute || a.OtherExecute;

+stdlib/+native/has_windows_executable_suffix.m

@@ -9,6 +9,6 @@
 end
 pe = split(string(pec), pathsep);
 
-i = endsWith(stdlib.suffix(p), pe, 'IgnoreCase', true);
+i = endsWith(stdlib.suffix(p), pe, IgnoreCase=true);
 
 end

+stdlib/get_shell.m

@@ -4,18 +4,16 @@
 % * s: full path to currently running shell
 % * b: backend used
 
-function [s, b] = get_shell()
+function s = get_shell()
 
 if ispc()
 % https://stackoverflow.com/a/61469226
-  cmd = "(dir 2>&1 *`|echo CMD);&<# rem #>echo ($PSVersionTable).PSEdition";
+  cmd = '(dir 2>&1 *`|echo CMD);&<# rem #>echo ($PSVersionTable).PSEdition';
 else
 % https://askubuntu.com/a/1349538
   cmd = 'lsof -p "$$" | grep -m 1 txt | xargs -n 1 | tail -n +9';
 end
 
-b = "sys";
-
 [r, msg] = system(cmd);
 
 if r == 0

+stdlib/is_exe.m

@@ -5,6 +5,8 @@
 % file: path to check
 %%% Outputs
 % ok: true if path is a file and has executable permissions
+%
+% the legacy backend is actually significantly faster for single files
 
 function [ok, b] = is_exe(file)
 arguments

+stdlib/is_readable.m

@@ -4,6 +4,8 @@
 % file: single path string
 %%% Outputs
 % ok: true if file is readable
+%
+% the legacy backend is actually significantly faster for single files
 
 function [ok, b] = is_readable(file)
 arguments

+stdlib/is_rosetta.m

@@ -7,12 +7,10 @@
 %
 % "uname -m" reports "x86_64" from within Matlab on Apple Silicon if using Rosetta
 
-function [r, b] = is_rosetta()
-
-b = "sys";
+function r = is_rosetta()
 
 if ismac()
-  [s, raw] = system("sysctl -n sysctl.proc_translated");
+  [s, raw] = system('sysctl -n sysctl.proc_translated');
   r = s == 0 && startsWith(raw, '1');
 else
   r = false;

+stdlib/is_writable.m

@@ -4,6 +4,8 @@
 % * file: path to file or folder
 %%% Outputs
 % * ok: true if file is writable
+%
+% the legacy backend is actually significantly faster for single files
 
 function [ok, b] = is_writable(file)
 arguments

+stdlib/set_permissions.m

@@ -8,6 +8,8 @@
 %%% Outputs
 % * ok (1,1) logical
 % * b: backend used
+%
+% native backend is much more robust, if available
 
 function [ok, b] = set_permissions(file, readable, writable, executable)
 arguments