use std::string_view for efficiency like Ffilesystem

Author: scivision

buildfile.m

@@ -96,7 +96,7 @@ function publishTask(context)
 srcs = {
 ["src/is_admin.cpp", "src/admin_fs.cpp"] ...
 "src/is_char_device.cpp", ...
-["src/is_wsl.cpp", "src/linux_fs.cpp"], ...
+["src/is_wsl.cpp", linux], ...
 "src/set_permissions.cpp", ...
 ["src/is_rosetta.cpp", mac], ...
 ["src/windows_shortname.cpp", win], ...

src/is_char_device.cpp

@@ -9,7 +9,7 @@
 #include "mexAdapter.hpp"
 
 #include <string>
-// note: <string_view> causes compile failures with MSVC at least
+#include <string_view>
 
 #include <vector>
 #include <memory>
@@ -25,7 +25,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 
-static int fs_st_mode(std::string path)
+static int fs_st_mode(std::string_view path)
 {
 // https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions
   struct stat s;
@@ -34,7 +34,7 @@ static int fs_st_mode(std::string path)
 }
 
 
-static bool fs_is_char_device(std::string path)
+static bool fs_is_char_device(std::string_view path)
 {
 // character device like /dev/null or CONIN$
 #if defined(_MSC_VER)

src/set_permissions.cpp

@@ -5,6 +5,7 @@
 #include "mexAdapter.hpp"
 
 #include <string>
+#include <string_view>
 
 #include <vector>
 #include <memory>
@@ -15,7 +16,7 @@
 #endif
 
 
-static bool fs_set_permissions(std::string path, int readable, int writable, int executable)
+static bool fs_set_permissions(std::string_view path, int readable, int writable, int executable)
 {
 #ifdef __cpp_lib_filesystem
 

src/symlink_fs.cpp

@@ -5,6 +5,7 @@
 #endif
 
 #include <string>
+#include <string_view>
 
 #if __has_include(<filesystem>)
 # include <filesystem>
@@ -19,7 +20,7 @@
 
 
 
-bool fs_create_symlink(std::string target, std::string link)
+bool fs_create_symlink(std::string_view target, std::string_view link)
 {
   // confusing program errors if target is "" -- we'd never make such a symlink in real use.
   if(target.empty())
@@ -64,7 +65,7 @@ bool fs_create_symlink(std::string target, std::string link)
 }
 
 
-bool fs_is_symlink(std::string path)
+bool fs_is_symlink(std::string_view path)
 {
 
 #if defined(__MINGW32__) || (defined(_WIN32) && !defined(__cpp_lib_filesystem))
@@ -81,7 +82,7 @@ bool fs_is_symlink(std::string path)
 }
 
 
-std::string fs_read_symlink(std::string path)
+std::string fs_read_symlink(std::string_view path)
 {
 
   if(!fs_is_symlink(path))

src/symlink_fs.h

@@ -1,5 +1,6 @@
 #include <string>
+#include <string_view>
 
-bool fs_is_symlink(std::string);
-bool fs_create_symlink(std::string, std::string);
-std::string fs_read_symlink(std::string);
+bool fs_is_symlink(std::string_view);
+bool fs_create_symlink(std::string_view, std::string_view);
+std::string fs_read_symlink(std::string_view);

src/win32_fs.h

@@ -1,7 +1,8 @@
 #include <string>
+#include <string_view>
 
-bool fs_win32_is_symlink(std::string);
+bool fs_win32_is_symlink(std::string_view);
 
-std::string fs_shortname(std::string);
+std::string fs_shortname(std::string_view);
 
-std::string fs_as_posix(std::string);
+std::string fs_as_posix(std::string_view);

src/windows.cpp

@@ -57,7 +57,7 @@ typedef struct _REPARSE_DATA_BUFFER
 } REPARSE_DATA_BUFFER, *PREPARSE_DATA_BUFFER;
 
 
-std::string fs_as_posix(std::string path)
+std::string fs_as_posix(std::string_view path)
 {
   std::string s(path);
 
@@ -69,7 +69,7 @@ std::string fs_as_posix(std::string path)
 }
 
 
-static bool fs_win32_get_reparse_buffer(std::string path, std::byte* buffer)
+static bool fs_win32_get_reparse_buffer(std::string_view path, std::byte* buffer)
 {
 // this function is adapted from
 // https://gitlab.kitware.com/utils/kwsys/-/blob/master/SystemTools.cxx
@@ -111,7 +111,7 @@ static bool fs_win32_get_reparse_buffer(std::string path, std::byte* buffer)
 }
 
 
-std::string fs_win32_final_path(std::string path)
+std::string fs_win32_final_path(std::string_view path)
 {
   // resolves Windows symbolic links (reparse points and junctions)
   // it also resolves the case insensitivity of Windows paths to the disk case
@@ -153,7 +153,7 @@ std::string fs_win32_final_path(std::string path)
 }
 
 
-bool fs_win32_is_symlink(std::string path)
+bool fs_win32_is_symlink(std::string_view path)
 {
 // distinguish between Windows symbolic links and reparse points as
 // reparse points can be unlike symlinks.
@@ -177,7 +177,7 @@ bool fs_win32_is_symlink(std::string path)
 }
 
 
-std::string fs_shortname(std::string in)
+std::string fs_shortname(std::string_view in)
 {
 // https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getshortpathnamew
 // the path must exist