dedupe with file_attributes()

Author: scivision

+stdlib/is_exe.m

@@ -22,15 +22,14 @@
 
 else
 
-[status, v] = fileattrib(p);
+a = file_attributes(p);
+if isempty(a), return, end
 
-ok = status ~= 0 && (v.UserExecute || (~isnan(v.GroupExecute) && v.GroupExecute) || (~isnan(v.OtherExecute) && v.OtherExecute));
+ok = a.UserExecute || a.GroupExecute || a.OtherExecute;
 
 end
 
-end
-
-%!assert (!is_exe(''))
-%!assert (!is_exe(tempname))
-%!assert (is_exe("."))
-%!assert (is_exe(program_invocation_name))
+%!assert (!is_exe('', 0))
+%!assert (!is_exe(tempname, 0))
+%!assert (is_exe(".", 0))
+%!assert (is_exe(program_invocation_name, 0))

+stdlib/is_readable.m

@@ -15,19 +15,17 @@
 if use_java
   % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#isReadable(java.nio.file.Path)
   % java.nio.file.Files is about 10x slower than fileattrib
-  % needs absolute()
   % file = stdlib.absolute(file, "", false, true);
   % ok = java.nio.file.Files.isReadable(javaPathObject(file));
 
 ok = javaFileObject(p).canRead();
 
-else % use_java
+else
 
-[status, v] = fileattrib(p);
+a = file_attributes(p);
+if isempty(a), return, end
 
-ok = status ~= 0 && (v.UserRead || (~isnan(v.GroupRead) && v.GroupRead) || (~isnan(v.OtherRead) && v.OtherRead));
-
-end
+ok = a.UserRead || v.GroupRead || v.OtherRead;
 
 end
 

+stdlib/is_symlink.m

@@ -1,6 +1,4 @@
 %% IS_SYMLINK is path a symbolic link
-% on Windows, distinguishes between symlinks and App Execution Aliases,
-% which are not symlinks.
 
 function ok = is_symlink(p)
 arguments

+stdlib/is_writable.m

@@ -24,11 +24,10 @@
 
 else
 
-[status, v] = fileattrib(p);
+a = file_attributes(p);
+if isempty(a), return, end
 
-ok = status ~= 0 && (v.UserWrite || (~isnan(v.GroupWrite) && v.GroupWrite) || (~isnan(v.OtherWrite) && v.OtherWrite));
-
-end
+ok = a.UserWrite || v.GroupWrite || v.OtherWrite;
 
 end
 

+stdlib/private/file_attributes.m

@@ -0,0 +1,25 @@
+function a = file_attributes(p)
+arguments
+  p (1,1) string
+end
+
+a = struct.empty;
+
+if stdlib.len(p) == 0
+  return
+end
+
+[status, a] = fileattrib(p);
+if status ~= 1
+  a = struct.empty;
+  return
+end
+
+for n = {"GroupRead", "GroupWrite", "GroupExecute", "OtherRead", "OtherWrite", "OtherExecute"}
+  name = n{1};
+  if ~isfield(a, name) || isnan(a.(name))
+    a.(name) = false;
+  end
+end
+
+end