better efficiency

Author: scivision

+stdlib/+java/is_admin.m

@@ -4,10 +4,11 @@
 % Administrator group SID (S-1-5-32-544) is not an appropriate check .getGroupIDs because it
 % only tells if a user is *allowed* to run as admin, not if they are currently running as admin.
 
-ok = logical.empty;
 
-try %#ok<TRYNC>
+try
   ok = com.sun.security.auth.module.UnixSystem().getUid() == 0;
+catch
+  ok = logical.empty;
 end
 
 end

+stdlib/+sys/is_admin.m

@@ -1,4 +1,4 @@
-function y = is_admin()
+function [y, cmd] = is_admin()
 
 if ispc()
   cmd = 'pwsh -c "([Security.Principal.WindowsPrincipal] [Security.Principal.WindowsIdentity]::GetCurrent()).IsInRole([Security.Principal.WindowsBuiltInRole]::Administrator)"';
@@ -9,7 +9,7 @@
 [s, r] = system(cmd);
 if s ~= 0
   warning("stdlib:is_admin:RuntimeError", "Failed to execute command '%s': %s", cmd, r);
-  y = false;
+  y = logical.empty;
   return
 end
 

+stdlib/strempty.m

@@ -2,11 +2,6 @@
 
 function y = strempty(s)
 
-if isempty(s)
-  y = true;
-else
-  y = strlength(s) == 0;
-end
-
+y = isempty(s) | strlength(s) == 0;
 
 end

test/TestSys.m

@@ -52,7 +52,9 @@ function test_all_toolboxes(tc)
 end
 
 function test_platform_tell(tc)
-tc.verifyClass(stdlib.platform_tell(), 'char')
+r = stdlib.platform_tell();
+tc.verifyClass(r, 'char')
+tc.verifyNotEmpty(r)
 end