owner: return char

Author: scivision

+stdlib/+dotnet/get_owner.m

@@ -2,11 +2,6 @@
 
 function o = get_owner(p)
 
-if ~stdlib.exists(p)
-  o = string.empty;
-  return
-end
-
 % This is not yet possible with .NET on Unix, even with .NET 10.
 % It would require Pinvoke or external Mono.Unix
 
@@ -17,12 +12,15 @@
 
 if isfolder(p)
   fsec = System.IO.Directory.GetAccessControl(p);
-else
+elseif isfile(p)
   fsec = System.IO.File.GetAccessControl(p);
+else
+  o = '';
+  return
 end
 
 owner = fsec.GetOwner(ntAccountType);
 
-o = string(owner.Value);
+o = char(owner.ToString());
 
 end

+stdlib/+java/get_owner.m

@@ -1,15 +1,20 @@
-function n = get_owner(p)
+%% JAVA.GET_OWNER get owner of file
 
-n = string.empty;
-if ~stdlib.exists(p), return, end
+function n = get_owner(p)
 
 % https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/nio/file/Files.html#getOwner(java.nio.file.Path,java.nio.file.LinkOption...)
 % https://docs.oracle.com/en/java/javase/22/docs/api/java.base/java/nio/file/LinkOption.html
 
+n = '';
+if ~stdlib.exists(p)
+  return
+end
+
+
 try
   opt = javaMethod("values", "java.nio.file.LinkOption");
 
-  n = string(javaMethod("getOwner", "java.nio.file.Files", javaPathObject(p), opt));
+  n = char(javaMethod("getOwner", "java.nio.file.Files", javaPathObject(p), opt));
 catch e
   warning(e.identifier, "get_owner(%s) failed: %s", p, e.message)
 end

+stdlib/+python/get_owner.m

@@ -1,10 +1,12 @@
 function n = get_owner(p)
 
-n = string.empty;
-if ~stdlib.exists(p), return, end
+n = '';
+if ~stdlib.exists(p)
+  return
+end
 
 try
-  n = string(py.str(py.pathlib.Path(p).owner()));
+  n = char(py.str(py.pathlib.Path(p).owner()));
 catch e
   warning(e.identifier, "get_owner(%s) failed: %s", p, e.message)
 end

+stdlib/+sys/get_owner.m

@@ -1,10 +1,12 @@
 function o = get_owner(p)
 
-o = string.empty;
-if ~stdlib.exists(p), return, end
+o = '';
+if ~stdlib.exists(p)
+  return
+end
 
 if ispc()
-  cmd = sprintf('pwsh -c (Get-Acl -Path "%s").Owner', p);
+  cmd = sprintf('pwsh -c "if($x=Get-Acl -Path ''%s'') {$x.Owner}"', p);
 elseif ismac()
   cmd = sprintf('stat -f %%Su "%s"', p);
 else
@@ -13,7 +15,7 @@
 
 [s, m] = system(cmd);
 if s == 0
-  o = string(strip(m));
+  o = strip(m);
 end
 
 end

test/TestDisk.m

@@ -6,13 +6,12 @@
 
 properties (TestParameter)
 Ps = {".", "", "/", getenv("SystemDrive"), "not-exist"}
-Po = {mfilename("fullpath") + ".m", pwd(), ".", "", tempname()}
+Po = {mfilename("fullpath") + ".m", pwd(), ".", "", "not-exist"}
 id_fun = {'sys', 'java', 'python'}
 id_name = {"inode", "device"}
-disk_ac_fun = {'sys', 'dotnet', 'java', 'python'}
+all_fun = {'sys', 'dotnet', 'java', 'python'}
 disk_ac_name = {'disk_available', 'disk_capacity'}
 hl_fun = {'java', 'python'}
-fst_fun = {'sys', 'dotnet', 'java', 'python'}
 is_remove = {'dotnet', 'sys'}
 py_sys = {'python', 'sys'}
 end
@@ -26,13 +25,13 @@ function pkg_path(tc)
 
 methods (Test)
 
-function test_disk_ac(tc, Ps, disk_ac_fun, disk_ac_name)
-n = "stdlib." + disk_ac_fun + "." + disk_ac_name;
+function test_disk_ac(tc, Ps, all_fun, disk_ac_name)
+n = "stdlib." + all_fun + "." + disk_ac_name;
 h = str2func("stdlib." + disk_ac_name);
 tc.assertNotEmpty(which(n))
 
 try
-  r = h(Ps, disk_ac_fun);
+  r = h(Ps, all_fun);
   if stdlib.exists(Ps)
     tc.verifyGreaterThanOrEqual(r, 0)
   else
@@ -93,10 +92,10 @@ function test_hard_link_count(tc, hl_fun)
 end
 
 
-function test_filesystem_type(tc, Ps, fst_fun)
-tc.assertNotEmpty(which("stdlib." + fst_fun + ".filesystem_type"))
+function test_filesystem_type(tc, Ps, all_fun)
+tc.assertNotEmpty(which("stdlib." + all_fun + ".filesystem_type"))
 try
-  t = stdlib.filesystem_type(Ps, fst_fun);
+  t = stdlib.filesystem_type(Ps, all_fun);
 catch e
   tc.verifyEqual(e.identifier, 'stdlib:hbackend:NameError', e.message)
   return
@@ -146,17 +145,17 @@ function test_inode_device(tc, id_fun, id_name)
 end
 
 
-function test_owner(tc, Po, fst_fun)
-tc.assertNotEmpty(which("stdlib." + fst_fun + ".get_owner"))
+function test_owner(tc, Po, all_fun)
+tc.assertNotEmpty(which("stdlib." + all_fun + ".get_owner"))
 
 try
-  o = stdlib.get_owner(Po, fst_fun);
+  o = stdlib.get_owner(Po, all_fun);
 catch e
   tc.verifyEqual(e.identifier, 'stdlib:hbackend:NameError', e.message)
   return
 end
 
-tc.verifyClass(o, 'string')
+tc.verifyClass(o, 'char')
 
 if stdlib.exists(Po)
   tc.verifyGreaterThan(strlength(o), 0)