is_exe, is_readable: simpler, more robust

is_writable more robuse

Author: scivision

+stdlib/is_exe.m

@@ -6,9 +6,6 @@
 arguments
   p string
 end
-% need to have string array type for p(:)
-
-p = p(:);
 
 ok(size(p)) = false;
 
@@ -29,9 +26,9 @@
     props = "Readable";
   end
 
-  t(i, :) = getPermissions(filePermissions(p(i)), props);
+  t = getPermissions(filePermissions(p(i)), props);
 
-  ok(i) = any(t{i,:}, 2);
+  ok(i) = any(t{:,:}, 2);
 
 else
 
@@ -41,6 +38,3 @@
 end
 
 end
-
-%!assert (!is_exe("."))
-%!assert (is_exe(program_invocation_name))

+stdlib/is_readable.m

@@ -1,22 +1,36 @@
 %% IS_READABLE is file readable
+%
+%%% Inputs
+% p: string array of file paths
+%% Outputs
+% ok: logical array of the same size as p, true if file is readable
 
 function ok = is_readable(p)
+arguments
+  p string
+end
+
+ok(size(p)) = false;
+
+i = stdlib.exists(p);
+
+if ~any(i), return, end
+
+if ~isMATLABReleaseOlderThan('R2025a')
 
-try
   props = "Readable";
   if isunix
     props = [props, "GroupRead", "OtherRead"];
   end
-  t = getPermissions(filePermissions(p), props);
-  ok = any(t{:,:}, 2);
-catch e
-  switch e.identifier
-    case {'MATLAB:UndefinedFunction', 'Octave:undefined-function'}
-      a = file_attributes_legacy(p);
-      ok = a.UserRead || a.GroupRead || a.OtherRead;
-    otherwise, rethrow(e)
-  end
+
+  t = getPermissions(filePermissions(p(i)), props);
+  ok(i) = any(t{:,:}, 2);
+
+else
+
+  a = file_attributes_legacy(p);
+  ok = a.UserRead || a.GroupRead || a.OtherRead;
+
 end
 
 end
-%!assert (is_readable('is_readable.m'))

+stdlib/is_writable.m

@@ -1,21 +1,34 @@
 %% IS_WRITABLE is path writable
+%
+%%% Inputs
+% p: string array of file paths
+%% Outputs
+% ok: logical array of the same size as p, true if file is writable
 
 function ok = is_writable(p)
+arguments
+  p string
+end
+
+ok(size(p)) = false;
+
+i = stdlib.exists(p);
+
+if ~any(i), return, end
+
+if ~isMATLABReleaseOlderThan('R2025a')
 
-try
   props = "Writable";
   if isunix
     props = [props, "GroupWrite", "OtherWrite"];
   end
-  t = getPermissions(filePermissions(p), props);
-  ok = any(t{:,:}, 2);
-catch e
-  switch e.identifier
-    case {'MATLAB:UndefinedFunction', 'Octave:undefined-function'}
-      a = file_attributes_legacy(p);
-      ok = a.UserWrite || a.GroupWrite || a.OtherWrite;
-    otherwise, rethrow(e)
-  end
+
+  t = getPermissions(filePermissions(p(i)), props);
+  ok(i) = any(t{:,:}, 2);
+
+else
+  a = file_attributes_legacy(p);
+  ok = a.UserWrite || a.GroupWrite || a.OtherWrite;
 end
 
 end

test/TestExists.m

@@ -1,25 +1,42 @@
 classdef TestExists < matlab.unittest.TestCase
 
 properties(TestParameter)
-Ps = {{pwd(), true}, {mfilename("fullpath") + ".m", true}, ...
-      {"TestFileImpure.m", true}}
+Ps = {
+{pwd(), true}, ...
+{mfilename("fullpath") + ".m", true}, ...
+{fileparts(mfilename("fullpath")) + "/../Readme.md", true}, ...
+{tempname(), false}
+}
 % on CI matlabroot can be writable!
 end
 
 methods (Test, TestTags="impure")
 
 function test_exists(tc, Ps)
 ok = stdlib.exists(Ps{1});
-tc.verifyEqual(ok, Ps{2})
+tc.verifyEqual(ok, Ps{2}, Ps{1})
 end
 
 
 function test_is_readable(tc, Ps)
 ok = stdlib.is_readable(Ps{1});
-tc.verifyEqual(ok, Ps{2})
+tc.verifyEqual(ok, Ps{2}, Ps{1})
 end
 
 
+function test_is_writable(tc, Ps)
+ok = stdlib.is_writable(Ps{1});
+tc.verifyEqual(ok, Ps{2}, Ps{1})
+end
+
+function test_is_writable_dir(tc)
+tc.assumeFalse(isMATLABReleaseOlderThan('R2022a'))
+
+td = tc.createTemporaryFolder();
+
+tc.verifyTrue(stdlib.is_writable(td))
+end
+
 end
 
 end

test/TestFileImpure.m

@@ -1,8 +1,6 @@
 classdef TestFileImpure < matlab.unittest.TestCase
 
 properties(TestParameter)
-p_is_writable = {{pwd(), true}};
-
 p_same = {...
 {"..", "./.."}, ...
 {"..", pwd() + "/.."}, ...
@@ -22,12 +20,6 @@ function test_file_size(tc, p_file_size)
 end
 
 
-function test_is_writable(tc, p_is_writable)
-ok = stdlib.is_writable(p_is_writable{1});
-tc.verifyEqual(ok, p_is_writable{2})
-end
-
-
 function test_null_file(tc)
 import matlab.unittest.constraints.IsFile
 tc.assumeFalse(ispc)

test/TestIsExe.m

@@ -1,14 +1,12 @@
 classdef TestIsExe < matlab.unittest.TestCase
 
 properties (TestParameter)
-p = {{fileparts(mfilename('fullpath')) + "/../Readme.md", false}}
+p = {{fileparts(mfilename('fullpath')) + "/../Readme.md", false}, {"not-exist", false}}
 end
 
 methods(Test, TestTags="impure")
 
 function test_is_exe(tc, p)
-tc.assumeThat(p{1}, matlab.unittest.constraints.IsFile)
-
 tc.verifyEqual(stdlib.is_exe(p{1}), p{2})
 end