Skip to content

Commit 7f0070c

Browse files
committed
test and handle more corner cases
1 parent ae5e05d commit 7f0070c

File tree

11 files changed

+45
-20
lines changed

11 files changed

+45
-20
lines changed

+stdlib/absolute.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,8 @@
4343
end
4444
end
4545

46+
if isstring(p)
47+
c = string(c);
48+
end
49+
4650
end

+stdlib/canonical.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
if s == 1
2323
c = r.Name;
24-
elseif ~strict
24+
elseif ~strict && ~stdlib.strempty(r)
2525
c = stdlib.normalize(file);
2626
else
2727
c = '';

+stdlib/cpu_load.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@
1010
% If the system recent cpu usage is not available, the backend returns a negative or NaN value.
1111

1212
function [i, b] = cpu_load(backend)
13-
arguments
14-
backend (1,:) string = ["java", "python", "sys"]
13+
if nargin < 1
14+
backend = ["java", "python", "sys"];
15+
else
16+
backend = string(backend);
1517
end
1618

1719
i = [];

+stdlib/get_username.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@
77
% * b: backend used
88

99
function [r, b] = get_username(backend)
10-
arguments
11-
backend (1,:) string = ["java", "dotnet", "python", "sys"]
10+
if nargin < 1
11+
backend = ["java", "dotnet", "python", "sys"];
12+
else
13+
backend = string(backend);
1214
end
1315

1416
r = '';

+stdlib/hostname.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
% Ref: https://docs.oracle.com/javase/8/docs/api/java/net/InetAddress.html#getHostName--
1010

1111
function [r, b] = hostname(backend)
12-
arguments
13-
backend (1,:) string = ["java", "dotnet", "python", "sys"]
12+
if nargin < 1
13+
backend = ["java", "dotnet", "python", "sys"];
14+
else
15+
backend = string(backend);
1416
end
1517

1618
r = '';

+stdlib/is_admin.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
% * b: backend used
66

77
function [i, b] = is_admin(backend)
8-
arguments
9-
backend (1,:) string = ["java", "dotnet", "perl", "python", "sys"]
8+
if nargin < 1
9+
backend = ["java", "dotnet", "perl", "python", "sys"];
10+
else
11+
backend = string(backend);
1012
end
1113

1214
i = logical.empty;

+stdlib/os_version.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,10 @@
1111
% Ref: https://bugs.openjdk.org/browse/JDK-8274840
1212

1313
function [os, version, b] = os_version(backend)
14-
arguments
15-
backend (1,:) string = ["sys", "python", "dotnet", "java"]
14+
if nargin < 1
15+
backend = ["sys", "python", "dotnet", "java"];
16+
else
17+
backend = string(backend);
1618
end
1719

1820
os = '';

+stdlib/ram_free.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,10 @@
1313

1414

1515
function [i, b] = ram_free(backend)
16-
arguments
17-
backend (1,:) string = ["java", "python", "sys"]
16+
if nargin < 1
17+
backend = ["java", "python", "sys"];
18+
else
19+
backend = string(backend);
1820
end
1921

2022
i = uint64.empty;

+stdlib/ram_total.m

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,10 @@
1010
% * b: backend used
1111

1212
function [i, b] = ram_total(backend)
13-
arguments
14-
backend (1,:) string = ["java", "dotnet", "python", "sys"]
13+
if nargin < 1
14+
backend = ["java", "dotnet", "python", "sys"];
15+
else
16+
backend = string(backend);
1517
end
1618

1719
i = uint64.empty;

test/TestAbsolute.m

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
TestAbsolute < matlab.unittest.TestCase
44

55
properties (TestParameter)
6-
p1 = {'', "hi", "./hi", "../hi"};
6+
p1 = {'', "", "hi", './hi', "../hi"};
77
p2 = {{'', ''}, {'', 'hi'}, {"hi", ""}, {'there', 'hi'}};
88
end
99

@@ -25,6 +25,10 @@ function test_absolute1arg(tc, p1)
2525
r = pwd();
2626
end
2727

28+
if isstring(p1)
29+
r = string(r);
30+
end
31+
2832
rabs = stdlib.absolute(p1);
2933

3034
tc.verifyClass(rabs, class(p1))

0 commit comments

Comments
 (0)