absolute: no drop_slash. Make test robust

Author: scivision

+stdlib/absolute.m

@@ -40,16 +40,19 @@
 else
   b = base;
 end
+
+if ~stdlib.is_absolute(b)
+  b = strcat(pwd(), "/", b);
+end
+
 b = stdlib.posix(b);
 
-if stdlib.is_absolute(b)
-  c = strcat(b, "/", c);
+if stdlib.len(c) == 0
+  c = b;
 else
-  c = strcat(pwd(), "/", b, "/", c);
+  c = strcat(b, "/", c);
 end
 
-c = stdlib.drop_slash(c);
-
 end
 
 

.gitignore

@@ -1,4 +1,5 @@
 Filesystem.class
+CodeIssues.sarif
 
 code-coverage.xml
 

test/TestAbsolute.m

@@ -1,36 +1,67 @@
 classdef TestAbsolute < matlab.unittest.TestCase
 
+properties
+td
+end
+
+
 properties (TestParameter)
-p1 = init1arg()
-p2 = init2arg()
+p1
+p2
 end
 
 
-methods(Test)
+methods (TestParameterDefinition, Static)
 
-function test_absolute1arg(tc, p1)
-tc.verifyEqual(stdlib.absolute(p1{1}), p1{2})
+function p1 = init1arg()
+p1 = {"", "hi", "./hi", "../hi"};
 end
 
-function test_absolute2arg(tc, p2)
-tc.verifyEqual(stdlib.absolute(p2{1}, p2{2}), p2{3})
+function p2 = init2arg()
+p2 = {{"", ""}, {"", "hi"}, {"hi", ""}, {"there", "hi"}};
 end
 
 end
 
+
+methods(TestClassSetup)
+function set_cwd(tc)
+import matlab.unittest.fixtures.CurrentFolderFixture
+tc.td = stdlib.posix(tc.createTemporaryFolder());
+tc.applyFixture(CurrentFolderFixture(tc.td))
 end
+end
+
+
+methods(Test)
 
+function test_absolute1arg(tc, p1)
 
-function p = init1arg()
-td = stdlib.posix(pwd());
-r = td + "/hi";
+r = tc.td;
 
-p = {{"", td}, {"hi", r}, {"./hi", td + "/./hi"}, {"../hi", td + "/../hi"}};
+if strlength(p1)
+  r = r + "/" + p1;
 end
 
-function p = init2arg()
-td = stdlib.posix(pwd());
-r = td + "/hi";
+tc.verifyEqual(stdlib.absolute(p1), r)
+end
+
+
+function test_absolute2arg(tc, p2)
+
+r = tc.td;
+
+if strlength(p2{2})
+  r = r + "/" + p2{2};
+end
+
+if strlength(p2{1})
+  r = r + "/" + p2{1};
+end
+
+tc.verifyEqual(stdlib.absolute(p2{1}, p2{2}), r)
+end
+
+end
 
-p = {{"", "", td}, {"", "hi", r}, {"hi", "", r}, {"there", "hi", td + "/hi/there"}};
 end