set_permission: correct algorithms and layout

Author: scivision

+stdlib/+native/set_permissions_legacy.m renamed to +stdlib/+legacy/set_permissions.m

@@ -1,4 +1,4 @@
-function ok = set_permissions_legacy(file, readable, writable, executable)
+function ok = set_permissions(file, readable, writable, executable)
 
 mode = '';
 % mode is space-delimited

+stdlib/+native/set_permissions.m

@@ -2,16 +2,35 @@
 
 p = filePermissions(file);
 
+k = string.empty;
+v = logical.empty;
+
 if readable ~= 0
-  setPermissions(p, "Readable", readable > 0);
+  k(end+1) = "Readable";
+  v(end+1) = readable > 0;
 end
+
 if writable ~= 0
-  setPermissions(p, "Writable", writable > 0);
+  k(end+1) = "Writable";
+  v(end+1) = writable > 0;
 end
+
 if executable ~= 0
-  setPermissions(p, "Executable", executable > 0);
+  if ispc()
+    if executable > 0 && ~any(ismember(k, "Readable"))
+      k(end+1) = "Readable";
+      v(end+1) = true;
+    end
+  else
+    k(end+1) = "Executable";
+    v(end+1) = executable > 0;
+  end
 end
 
 ok = true;
 
+if ~isempty(k)
+  setPermissions(p, k, v)
+end
+
 end

+stdlib/set_permissions.m

@@ -23,7 +23,7 @@
 
 
 if isMATLABReleaseOlderThan('R2025a')
-  ok = stdlib.native.set_permissions_legacy(file, readable, writable, executable);
+  ok = stdlib.legacy.set_permissions(file, readable, writable, executable);
 else
   ok = stdlib.native.set_permissions(file, readable, writable, executable);
 end

test/TestPermissions.m

@@ -2,7 +2,7 @@
 
 properties (TestParameter)
 Ps = {".", pwd(), "", tempname(), mfilename('fullpath') + ".m"}
-sp_fun = {@stdlib.native.set_permissions, @stdlib.native.set_permissions_legacy}
+sp_fun = {@stdlib.native.set_permissions, @stdlib.legacy.set_permissions}
 end
 
 methods(TestClassSetup)
@@ -67,7 +67,7 @@ function test_set_permissions_nowrite(tc, sp_fun)
 tc.verifyTrue(sp_fun(nw, 0, -1, 0))
 p = stdlib.get_permissions(nw);
 
-if ~ispc() || ~endsWith(func2str(sp_fun), "legacy")
+if ~ispc() || ~contains(func2str(sp_fun), ".legacy.")
   tc.verifyThat(p, StartsWithSubstring("r-"), "no-write permission failed to set")
 end