use switch-case for concise/clarity

Author: scivision

+stdlib/create_symlink.m

@@ -6,8 +6,6 @@
 % * link: path to create link at
 %%% Outputs
 % * ok: true if successful
-%
-% Ref: https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#createSymbolicLink(java.nio.file.Path,java.nio.file.Path,java.nio.file.attribute.FileAttribute...)
 
 function ok = create_symlink(target, link)
 arguments
@@ -20,27 +18,22 @@
   createSymbolicLink(link, target);
   ok = true;
 catch e
-  if strcmp(e.identifier, "MATLAB:io:filesystem:symlink:NeedsAdminPerms") || ...
-      strcmp(e.identifier, 'MATLAB:UndefinedFunction')
+  switch e.identifier
+    case {"MATLAB:io:filesystem:symlink:NeedsAdminPerms", "MATLAB:UndefinedFunction"}
     % windows requires RunAsAdmin
     % https://www.mathworks.com/help/releases/R2024b/matlab/ref/createsymboliclink.html
     % ok = java.nio.file.Files.createSymbolicLink(java.io.File(link).toPath(), java.io.File(target).toPath());
     % Matlab Java doesn't recognize the optional argument omitted.
     % see example/Filesystem.java for this working in plain Java.
     % see example/javaCreateSymbolicLink.m for a non-working attempt in Matlab.
-
-    warning(e.identifier, "buildtool mex  \n%s", e.message)
-
-    ok = false;
-  elseif strcmp(e.identifier, "Octave:undefined-function")
-    [err, msg] = symlink(target, link);
-    ok = err == 0;
-    if ~ok
-      warning("create_symlink: %s", msg)
-    end
-  else
-    warning(e.identifier, "%s", e.message)
-    ok = false;
+      warning(e.identifier, "buildtool mex  \n%s", e.message)
+      ok = false;
+    case "Octave:undefined-function"
+      err = symlink(target, link);
+      ok = err == 0;
+    otherwise
+      warning(e.identifier, "%s", e.message)
+      ok = false;
   end
 end
 

+stdlib/get_permissions.m

@@ -12,18 +12,17 @@
 try
   v = filePermissions(f);
 catch e
-  if strcmp(e.identifier, "MATLAB:io:filesystem:filePermissions:CannotFindLocation")
-    return
-  elseif strcmp(e.identifier, "Octave:undefined-function")
-    try  %#ok<TRYNC>
-      p = stat(f).modestr;
-    end
-    return
-  elseif strcmp(e.identifier, "MATLAB:UndefinedFunction")
-    v = file_attributes(f);
-    if isempty(v), return, end
-  else
-    rethrow(e)
+  switch e.identifier
+    case "MATLAB:io:filesystem:filePermissions:CannotFindLocation", return
+    case "Octave:undefined-function"
+      try  %#ok<TRYNC>
+        p = stat(f).modestr;
+      end
+      return
+    case "MATLAB:UndefinedFunction"
+      v = file_attributes(f);
+      if isempty(v), return, end
+    otherwise, rethrow(e)
   end
 end
 

+stdlib/get_pid.m

@@ -5,12 +5,10 @@
 try
   pid = matlabProcessID;
 catch e
-  if strcmp(e.identifier, "MATLAB:UndefinedFunction")
-    pid = uint64(feature("getpid"));
-  elseif strcmp(e.identifier, "Octave:undefined-function")
-    pid = uint64(getpid());
-  else
-    rethrow(e)
+  switch e.identifier
+    case "MATLAB:UndefinedFunction", pid = uint64(feature("getpid"));
+    case "Octave:undefined-function", pid = uint64(getpid());
+    otherwise, rethrow(e)
   end
 end
 

+stdlib/is_symlink.m

@@ -10,12 +10,10 @@
 try
   ok = isSymbolicLink(p);
 catch e
-  if strcmp(e.identifier, "MATLAB:UndefinedFunction")
-    ok = java.nio.file.Files.isSymbolicLink(javaPathObject(stdlib.absolute(p, "", false)));
-  elseif strcmp(e.identifier, "Octave:undefined-function")
-    ok = S_ISLNK(stat(p).mode);
-  else
-    rethrow(e)
+  switch e.identifier
+    case "MATLAB:UndefinedFunction", ok = java.nio.file.Files.isSymbolicLink(javaPathObject(stdlib.absolute(p, "", false)));
+    case "Octave:undefined-function", ok = S_ISLNK(stat(p).mode);
+    otherwise, rethrow(e)
   end
 end
 

+stdlib/read_symlink.m

@@ -13,22 +13,21 @@
   [ok, t] = isSymbolicLink(p);
   if ~ok, return, end
 catch e
-
-if strcmp(e.identifier, "Octave:undefined-function")
-  t = readlink(p);
-elseif strcmp(e.identifier, 'MATLAB:UndefinedFunction')
-  if ~stdlib.is_symlink(p)
-    return
+  switch e.identifier
+    case "Octave:undefined-function", t = readlink(p);
+    case "MATLAB:UndefinedFunction"
+      if ~stdlib.is_symlink(p)
+        return
+      end
+
+      % must be absolute path
+      % must not be .canonical or symlink is gobbled!
+      r = stdlib.absolute(p, "", false);
+
+      % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#readSymbolicLink(java.nio.file.Path)
+      t = java.nio.file.Files.readSymbolicLink(javaPathObject(r));
+    otherwise, rethrow(e)
   end
-
-  % must be absolute path
-  % must not be .canonical or symlink is gobbled!
-  r = stdlib.absolute(p, "", false);
-
-  % https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/nio/file/Files.html#readSymbolicLink(java.nio.file.Path)
-  t = java.nio.file.Files.readSymbolicLink(javaPathObject(r));
-end
-
 end
 
 r = stdlib.posix(t);