posix: don't coerce to string for efficiency

Author: scivision

+stdlib/expanduser.m

@@ -19,7 +19,7 @@
   return
 end
 
-home = stdlib.homedir();
+home = string(stdlib.homedir());
 if ~strlength(home), return, end
 
 if L < 2

+stdlib/handle2filename.m

@@ -6,7 +6,7 @@
   fileHandle (1,1) {mustBeInteger}
 end
 
-n = "";
+n = '';
 
 if fileHandle >= 0
   n = stdlib.posix(fopen(fileHandle));

+stdlib/posix.m

@@ -5,7 +5,7 @@
 
 function r = posix(p)
 arguments
-  p (1,1) string
+  p {mustBeTextScalar}
 end
 
 if ispc

+stdlib/windows_shortname.m

@@ -29,7 +29,6 @@
 
 s = string(s);
 
-
 end
 
 %!testif 0

test/TestCanonical.m

@@ -18,7 +18,7 @@
 methods(Test)
 
 function test_canonical(tc, p)
-tc.verifyEqual(stdlib.canonical(p{1}, true), p{2})
+tc.verifyEqual(stdlib.canonical(p{1}, true), string(p{2}))
 end
 
 end

test/TestFileImpure.m

@@ -12,7 +12,7 @@
 {"..", "./..", true}, ...
 {"..", pwd() + "/..", true}}
 
-ph = {{0, '"stdin"'}, {1, '"stdout"'}, {2, '"stderr"'}, {fopen(tempname()), ""}}
+ph = {{0, '"stdin"'}, {1, '"stdout"'}, {2, '"stderr"'}, {fopen(tempname()), ''}}
 
 p_file_size = {mfilename("fullpath") + ".m", "", pwd()}
 end
@@ -37,7 +37,7 @@ function test_is_writable(tc, p_is_writable)
 
 
 function test_expanduser(tc, p_expand)
-tc.verifyEqual(stdlib.expanduser(p_expand{1}), p_expand{2})
+tc.verifyEqual(stdlib.expanduser(p_expand{1}), string(p_expand{2}))
 end
 
 
@@ -70,7 +70,7 @@ function test_get_pid(tc)
 
 
 function test_handle2filename(tc, ph)
-tc.verifyEqual(stdlib.handle2filename(ph{1}), string(ph{2}))
+tc.verifyEqual(stdlib.handle2filename(ph{1}), ph{2})
 end
 
 end

test/TestJoin.m

@@ -19,7 +19,7 @@
 
 methods (Test)
 function test_join(tc, p)
-tc.verifyEqual(stdlib.join(p{1}, p{2}), p{3})
+tc.verifyEqual(stdlib.join(p{1}, p{2}), string(p{3}))
 end
 end
 

test/TestResolve.m

@@ -11,11 +11,9 @@ function test_resolve_relative(tc)
 import matlab.unittest.constraints.StartsWithSubstring
 import matlab.unittest.constraints.ContainsSubstring
 
-td = stdlib.posix(pwd());
-
 % all non-existing files
 
-tc.verifyEqual(stdlib.resolve("", true), stdlib.posix(td))
+tc.verifyEqual(stdlib.resolve("", true), string(stdlib.posix(pwd())))
 
 pabs = stdlib.resolve('2foo', true);
 pabs2 = stdlib.resolve('4foo', true);
@@ -41,7 +39,7 @@ function test_resolve_relative(tc)
 end
 
 function test_resolve_fullpath(tc, p)
-tc.verifyEqual(stdlib.resolve(p{1}, true), p{2})
+tc.verifyEqual(stdlib.resolve(p{1}, true), string(p{2}))
 end
 
 end

test/TestWindowsCOM.m

@@ -2,7 +2,7 @@
 
 properties (TestParameter)
 Pn = {""}
-Pmr = {string(matlabroot), stdlib.posix(matlabroot)}
+Pmr = {matlabroot, stdlib.posix(matlabroot)}
 end
 
 methods (Test)
@@ -38,9 +38,9 @@ function test_short_file(tc, Pmr)
   if contains(Pmr, " ")
     tc.verifySubstring(s, "~")
   end
-  tc.verifyEqual(stdlib.canonical(s), stdlib.posix(Pmr), "shortname didn't resolve same as canonical")
+  tc.verifyEqual(stdlib.canonical(s), string(stdlib.posix(Pmr)), "shortname didn't resolve same as canonical")
 else
-  tc.verifyEqual(s, Pmr)
+  tc.verifyEqual(string(s), string(Pmr))
 end
 
 end