hostname: functionalize and add tests

Author: scivision

+stdlib/+dotnet/get_hostname.m

@@ -0,0 +1,6 @@
+function n = get_hostname()
+
+n = string(System.Environment.MachineName);
+% https://learn.microsoft.com/en-us/dotnet/api/system.environment.machinename
+
+end

+stdlib/+java/get_hostname.m

@@ -0,0 +1,5 @@
+function n = get_hostname()
+
+n = string(javaMethod("getLocalHost", "java.net.InetAddress").getHostName());
+
+end

+stdlib/+python/get_hostname.m

@@ -1,8 +1,8 @@
 function n = get_hostname()
 
 try
-  n = char(py.socket.gethostname());
+  n = string(py.socket.gethostname());
 catch e
   warning(e.identifier, "get_hostname failed: %s", e.message);
-  n = '';
+  n = string.empty;
 end

+stdlib/hostname.m

@@ -8,20 +8,15 @@
 n = '';
 
 if stdlib.has_dotnet()
-  n = System.Environment.MachineName;
-  % https://learn.microsoft.com/en-us/dotnet/api/system.environment.machinename
+  n = stdlib.dotnet.get_hostname();
 elseif stdlib.has_java()
-  n = javaMethod("getLocalHost", "java.net.InetAddress").getHostName();
+  n = stdlib.java.get_hostname();
 elseif stdlib.has_python()
   n = stdlib.python.get_hostname();
 elseif stdlib.isoctave()
   n = gethostname();
 end
 
-try  %#ok<*TRYNC>
-  n = string(n);
-end
-
 end
 
 %!assert (!isempty(hostname()))

+stdlib/ram_total.m

@@ -8,15 +8,11 @@
 
 function bytes = ram_total()
 
-bytes = 0;
-
 if stdlib.dotnet_api() >= 6
   bytes = stdlib.dotnet.ram_total();
 elseif stdlib.has_java()
   bytes = stdlib.java.ram_total();
-end
-
-if bytes <= 0
+else
   bytes = stdlib.sys.ram_total();
 end
 

test/TestSys.m

@@ -8,6 +8,7 @@
 fun = {stdlib.isoctave, stdlib.has_dotnet, ...
        stdlib.has_java, stdlib.has_python}
 cpu_arch_fun = {@stdlib.cpu_arch, @stdlib.dotnet.cpu_arch, @stdlib.java.cpu_arch}
+host_fun = {@stdlib.hostname, @stdlib.dotnet.get_hostname, @stdlib.java.get_hostname, @stdlib.python.get_hostname}
 ram_free_fun = {@stdlib.ram_free, @stdlib.sys.ram_free, @stdlib.java.ram_free, @stdlib.python.ram_free}
 ram_total_fun = {@stdlib.ram_total, @stdlib.sys.ram_total, @stdlib.dotnet.ram_total @stdlib.java.ram_total}
 end
@@ -77,19 +78,16 @@ function test_cpu_count(tc)
 end
 
 function test_checkRAM(tc)
-tc.assumeTrue(ispc() || stdlib.has_java())
-
 tc.verifyClass(stdlib.checkRAM(1, "double"), "logical")
 end
 
 function test_is_parallel(tc)
 tc.verifyClass(stdlib.is_parallel_worker(), 'logical')
 end
 
-function test_hostname(tc)
-tc.assumeTrue(stdlib.has_dotnet() || stdlib.has_java() || stdlib.has_python())
-
-h = stdlib.hostname();
+function test_hostname(tc, host_fun)
+is_capable(tc, host_fun)
+h = host_fun();
 tc.verifyGreaterThan(strlength(h), 0)
 end