remove unnecessary input string coercion

scivision · scivision · commit a234d1eb25ea · 2025-05-31T23:06:24.000-04:00
diff --git a/+stdlib/get_modtime.m b/+stdlib/get_modtime.m
@@ -8,7 +8,7 @@
 
 function t = get_modtime(p)
 arguments
-  p (1,1) string
+  p {mustBeTextScalar}
 end
 
 
diff --git a/+stdlib/get_permissions.m b/+stdlib/get_permissions.m
@@ -4,7 +4,7 @@
 
 function p = get_permissions(f)
 arguments
-  f (1,1) string
+  f {mustBeTextScalar}
 end
 
 p = '';
diff --git a/+stdlib/h4exists.m b/+stdlib/h4exists.m
@@ -7,8 +7,8 @@
 %%% Outputs
 % * exists: boolean
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 sds = hdfinfo(file).SDS;
diff --git a/+stdlib/h4size.m b/+stdlib/h4size.m
@@ -8,8 +8,8 @@
 
 function fsize = h4size(file, variable)
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 sds = hdfinfo(file).SDS;
diff --git a/+stdlib/h4variables.m b/+stdlib/h4variables.m
@@ -10,7 +10,7 @@
 
 function names = h4variables(file)
 arguments
-  file (1,1) string
+  file {mustBeTextScalar}
 end
 
 finf = hdfinfo(file);
diff --git a/+stdlib/h5exists.m b/+stdlib/h5exists.m
@@ -8,8 +8,8 @@
 
 function exists = h5exists(file, variable)
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 exists = false;
diff --git a/+stdlib/h5save.m b/+stdlib/h5save.m
@@ -20,11 +20,11 @@
 
 function h5save(filename, varname, A, opts)
 arguments
-  filename (1,1) string
-  varname (1,1) string
+  filename {mustBeTextScalar}
+  varname {mustBeTextScalar}
   A {mustBeNonempty}
   opts.size (1,:) double {mustBeInteger,mustBeNonnegative} = []
-  opts.type (1,1) string = ""
+  opts.type {mustBeTextScalar} = ''
   opts.compressLevel (1,1) double {mustBeInteger,mustBeNonnegative} = 0
 end
 
diff --git a/+stdlib/h5save_exist.m b/+stdlib/h5save_exist.m
@@ -3,8 +3,8 @@
 
 function h5save_exist(filename, varname, A, sizeA)
 arguments
-  filename (1,1) string
-  varname (1,1) string
+  filename {mustBeTextScalar}
+  varname {mustBeTextScalar}
   A {mustBeNonempty}
   sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
 end
diff --git a/+stdlib/h5save_new.m b/+stdlib/h5save_new.m
@@ -3,8 +3,8 @@
 
 function h5save_new(filename, varname, A, sizeA, compressLevel)
 arguments
-  filename (1,1) string
-  varname (1,1) string
+  filename {mustBeTextScalar}
+  varname {mustBeTextScalar}
   A {mustBeNonempty}
   sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
   compressLevel (1,1) double {mustBeInteger,mustBeNonnegative} = 0
diff --git a/+stdlib/h5size.m b/+stdlib/h5size.m
@@ -8,8 +8,8 @@
 
 function fsize = h5size(file, variable)
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 dsi = h5info(file, variable).Dataspace;
diff --git a/+stdlib/h5variables.m b/+stdlib/h5variables.m
@@ -10,8 +10,8 @@
 
 function names = h5variables(file, group)
 arguments
-  file (1,1) string
-  group (1,1) string = ""
+  file {mustBeTextScalar}
+  group {mustBeTextScalar} = ''
 end
 
 if ~strlength(group)
diff --git a/+stdlib/ini2struct.m b/+stdlib/ini2struct.m
@@ -5,7 +5,7 @@
 
 function Struct = ini2struct(filename)
 arguments
-  filename (1,1) string
+  filename {mustBeTextScalar,mustBeFile}
 end
 
 f = fopen(filename,'r');                    % open file
diff --git a/+stdlib/ncexists.m b/+stdlib/ncexists.m
@@ -8,8 +8,8 @@
 
 function exists = ncexists(file, variable)
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 exists = false;
diff --git a/+stdlib/ncsave.m b/+stdlib/ncsave.m
@@ -12,11 +12,11 @@
 
 function ncsave(filename, varname, A, opts)
 arguments
-  filename (1,1) string
-  varname (1,1) string
+  filename {mustBeTextScalar}
+  varname {mustBeTextScalar}
   A {mustBeNonempty}
   opts.dims cell = {}
-  opts.type (1,1) string = ""
+  opts.type {mustBeTextScalar} = ''
   opts.compressLevel (1,1) double {mustBeInteger,mustBeNonnegative} = 0
 end
 
diff --git a/+stdlib/ncsave_new.m b/+stdlib/ncsave_new.m
@@ -3,8 +3,8 @@
 
 function ncsave_new(file, varname, A, sizeA, ncdims, compressLevel)
 arguments
-  file (1,1) string
-  varname (1,1) string
+  file {mustBeTextScalar}
+  varname {mustBeTextScalar}
   A {mustBeNonempty}
   sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
   ncdims (1,:) cell = {}
diff --git a/+stdlib/ncsize.m b/+stdlib/ncsize.m
@@ -9,8 +9,8 @@
 
 function fsize = ncsize(file, variable)
 arguments
-  file (1,1) string
-  variable (1,1) string
+  file {mustBeTextScalar}
+  variable {mustBeTextScalar}
 end
 
 dsi = ncinfo(file, variable);
diff --git a/+stdlib/ncvariables.m b/+stdlib/ncvariables.m
@@ -10,8 +10,8 @@
 
 function names = ncvariables(file, group)
 arguments
-  file (1,1) string
-  group (1,1) string = ""
+  file {mustBeTextScalar}
+  group {mustBeTextScalar} = ''
 end
 
 
diff --git a/+stdlib/private/coerce_ds.m b/+stdlib/private/coerce_ds.m
@@ -2,7 +2,7 @@
 % used by h5save and ncsave
 arguments
   A
-  dtype (1,1) string
+  dtype {mustBeTextScalar}
 end
 
 if ischar(A)
@@ -14,12 +14,6 @@
   return
 end
 
-if dtype == "float64"
-  dtype = "double";
-elseif dtype == "float32"
-  dtype = "single";
-end
-
 switch dtype
   case ""
     return
diff --git a/+stdlib/private/h5save_scalar.m b/+stdlib/private/h5save_scalar.m
@@ -3,7 +3,7 @@ function h5save_scalar(file, hpath, A)
 %  h5create doesn't support scalars
 arguments
   file (1,1)
-  hpath (1,1) string
+  hpath {mustBeTextScalar}
   A (1,1)
 end
 
diff --git a/+stdlib/read_symlink.m b/+stdlib/read_symlink.m
@@ -4,7 +4,7 @@
 
 function r = read_symlink(p)
 arguments
-  p (1,1) string
+  p {mustBeTextScalar}
 end
 
 r = "";
diff --git a/+stdlib/samepath.m b/+stdlib/samepath.m
@@ -15,8 +15,8 @@
 
 function issame = samepath(path1, path2)
 arguments
-  path1 (1,1) string
-  path2 (1,1) string
+  path1 {mustBeTextScalar}
+  path2 {mustBeTextScalar}
 end
 
 % simpler our way than
diff --git a/+stdlib/touch.m b/+stdlib/touch.m
@@ -2,7 +2,7 @@
 
 function ok = touch(p, t)
 arguments
-  p (1,1) string
+  p {mustBeTextScalar}
   t datetime {mustBeScalarOrEmpty} = datetime.empty
 end
 
diff --git a/+stdlib/windows_shortname.m b/+stdlib/windows_shortname.m
@@ -11,7 +11,7 @@
 
 function s = windows_shortname(p)
 arguments
-  p (1,1) string
+  p {mustBeTextScalar}
 end
 
 s = p;
diff --git a/test/TestHDF5.m b/test/TestHDF5.m
@@ -6,7 +6,7 @@
 
 properties (TestParameter)
 str = {"string", 'char'}
-type = {"single", "double", "float64", "float32",...
+type = {"single", "double", ...
             "int8", "int16", "int32", "int64", ...
             "uint8", "uint16", "uint32", "uint64", "string"}
 end
