add too_old(). get_permissions() outputs char

Author: scivision

+stdlib/get_permissions.m

@@ -1,6 +1,6 @@
 %% GET_PERMISSIONS permissions of file or directory
 %
-% output is string like "rwxrwxr--"
+% output is char like 'rwxrwxr--'
 
 function p = get_permissions(f)
 arguments
@@ -9,14 +9,27 @@
 
 p = "";
 
-% Get the permissions of a file or directory
-[status, v] = fileattrib(f);
-if status == 0
-  return
+if ~stdlib.isoctave() && ~stdlib.too_old("R2025a")
+  perms = filePermissions(f);
+  p = perm2char(perms);
+% elseif ~ispc && ~isMATLABReleaseOlderThan("R2024b")
+% % undocumented internals in Matlab R2024b, does not work on Windows
+%   perms = matlab.io.UnixPermissions(f);
+%   p = perm2str(perms);
+else
+  [status, v] = fileattrib(f);
+  if status == 0
+    return
+  end
+  p = perm2char(v);
+end
+
 end
 
-% Extract the permission string
-p = "---------"; % Default permissions
+
+function p = perm2char(v)
+
+p = '---------';
 
 groupRead = ~isnan(v.GroupRead) && logical(v.GroupRead);
 groupWrite = ~isnan(v.GroupWrite) && logical(v.GroupWrite);
@@ -25,34 +38,22 @@
 otherWrite = ~isnan(v.OtherWrite) && logical(v.OtherWrite);
 otherExecute = ~isnan(v.OtherExecute) && logical(v.OtherExecute);
 
-try
-
-if v.UserRead,    p = replaceBetween(p, 1, 1, "r"); end
-if v.UserWrite,   p = replaceBetween(p, 2, 2, "w"); end
-if v.UserExecute, p = replaceBetween(p, 3, 3, "x"); end
-if groupRead,     p = replaceBetween(p, 4, 4, "r"); end
-if groupWrite,    p = replaceBetween(p, 5, 5, "w"); end
-if groupExecute,  p = replaceBetween(p, 6, 6, "x"); end
-if otherRead,     p = replaceBetween(p, 7, 7, "r"); end
-if otherWrite,    p = replaceBetween(p, 8, 8, "w"); end
-if otherExecute,  p = replaceBetween(p, 9, 9, "x"); end
-
-catch e
-  if ~strcmp(e.identifier, "Octave:undefined-function")
-    rethrow(e)
-  end
-
-  if v.UserRead,    p(1) = "r"; end
-  if v.UserWrite,   p(2) = "w"; end
-  if v.UserExecute, p(3) = "x"; end
-  if groupRead,     p(4) = "r"; end
-  if groupWrite,    p(5) = "w"; end
-  if groupExecute,  p(6) = "x"; end
-  if otherRead,     p(7) = "r"; end
-  if otherWrite,    p(8) = "w"; end
-  if otherExecute,  p(9) = "x"; end
+if isstruct(v) % from fileattrib
+  if v.UserRead,  p(1) = "r"; end
+  if v.UserWrite, p(2) = "w"; end
+else % filePermissions object
+  if v.Readable,  p(1) = "r"; end
+  if v.Writable,  p(2) = "w"; end
 end
 
+if v.UserExecute, p(3) = "x"; end
+if groupRead,     p(4) = "r"; end
+if groupWrite,    p(5) = "w"; end
+if groupExecute,  p(6) = "x"; end
+if otherRead,     p(7) = "r"; end
+if otherWrite,    p(8) = "w"; end
+if otherExecute,  p(9) = "x"; end
+
 end
 
 %!assert(length(get_permissions('get_permissions.m')) == 9)

+stdlib/too_old.m

@@ -0,0 +1,22 @@
+%% TOO_OLD check if Matlab older than R2020b or as specificed by release "r"
+% returns true for any version for any Matlab older than R2020b
+% purpose is to avoid verLessThan lint warnings.
+%
+% example:
+%  too_old("R2020b")
+%
+
+
+function old = too_old(r)
+
+try
+  old = isMATLABReleaseOlderThan(r);
+catch e
+  if strcmp(e.identifier, 'MATLAB:UndefinedFunction')
+    old = true;
+  else
+    rethrow(e)
+  end
+end
+
+end

test/TestFileImpure.m

@@ -77,8 +77,11 @@ function test_get_pid(tc)
 
 function test_get_permissions(tc)
 import matlab.unittest.constraints.StartsWithSubstring
+import matlab.unittest.constraints.IsOfClass
+
 p = stdlib.get_permissions(".");
 tc.verifyThat(p, StartsWithSubstring("r"))
+tc.verifyThat(p, IsOfClass("char"))
 end
 
 function test_handle2filename(tc, ph)

test/TestHDF5.m

@@ -44,7 +44,7 @@ function setup_file(tc)
 stdlib.h5save(bf, '/A3', A3, "size", size(A3))
 stdlib.h5save(bf, '/A4', A4)
 
-if ~too_old("R2020b")
+if ~stdlib.too_old("R2020b")
 stdlib.h5save(bf, "/utf", utf)
 stdlib.h5save(bf, "/utf2", utf2)
 end
@@ -75,7 +75,7 @@ function test_get_variables(tc)
 v = stdlib.h5variables(basic);
 k = ["A0", "A1", "A2", "A3", "A4"];
 
-if ~too_old("R2020b")
+if ~stdlib.too_old("R2020b")
   k = [k, "utf", "utf2"];
 end
 
@@ -128,7 +128,7 @@ function test_size(tc)
 tc.verifyTrue(isvector(s))
 tc.verifyEqual(s, [4,3,2,5])
 
-if ~too_old("R2020b")
+if ~stdlib.too_old("R2020b")
 s = stdlib.h5size(basic, '/utf');
 tc.verifyEmpty(s)
 
@@ -164,7 +164,7 @@ function test_read(tc)
 tc.verifyEqual(ndims(s), 4)
 tc.verifyEqual(s, tc.TestData.A4)
 
-if ~too_old("R2020b")
+if ~stdlib.too_old("R2020b")
 s = h5read(basic, '/utf');
 tc.verifyTrue(ischar(s))
 tc.verifyEqual(s, tc.TestData.utf)
@@ -196,7 +196,7 @@ function test_coerce(tc, type)
 basic = tc.TestData.basic;
 
 if any(type == ["string", "char"])
-  tc.assumeFalse(too_old("R2020b"))
+  tc.assumeFalse(stdlib.too_old("R2020b"))
 end
 
 stdlib.h5save(basic, "/" + type, 0, "type", type)
@@ -245,7 +245,7 @@ function test_int8(tc)
 
 function test_string(tc, str)
 
-tc.assumeFalse(too_old("R2020b"))
+tc.assumeFalse(stdlib.too_old("R2020b"))
 
 basic = tc.TestData.basic;
 

test/TestNetCDF.m

@@ -41,7 +41,7 @@ function setup_file(tc)
 stdlib.ncsave(basic, 'A3', A3, "dims", {'x3', size(A3,1), 'y3', size(A3,2), 'z3', size(A3,3)})
 stdlib.ncsave(basic, 'A4', A4, "dims", {'x4', size(A4,1), 'y4', size(A4,2), 'z4', size(A4,3), 'w4', size(A4,4)})
 
-if ~too_old('R2021b')
+if ~stdlib.too_old('R2021b')
   stdlib.ncsave(basic, "utf0", utf0)
   stdlib.ncsave(basic, "utf1", utf1, "dims", {'s1', size(utf1, 1)})
   stdlib.ncsave(basic, "utf2", utf2, "dims", {'s1', size(utf2, 1), 't1', size(utf2, 2)})
@@ -62,7 +62,7 @@ function test_get_variables(tc)
 
 k = ["A0", "A1", "A2", "A3", "A4"];
 
-if ~too_old('R2021b')
+if ~stdlib.too_old('R2021b')
   k = [k, ["utf0", "utf1", "utf2"]];
 end
 
@@ -122,7 +122,7 @@ function test_size(tc)
 function test_size_string(tc)
 basic = tc.TestData.basic;
 
-tc.assumeFalse(too_old('R2021b'), "NetCDF4 string requires Matlab >= R2021b")
+tc.assumeFalse(stdlib.too_old('R2021b'), "NetCDF4 string requires Matlab >= R2021b")
 
 s = stdlib.ncsize(basic, 'utf0');
 tc.verifyEmpty(s)
@@ -164,7 +164,7 @@ function test_read_string(tc)
 import matlab.unittest.constraints.IsOfClass
 basic = tc.TestData.basic;
 
-tc.assumeFalse(too_old('R2021b'), "NetCDF4 string requires Matlab >= R2021b")
+tc.assumeFalse(stdlib.too_old('R2021b'), "NetCDF4 string requires Matlab >= R2021b")
 
 s = ncread(basic, 'utf0');
 tc.verifyThat(s, IsOfClass('string'))