create_symlink: functionalize and improve testt

Author: scivision

+stdlib/+dotnet/create_symlink.m

@@ -0,0 +1,12 @@
+function ok = create_symlink(target, link)
+
+% https://learn.microsoft.com/en-us/dotnet/api/system.io.file.createsymboliclink
+try
+  System.IO.File.CreateSymbolicLink(link, target);
+  ok = true;
+catch e
+  warning(e.identifier, "%s", e.message)
+  ok = false;
+end
+
+end

+stdlib/+python/create_symlink.m

@@ -1,5 +1,11 @@
 function ok = create_symlink(target, link)
 
+ok = false;
+
+if strlength(target) == 0 || strlength(link) == 0 || stdlib.exists(link)
+  return
+end
+
 try
   py.os.symlink(target, link);
   ok = true;

+stdlib/+sys/create_symlink.m

@@ -0,0 +1,21 @@
+
+function ok = create_symlink(target, link)
+
+ok = false;
+
+if strlength(target) == 0 || strlength(link) == 0
+  return
+end
+
+if ispc
+  cmd = sprintf('pwsh -c "New-Item -ItemType SymbolicLink -Path "%s" -Target "%s""', link, target);
+else
+  cmd = sprintf('ln -s "%s" "%s"', target, link);
+end
+
+% suppress output text on powershell
+[stat, ~] = system(cmd);
+
+ok = stat == 0;
+
+end

+stdlib/create_symlink.m

@@ -31,45 +31,20 @@
       if stdlib.has_python()
         ok = stdlib.python.create_symlink(target, link);
       elseif stdlib.dotnet_api() >= 6
-        ok = dotnet_create_symlink(target, link);
+        ok = stdlib.dotnet.create_symlink(target, link);
       else
-        ok = system_create_symlink(target, link);
+        ok = stdlib.sys.create_symlink(target, link);
       end
-    case "Octave:undefined-function", ok = symlink(target, link) == 0;
-    otherwise, warning(e.identifier, "%s", e.message)
+    case "Octave:undefined-function"
+      ok = symlink(target, link) == 0;
+    otherwise
+      warning(e.identifier, "%s", e.message)
   end
 end
 
 end
 
 
-function ok = system_create_symlink(target, link)
-
-if ispc
-  cmd = sprintf('pwsh -c "New-Item -ItemType SymbolicLink -Path "%s" -Target "%s""', link, target);
-else
-  cmd = sprintf('ln -s "%s" "%s"', target, link);
-end
-
-% suppress output text on powershell
-[stat, ~] = system(cmd);
-
-ok = stat == 0;
-end
-
-
-function ok = dotnet_create_symlink(target, link)
-
-% https://learn.microsoft.com/en-us/dotnet/api/system.io.file.createsymboliclink
-try
-  System.IO.File.CreateSymbolicLink(link, target);
-  ok = true;
-catch e
-  warning(e.identifier, "%s", e.message)
-end
-
-end
-
 %!assert (create_symlink("https://invalid", "https://invalid"), false)
 %!test
 %! if !ispc

+stdlib/set_modtime.m

@@ -1,5 +1,4 @@
 %% SET_MODTIME set modification time of path
-% requires: java
 
 function ok = set_modtime(p, t)
 arguments

test/TestSymlink.m

@@ -10,24 +10,21 @@
 p = {{"not-exist", false}, ...
     {mfilename("fullpath") + ".m", false}, ...
     {"", false}};
+create_symlink_fun = {@stdlib.create_symlink, @stdlib.sys.create_symlink, @stdlib.dotnet.create_symlink, @stdlib.python.create_symlink}
 is_symlink_fun   = {@stdlib.is_symlink,   @stdlib.sys.is_symlink,   @stdlib.dotnet.is_symlink,   @stdlib.java.is_symlink,   @stdlib.python.is_symlink}
 read_symlink_fun = {@stdlib.read_symlink, @stdlib.sys.read_symlink, @stdlib.dotnet.read_symlink, @stdlib.java.read_symlink, @stdlib.python.read_symlink}
 end
 
 
-methods(TestClassSetup)
-
-function set_temp_wd(tc)
-if isMATLABReleaseOlderThan('R2022a')
-  tc.td = tempname();
-  mkdir(tc.td);
-else
-  tc.td = tc.createTemporaryFolder();
-end
-end
+methods(TestMethodSetup)
+% needs to be per-method because multiple functions are used to make the same files
 
 function setup_symlink(tc)
 
+tc.assumeFalse(isMATLABReleaseOlderThan('R2022a'))
+
+tc.td = tc.createTemporaryFolder();
+
 tc.link = fullfile(tc.td, 'my.lnk');
 
 tc.target = strcat(mfilename("fullpath"), '.m');
@@ -38,15 +35,6 @@ function setup_symlink(tc)
 end
 
 
-methods(TestClassTeardown)
-function remove_temp_wd(tc)
-if isMATLABReleaseOlderThan('R2022a')
-  [s, m, i] = rmdir(tc.td, 's');
-  if ~s, warning(i, "Failed to remove temporary directory %s: %s", tc.td, m); end
-end
-end
-end
-
 
 methods (Test, TestTags=["impure", "symlink"])
 
@@ -75,16 +63,16 @@ function test_read_symlink(tc, read_symlink_fun)
 end
 
 
-function test_create_symlink(tc)
-fprintf("create_symlink  mex: %d\n", stdlib.is_mex_fun("stdlib.create_symlink"))
+function test_create_symlink(tc, create_symlink_fun)
+is_capable(tc, create_symlink_fun)
 
 tc.applyFixture(matlab.unittest.fixtures.SuppressedWarningsFixture(["MATLAB:io:filesystem:symlink:TargetNotFound","MATLAB:io:filesystem:symlink:FileExists"]))
 
-tc.verifyFalse(stdlib.create_symlink('', tempname()))
-tc.verifyFalse(stdlib.create_symlink(tc.target, tc.link), "should fail for existing symlink")
+tc.verifyFalse(create_symlink_fun('', tempname()))
+tc.verifyFalse(create_symlink_fun(tc.target, tc.link), "should fail for existing symlink")
 
 ano = tc.td + "/another.lnk";
-tc.verifyTrue(stdlib.create_symlink(tc.target, ano))
+tc.verifyTrue(create_symlink_fun(tc.target, ano))
 tc.verifyTrue(stdlib.is_symlink(ano))
 end
 

test/is_capable.m

@@ -12,7 +12,7 @@ function is_capable(tc, f)
 
   tc.assumeGreaterThan(dapi, 0)
 
-  if endsWith(n, ["ram_total", "read_symlink"])
+  if endsWith(n, ["create_symlink", "ram_total", "read_symlink"])
     tc.assumeGreaterThanOrEqual(dapi, 6);
   end