create_symlink: choose_method

Author: scivision

+stdlib/+native/create_symlink.m

@@ -0,0 +1,6 @@
+function ok = create_symlink(target, link)
+
+createSymbolicLink(link, target);
+ok = true;
+
+end

+stdlib/create_symlink.m

@@ -6,47 +6,15 @@
 %%% Outputs
 % * ok: true if successful
 
-function ok = create_symlink(target, link)
+function ok = create_symlink(target, link, method)
 arguments
   target {mustBeTextScalar}
   link {mustBeTextScalar}
+  method (1,:) string = ["native", "dotnet", "python", "sys"]
 end
 
-ok = false;
+fun = choose_method(method, "create_symlink", 'R2024b');
 
-try
-  createSymbolicLink(link, target);
-  ok = true;
-catch e
-  switch e.identifier
-    case {"MATLAB:io:filesystem:symlink:NeedsAdminPerms", "MATLAB:UndefinedFunction"}
-    % windows requires RunAsAdmin
-    % https://www.mathworks.com/help/releases/R2024b/matlab/ref/createsymboliclink.html
-    % ok = java.nio.file.Files.createSymbolicLink(java.io.File(link).toPath(), java.io.File(target).toPath());
-    % Matlab Java doesn't recognize the optional argument omitted.
-    % see example/Filesystem.java for this working in plain Java.
-    % see example/javaCreateSymbolicLink.m for a non-working attempt in Matlab.
-      if stdlib.strempty(target) || stdlib.strempty(link), return, end
+ok = fun(target, link);
 
-      if stdlib.has_python()
-        ok = stdlib.python.create_symlink(target, link);
-      elseif stdlib.dotnet_api() >= 6
-        ok = stdlib.dotnet.create_symlink(target, link);
-      else
-        ok = stdlib.sys.create_symlink(target, link);
-      end
-    case "Octave:undefined-function"
-      ok = symlink(target, link) == 0;
-    otherwise
-      warning(e.identifier, "%s", e.message)
-  end
 end
-
-end
-
-
-%!assert (create_symlink("https://invalid", "https://invalid"), false)
-%!test
-%! if !ispc
-%!   assert(create_symlink(tempname, tempname))
-%! endif

+stdlib/private/choose_method.m

@@ -15,7 +15,7 @@
     case "dotnet"
       has = @stdlib.has_dotnet;
 
-      if endsWith(name, ["ram_total", "read_symlink"])
+      if endsWith(name, ["create_symlink", "ram_total", "read_symlink"])
         if stdlib.dotnet_api() < 6, continue, end
       end
     case "java"
@@ -36,7 +36,12 @@
       end
 
     case {"legacy", "sys"}, has = true;
-    case "native", has = stdlib.strempty(minVersion) || ~isMATLABReleaseOlderThan(minVersion);
+    case "native"
+      has = stdlib.strempty(minVersion) || ~isMATLABReleaseOlderThan(minVersion);
+
+      if endsWith(name, "create_symlink")
+        if ~has || ispc(), continue, end
+      end
     otherwise
       has = str2func("stdlib.has_" + m);
   end

test/TestSymlink.m

@@ -10,7 +10,7 @@
 p = {{"not-exist", false}, ...
     {mfilename("fullpath") + ".m", false}, ...
     {"", false}};
-create_symlink_fun = {@stdlib.create_symlink, @stdlib.sys.create_symlink, @stdlib.dotnet.create_symlink, @stdlib.python.create_symlink}
+cs_fun = {'native', 'sys', 'dotnet', 'python'}
 Pre = {'', "", tempname()}
 rs_fun = {'native', 'sys', 'dotnet', 'java', 'python'}
 end
@@ -74,16 +74,22 @@ function test_read_symlink(tc, rs_fun)
 end
 
 
-function test_create_symlink(tc, create_symlink_fun)
-is_capable(tc, create_symlink_fun)
-
+function test_create_symlink(tc, cs_fun)
+tc.assumeNotEmpty(which("stdlib." + cs_fun + ".create_symlink"))
 tc.applyFixture(matlab.unittest.fixtures.SuppressedWarningsFixture(["MATLAB:io:filesystem:symlink:TargetNotFound","MATLAB:io:filesystem:symlink:FileExists"]))
 
-tc.verifyFalse(create_symlink_fun('', tempname()))
-tc.verifyFalse(create_symlink_fun(tc.target, tc.link), "should fail for existing symlink")
-
 ano = tc.td + "/another.lnk";
-tc.verifyTrue(create_symlink_fun(tc.target, ano))
+
+h = @stdilb.create_symlink;
+
+try
+  tc.verifyFalse(h('', tempname(), cs_fun))
+  tc.verifyFalse(h(tc.target, tc.link, cs_fun), "should fail for existing symlink")
+  tc.verifyTrue(h(tc.target, ano, cs_fun))
+catch e
+  tc.verifyEqual(e.identifier, 'stdlib:choose_method:NameError', e.message)
+  return
+end
 tc.verifyTrue(stdlib.is_symlink(ano))
 end
 

test/is_capable.m

@@ -16,7 +16,7 @@ function is_capable(tc, f)
     tc.assumeTrue(ispc(), "Windows only function")
   end
 
-  if endsWith(n, ["create_symlink", "ram_total"])
+  if endsWith(n, "ram_total")
     tc.assumeGreaterThanOrEqual(dapi, 6);
   end