efficiency, correctness

Author: scivision

+stdlib/+native/samepath.m

@@ -3,12 +3,24 @@
 % this canonical string method is less preferred to using device + inode.
 
 function y = samepath(path1, path2)
+arguments
+  path1 string
+  path2 string
+end
+
+assert(isequal(size(path1), size(path2)), "path1 string array size does not match path2 array size")
+
+y = false(size(path1));
 
-i = stdlib.strempty(path1) | stdlib.strempty(path2);
-y(i) = false;
+y(strlength(path1) | strlength(path2)) = true;
+
+% necessary for Matlab < R2024a
+if ~any(y)
+  return
+end
 
-c1 = stdlib.canonical(path1(~i), true);
-c2 = stdlib.canonical(path2(~i), true);
-y(~i) = ~stdlib.strempty(c1) & strcmp(c1, c2);
+c1 = stdlib.canonical(path1(y), true);
+c2 = stdlib.canonical(path2(y), true);
+y(y) = strlength(c1) & strcmp(c1, c2);
 
 end

test/TestSame.m

@@ -1,5 +1,5 @@
 classdef (SharedTestFixtures={ matlab.unittest.fixtures.PathFixture("..")}, ...
-          TestTags = {'R2019b', 'impure'}) ...
+          TestTags = {'impure'}) ...
     TestSame < matlab.unittest.TestCase
 
 properties (TestParameter)
@@ -19,7 +19,7 @@
 end
 
 
-methods(Test)
+methods(Test, TestTags={'R2019b'})
 
 function test_samepath(tc, p_same, backend)
 r = stdlib.samepath(p_same{:}, backend);
@@ -33,15 +33,17 @@ function test_samepath_notexist(tc, backend)
 tc.verifyFalse(stdlib.samepath("", "", backend))
 tc.verifyFalse(stdlib.samepath(t, t, backend))
 end
+end
 
 
+methods (Test, TestTags={'R2024a'})
 function test_samepath_array(tc, backend)
 in = [string(mfilename), string(mfilename('fullpath'))] + ".m";
 r = stdlib.samepath(in, fliplr(in), backend);
 tc.verifyClass(r, 'logical')
 tc.verifyEqual(r, [true, true])
 end
-
 end
 
+
 end