remove unneeded argument checks

Author: scivision

+stdlib/h4exists.m

@@ -7,8 +7,8 @@
 %%% Outputs
 % * exists: boolean
 arguments
-  file (1,1) string {mustBeFile}
-  variable (1,1) string {mustBeNonzeroLengthText}
+  file (1,1) string
+  variable (1,1) string
 end
 
 exists = false;

+stdlib/h4size.m

@@ -8,8 +8,8 @@
 
 function fsize = h4size(file, variable)
 arguments
-  file (1,1) string {mustBeFile}
-  variable (1,1) string {mustBeNonzeroLengthText}
+  file (1,1) string
+  variable (1,1) string
 end
 
 sds = hdfinfo(file).SDS;

+stdlib/h5create_group.m

@@ -9,7 +9,7 @@
 function fid = h5create_group(file, hpath)
 arguments
   file (1,1)
-  hpath (1,1) string {mustBeNonzeroLengthText}
+  hpath (1,1) string
 end
 
 % polymorphic fid/filename
@@ -18,6 +18,7 @@
 else
   % avoid confusing creating file ./~/a.h5
   file = stdlib.expanduser(file);
+  assert(stdlib.len(file) > 0, 'h5create_group:filename_error', "filename must be non-empty")
   dcpl = 'H5P_DEFAULT';
   if isfile(file)
     fid = H5F.open(file, 'H5F_ACC_RDWR', dcpl);

+stdlib/h5save.m

@@ -20,8 +20,8 @@
 
 function h5save(filename, varname, A, opts)
 arguments
-  filename (1,1) string {mustBeNonzeroLengthText}
-  varname (1,1) string {mustBeNonzeroLengthText}
+  filename (1,1) string
+  varname (1,1) string
   A {mustBeNonempty}
   opts.size (1,:) double {mustBeInteger,mustBeNonnegative} = []
   opts.type (1,1) string = ""

+stdlib/h5save_exist.m

@@ -2,6 +2,12 @@
 % normally users use h5save() instead of this function
 
 function h5save_exist(filename, varname, A, sizeA)
+arguments
+  filename (1,1) string
+  varname (1,1) string
+  A {mustBeNonempty}
+  sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
+end
 
 diskshape = stdlib.h5size(filename, varname);
 if length(diskshape) >= 2

+stdlib/h5save_new.m

@@ -2,6 +2,13 @@
 % normally users will use h5save() instead of this function
 
 function h5save_new(filename, varname, A, sizeA, compressLevel)
+arguments
+  filename (1,1) string
+  varname (1,1) string
+  A {mustBeNonempty}
+  sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
+  compressLevel (1,1) double {mustBeInteger,mustBeNonnegative} = 0
+end
 
 if isempty(sizeA)
   sizeA = defaultSize(A);
@@ -11,6 +18,8 @@ function h5save_new(filename, varname, A, sizeA, compressLevel)
   error('h5save:shape_error', "only scalar size may be 0")
 end
 
+assert(stdlib.len(filename) > 0, 'h5save:filename_error', "filename must be non-empty")
+
 if isscalar(sizeA)
   if sizeA == 0
     h5save_scalar(filename, varname, A)

+stdlib/h5size.m

@@ -8,8 +8,8 @@
 
 function fsize = h5size(file, variable)
 arguments
-  file (1,1) string {mustBeFile}
-  variable (1,1) string {mustBeNonzeroLengthText}
+  file (1,1) string
+  variable (1,1) string
 end
 
 dsi = h5info(file, variable).Dataspace;

+stdlib/makedir.m

@@ -4,7 +4,7 @@
 
 function makedir(d)
 arguments
-  d (1,1) string {mustBeNonzeroLengthText}
+  d (1,1) string
 end
 
 %% to avoid confusing making ./~/mydir

+stdlib/ncsave.m

@@ -12,8 +12,8 @@
 
 function ncsave(filename, varname, A, opts)
 arguments
-  filename (1,1) string {mustBeNonzeroLengthText}
-  varname (1,1) string {mustBeNonzeroLengthText}
+  filename (1,1) string
+  varname (1,1) string
   A {mustBeNonempty}
   opts.dims cell = {}
   opts.type (1,1) string = ""

+stdlib/ncsave_new.m

@@ -2,6 +2,16 @@
 % normally users will use ncsave() instead of this function
 
 function ncsave_new(file, varname, A, sizeA, ncdims, compressLevel)
+arguments
+  file (1,1) string
+  varname (1,1) string
+  A {mustBeNonempty}
+  sizeA (1,:) double {mustBeInteger,mustBeNonnegative} = []
+  ncdims cell = {}
+  compressLevel (1,1) double {mustBeInteger,mustBeNonnegative} = 0
+end
+
+assert(stdlib.len(file) > 0, "stdlib:ncsave_new:file", "Empty filename")
 
 if isscalar(A)
   nccreate(file, varname, "Datatype", class(A), "Format", 'netcdf4')