{get,set}_permissions: simpilfy, streamline

scivision · scivision · commit e5c9f1e5c97f · 2025-09-02T10:46:39.000-04:00
diff --git a/+stdlib/+legacy/file_attributes.m b/+stdlib/+legacy/file_attributes.m
diff --git a/+stdlib/+legacy/get_permissions.m b/+stdlib/+legacy/get_permissions.m
diff --git a/+stdlib/+legacy/is_exe.m b/+stdlib/+legacy/is_exe.m
@@ -11,7 +11,7 @@
 
 if ~isfile(file), return, end
 
-a = file_attributes(file);
+a = stdlib.legacy.file_attributes(file);
 y = a.UserExecute || a.GroupExecute || a.OtherExecute;
 
 end
diff --git a/+stdlib/+legacy/is_readable.m b/+stdlib/+legacy/is_readable.m
@@ -4,7 +4,7 @@
 end
 
 if stdlib.exists(file)
-  a = file_attributes(file);
+  a = stdlib.legacy.file_attributes(file);
   y = a.UserRead || a.GroupRead || a.OtherRead;
 else
   y = false;
diff --git a/+stdlib/+legacy/is_writable.m b/+stdlib/+legacy/is_writable.m
@@ -4,7 +4,7 @@
 end
 
 if stdlib.exists(file)
-  a = file_attributes(file);
+  a = stdlib.legacy.file_attributes(file);
   y = a.UserWrite || a.GroupWrite || a.OtherWrite;
 else
   y = false;
diff --git a/+stdlib/+legacy/set_permissions.m b/+stdlib/+legacy/set_permissions.m
@@ -6,9 +6,6 @@
   executable (1,1) {mustBeInteger}
 end
 
-ok = false;
-
-if ~stdlib.exists(file), return, end
 
 mode = '';
 % mode is space-delimited
@@ -32,7 +29,7 @@
   mode = [mode ' -x'];
 end
 
-if isempty(mode)
+if isempty(mode) && stdlib.exists(file)
   ok = true;
   return
 end
diff --git a/+stdlib/+native/get_permissions.m b/+stdlib/+native/get_permissions.m
diff --git a/+stdlib/+native/set_permissions.m b/+stdlib/+native/set_permissions.m
@@ -6,16 +6,7 @@
   executable (1,1) {mustBeInteger}
 end
 
-ok = false;
-
-if ~stdlib.exists(file), return, end
-
-try
-  p = filePermissions(file);
-catch
-  ok = logical.empty;
-  return
-end
+p = filePermissions(file);
 
 k = string.empty;
 v = logical.empty;
diff --git a/+stdlib/Backend.m b/+stdlib/Backend.m
@@ -102,12 +102,6 @@
           pyv = stdlib.python_version();
           if any(pyv(1:2) < [3, 12]), continue, end
       end
-    case 'native'
-
-      switch functionName
-        case {'get_permissions', 'set_permissions'}
-          if stdlib.matlabOlderThan('R2025a'), continue, end
-      end
   end
 
   if ~isempty(which(sprintf('%s.%s.%s', self.namespace, m, functionName)))
diff --git a/+stdlib/get_permissions.m b/+stdlib/get_permissions.m
@@ -4,19 +4,30 @@
 %
 %%% inputs
 % * file: path to check
-% * backend: backend to use
 %%% Outputs
 % * p: permissions string
 % * b: backend used
 
-function [perm, b] = get_permissions(file, backend)
+function [perm, b] = get_permissions(file)
 arguments
   file (1,1) string
-  backend (1,:) string = ["native", "legacy"]
 end
 
-o = stdlib.Backend(mfilename(), backend);
-perm = o.func(file);
-b = o.backend;
+perm = '';
+b = '';
+
+if stdlib.exists(file)
+  try
+    perm = perm2char(filePermissions(file));
+    b = 'native';
+  catch e
+    if e.identifier ~= "MATLAB:UndefinedFunction"
+      rethrow(e)
+    end
+
+    perm = perm2char(stdlib.legacy.file_attributes(file));
+    b = 'legacy';
+  end
+end
 
 end
diff --git a/+stdlib/private/perm2char.m b/+stdlib/private/perm2char.m
diff --git a/+stdlib/set_permissions.m b/+stdlib/set_permissions.m
@@ -5,23 +5,34 @@
 % * readable   (-1 remove read permission,    0 no change, 1 add read permission)
 % * writable   (-1 remove write permission,   0 no change, 1 add write permission)
 % * executable (-1 remove execute permission, 0 no change, 1 add execute permission)
-% * backend: backend to use
 %%% Outputs
 % * ok (1,1) logical
 % * b: backend used
 
-function [ok, b] = set_permissions(file, readable, writable, executable, backend)
+function [ok, b] = set_permissions(file, readable, writable, executable)
 arguments
   file (1,1) string
   readable (1,1) {mustBeInteger}
   writable (1,1) {mustBeInteger}
   executable (1,1) {mustBeInteger}
-  backend (1,:) string = ["native", "legacy"]
 end
 
-o = stdlib.Backend(mfilename(), backend);
 
-ok = o.func(file, readable, writable, executable);
-b = o.backend;
+if ~stdlib.exists(file)
+  ok = false;
+  return
+end
+
+try
+  ok = stdlib.native.set_permissions(file, readable, writable, executable);
+  b = 'native';
+catch e
+  if e.identifier ~= "MATLAB:UndefinedFunction"
+    rethrow(e)
+  end
+
+  ok = stdlib.legacy.set_permissions(file, readable, writable, executable);
+  b = 'legacy';
+end
 
 end
diff --git a/test/TestPermissions.m b/test/TestPermissions.m
@@ -4,16 +4,6 @@
 
 properties (TestParameter)
 Ps = {".", pwd(), "", tempname(), mfilename('fullpath') + ".m"}
-B_get_permissions
-B_set_permissions
-end
-
-
-methods (TestParameterDefinition, Static)
-function [B_get_permissions, B_set_permissions] = setupBackends()
-B_get_permissions = init_backend('get_permissions');
-B_set_permissions = init_backend('set_permissions');
-end
 end
 
 
@@ -26,14 +16,22 @@ function w_dirs(tc)
 
 methods (Test, TestTags={'R2021a'})
 
-function test_get_permissions(tc, Ps, B_get_permissions)
+function test_get_permissions(tc, Ps)
 import matlab.unittest.constraints.StartsWithSubstring
 
-p = stdlib.get_permissions(Ps, B_get_permissions);
+[p, b] = stdlib.get_permissions(Ps);
+
 tc.verifyClass(p, "char")
+
 if ~stdlib.exists(Ps)
   tc.verifyEmpty(p)
 else
+  if isMATLABReleaseOlderThan('R2025a')
+    tc.verifyEqual(b, 'legacy')
+  else
+    tc.verifyEqual(b, 'native')
+  end
+
   tc.verifyThat(p, StartsWithSubstring("r"))
   if isfile(p) && stdlib.suffix(p) == ".m"
     tc.verifyEqual(p(3), '-')
@@ -42,34 +40,41 @@ function test_get_permissions(tc, Ps, B_get_permissions)
 end
 
 
-function test_get_permissions_exe(tc, B_get_permissions)
+function test_get_permissions_exe(tc)
 matlab_exe = fullfile(matlabroot, "bin/matlab");
 if ispc()
   matlab_exe = matlab_exe + ".exe";
 end
 
 tc.assertThat(matlab_exe, matlab.unittest.constraints.IsFile)
-p = stdlib.get_permissions(matlab_exe, B_get_permissions);
+p = stdlib.get_permissions(matlab_exe);
 
 tc.assertNotEmpty(p)
 tc.verifyEqual(p(3), 'x')
 
 end
 
 
-function test_set_permissions_nowrite(tc, B_set_permissions)
+function test_set_permissions_nowrite(tc)
 import matlab.unittest.constraints.StartsWithSubstring
 
 nw = fullfile(pwd(), "no-write");
 
 tc.assertTrue(stdlib.touch(nw))
-r = stdlib.set_permissions(nw, 0, -1, 0, B_set_permissions);
+r = stdlib.set_permissions(nw, 0, -1, 0);
 
 tc.assertTrue(r)
 
-p = stdlib.get_permissions(nw);
-if ~ispc() || B_set_permissions ~= "legacy"
-tc.verifyThat(p, StartsWithSubstring("r-"), "no-write permission failed to set")
+[p, b] = stdlib.get_permissions(nw);
+
+if isMATLABReleaseOlderThan('R2025a')
+  tc.verifyEqual(b, 'legacy')
+else
+  tc.verifyEqual(b, 'native')
+end
+
+if ~ispc() || b ~= "legacy"
+  tc.verifyThat(p, StartsWithSubstring("r-"), "no-write permission failed to set")
 end
 
 end
@@ -89,7 +94,7 @@ function test_set_permissions_noread(tc)
 nr = fullfile(pwd(), "no-read");
 
 tc.assertTrue(stdlib.touch(nr))
-tc.assertTrue(stdlib.set_permissions(nr, -1, 0, 0, 'native'))
+tc.assertTrue(stdlib.set_permissions(nr, -1, 0, 0))
 p = stdlib.get_permissions(nr);
 
 if ~ispc()
