which: simplify types

Author: scivision

+stdlib/which.m

@@ -9,23 +9,20 @@
 
 function exe = which(cmd, fpath, find_all)
 arguments
-  cmd {mustBeTextScalar}
+  cmd (1,1) string
   fpath (1,:) string = string.empty
   find_all (1,1) logical = false
 end
 
-if find_all
-  exe = string.empty;
-else
-  exe = '';
-end
+exe = string.empty;
 
 %% on Windows, append .exe if not suffix is given
 if ispc() && strempty(stdlib.suffix(cmd))
-  cmd = strcat(cmd, '.exe');
+  cmd = cmd + ".exe";
 end
 %% full filename was given
-if isfile(cmd) && stdlib.is_exe(cmd)
+if stdlib.is_exe(cmd)
+  % is_exe implies isfile
   exe = cmd;
   return
 end
@@ -65,5 +62,3 @@
 end
 
 end
-
-%!assert(~isempty(which("octave", [], false)))

test/TestWhich.m

@@ -2,7 +2,7 @@
 
 properties (TestParameter)
 mexe = {matlabroot + "/bin/matlab", ...
-        fullfile(matlabroot, 'bin', 'matlab')}
+        fullfile(matlabroot, 'bin/matlab')}
 end
 
 methods (Test, TestTags="impure")
@@ -33,9 +33,9 @@ function test_which_name(tc)
 
 function test_which_absolute(tc, mexe)
 
-r = mexe;
+r = string(mexe);
 if ispc()
-  r = strcat(r, '.exe');
+  r = r + ".exe";
 end
 
 tc.verifyEqual(stdlib.which(mexe), r)