strcat => append

append is recommended for consistency

Author: scivision

+stdlib/+sys/device.m

@@ -17,7 +17,7 @@
   % Get-CimInstance works, but is 100x slower
   % c0 = 'pwsh -c "(Get-CimInstance -ClassName Win32_Volume -Filter \"DriveLetter = ''';
   % c2 = '''\").SerialNumber"';
-  % cmd = strcat(c0, rn, c2);
+  % cmd = append(c0, rn, c2);
 
   cmd = sprintf('vol "%s"', rn);
 elseif ismac()

+stdlib/filename.m

@@ -7,7 +7,7 @@
 
 function f = filename(p, backend)
 arguments
-  p (1,1) string
+  p
   backend = 'fileparts'
 end
 

+stdlib/root.m

@@ -3,6 +3,6 @@
 
 function r = root(p)
 
-r = strcat(stdlib.root_name(p), stdlib.root_dir(p));
+r = append(stdlib.root_name(p), stdlib.root_dir(p));
 
 end

example/+javafun/parent.m

@@ -9,7 +9,7 @@
   if ispc()
     rn = stdlib.root_name(pth);
     if strlength(pth) && strlength(rn) && startsWith(pth, rn)
-      par = strcat(rn, filesep);
+      par = append(rn, filesep);
     end
   end
 else

private/get_compiler.m

@@ -42,7 +42,7 @@
     end
   else
     if startsWith(co.ShortName, "INTEL" | "MSVC")
-      shell = join([strcat('"',string(co.Details.CommandLineShell),'"'), ...
+      shell = join([append('"',string(co.Details.CommandLineShell),'"'), ...
                   co.Details.CommandLineShellArg], " ");
     elseif startsWith(co.ShortName, "mingw64")
       shell = "set PATH=" + fileparts(comp) + pathsep + "%PATH%";

private/publish_gen_index_html.m

@@ -37,7 +37,7 @@
 copyfile(styleFile, outdir)
 
 [~, n, s] = fileparts(styleFile);
-styleName = strcat(n, s);
+styleName = append(n, s);
 [head, body] = index_html(styleName, pkg_name, tagline, git_txt, project_url);
 
 fid = fopen(readme, 'w');
@@ -71,7 +71,7 @@ function publish_pkg(fid, pkg, pkg_name)
 %   pkg_name = pkg_name + "." + subname(2:end);
 %   relpath = subname(2:end) + "/";
 %   outdir = fullfile(outdir, relpath);
-%   fprintf(fid, strcat('<h3>', pkg_name, '</h3>', newline));
+%   fprintf(fid, append('<h3>', pkg_name, '</h3>', newline));
 % else
 relpath = "";
 % end

test/TestCanonical.m

@@ -7,7 +7,7 @@
 {"", ""}, ...
 {"not-exist", "not-exist"}, ...
 {"a/../b", "a/../b"}, ...
-{strcat(mfilename("fullpath"), '.m/..'), string(fileparts(mfilename("fullpath")))}, ...
+{append(mfilename("fullpath"), '.m/..'), string(fileparts(mfilename("fullpath")))}, ...
 {"not-exist/a/..", "not-exist/a/.."}, ...
 {"./not-exist", "not-exist"}
 };

test/TestSymlink.m

@@ -25,7 +25,7 @@ function setup_symlink(tc)
 
 tc.link = fullfile(pwd(), 'my.lnk');
 
-tc.target = strcat(mfilename("fullpath"), '.m');
+tc.target = append(mfilename("fullpath"), '.m');
 
 tc.assumeTrue(stdlib.create_symlink(tc.target, tc.link), ...
     "failed to create test link " + tc.link)