is_readable improve test coverage

Author: scivision

+stdlib/+native/file_attributes.m

@@ -1,7 +1,4 @@
 function a = file_attributes(p)
-arguments
-  p {mustBeTextScalar}
-end
 
 assert(~stdlib.strempty(p), 'Path must not be empty.')
 

+stdlib/+native/is_exe.m

@@ -1,31 +1,21 @@
-function y = is_exe(p)
+function y = is_exe(file)
 
-y = isfile(p);
+y = isfile(file);
 
 if ispc()
-  y = y && stdlib.native.has_windows_executable_suffix(p);
+  y = y && stdlib.native.has_windows_executable_suffix(file);
 end
 
 if ~y, return, end
 
-
-if ~isMATLABReleaseOlderThan('R2025a')
-
-  if isunix
-    props = ["UserExecute", "GroupExecute", "OtherExecute"];
-  else
-    props = "Readable";
-  end
-
-  t = getPermissions(filePermissions(p), props);
-
-  y = any(t{1, :});
-
+if isunix
+  props = ["UserExecute", "GroupExecute", "OtherExecute"];
 else
+  props = "Readable";
+end
 
-  a = stdlib.native.file_attributes(p);
-  y = a.UserExecute || a.GroupExecute || a.OtherExecute;
+t = getPermissions(filePermissions(file), props);
 
-end
+y = any(t{1, :});
 
 end

+stdlib/+native/is_exe_legacy.m

@@ -0,0 +1,14 @@
+function y = is_exe_legacy(file)
+
+y = isfile(file);
+
+if ispc()
+  y = y && stdlib.native.has_windows_executable_suffix(file);
+end
+
+if ~y, return, end
+
+a = stdlib.native.file_attributes(file);
+y = a.UserExecute || a.GroupExecute || a.OtherExecute;
+
+end

+stdlib/+native/is_readable.m

@@ -1,24 +1,15 @@
-function y = is_readable(p)
+function y = is_readable(file)
 
 y = false;
 
-if ~stdlib.exists(p), return, end
-
-if ~isMATLABReleaseOlderThan('R2025a')
-
-  props = "Readable";
-  if isunix
-    props = [props, "GroupRead", "OtherRead"];
-  end
-
-  t = getPermissions(filePermissions(p), props);
-  y = any(t{1, :});
-
-else
-
-  a = stdlib.native.file_attributes(p);
-  y = a.UserRead || a.GroupRead || a.OtherRead;
+if ~stdlib.exists(file), return, end
 
+props = "Readable";
+if isunix
+  props = [props, "GroupRead", "OtherRead"];
 end
 
+t = getPermissions(filePermissions(file), props);
+y = any(t{1, :});
+
 end

+stdlib/+native/is_readable_legacy.m

@@ -0,0 +1,10 @@
+function y = is_readable_legacy(file)
+
+if stdlib.exists(file)
+  a = stdlib.native.file_attributes(file);
+  y = a.UserRead || a.GroupRead || a.OtherRead;
+else
+  y = false;
+end
+
+end

+stdlib/+native/is_writable.m

@@ -4,19 +4,12 @@
 
 if ~stdlib.exists(p), return, end
 
-if ~isMATLABReleaseOlderThan('R2025a')
-
-  props = "Writable";
-  if isunix
-    props = [props, "GroupWrite", "OtherWrite"];
-  end
+props = "Writable";
+if isunix
+  props = [props, "GroupWrite", "OtherWrite"];
+end
 
-  t = getPermissions(filePermissions(p), props);
-  y = any(t{1, :});
+t = getPermissions(filePermissions(p), props);
+y = any(t{1, :});
 
-else
-  a = stdlib.native.file_attributes(p);
-  y = a.UserWrite || a.GroupWrite || a.OtherWrite;
 end
-
-end

+stdlib/+native/is_writable_legacy.m

@@ -0,0 +1,10 @@
+function y = is_writable_legacy(file)
+
+if stdlib.exists(file)
+  a = stdlib.native.file_attributes(file);
+  y = a.UserWrite || a.GroupWrite || a.OtherWrite;
+else
+  y = false;
+end
+
+end

+stdlib/is_readable.m

@@ -1,20 +1,21 @@
 %% IS_READABLE is file readable
 %
 %%% Inputs
-% p: string array of file paths
+% file: single path string
 %% Outputs
-% ok: logical array of the same size as p, true if file is readable
+% ok: true if file is readable
 
-function y = is_readable(p)
+function y = is_readable(file)
 arguments
-  p {mustBeTextScalar}
+  file {mustBeTextScalar}
 end
 
 if stdlib.has_java()
-  y = stdlib.java.is_readable(p);
+  y = stdlib.java.is_readable(file);
+elseif isMATLABReleaseOlderThan('R2025a')
+  y = stdlib.native.is_readable_legacy(file);
 else
-  y = stdlib.native.is_readable(p);
+  y = stdlib.native.is_readable(file);
 end
 
-
 end

+stdlib/is_writable.m

@@ -1,19 +1,21 @@
 %% IS_WRITABLE is path writable
 %
 %%% Inputs
-% p: string array of file paths
+% file: path to file or folder
 %% Outputs
-% ok: logical array of the same size as p, true if file is writable
+% ok: true if file is writable
 
-function y = is_writable(p)
+function y = is_writable(file)
 arguments
-  p {mustBeTextScalar}
+  file {mustBeTextScalar}
 end
 
 if stdlib.has_java()
-  y = stdlib.java.is_writable(p);
+  y = stdlib.java.is_writable(file);
+elseif isMATLABReleaseOlderThan('R2025a')
+  y = stdlib.native.is_writable_legacy(file);
 else
-  y = stdlib.native.is_writable(p);
+  y = stdlib.native.is_writable(file);
 end
 
 end

+stdlib/proximate_to.m

@@ -1,16 +1,12 @@
 %% PROXIMATE_TO relative path to base
 %
 %%% Inputs
-% * base {mustBeTextScalar}
-% * other {mustBeTextScalar}
+% * base: directory to which the other path should be relative
+% * other: path to be made relative
 %%% Outputs
-% * rel {mustBeTextScalar}
+% * rel: relative path from base to other
 
 function rel = proximate_to(base, other)
-arguments
-  base {mustBeTextScalar}
-  other {mustBeTextScalar}
-end
 
 rel = stdlib.relative_to(base, other);
 if stdlib.strempty(rel)