set_modtime, simplify, add tests

Author: scivision

+stdlib/+java/set_modtime.m

@@ -0,0 +1,9 @@
+function ok = set_modtime(p, utc)
+
+if isdatetime(utc)
+  utc = convertTo(datetime(utc, 'TimeZone', "UTC"), "posixtime");
+end
+
+ok = javaObject("java.io.File", p).setLastModified(int64(utc) * 1000);
+
+end

+stdlib/+python/set_modtime.m

@@ -1,5 +1,12 @@
 function ok = set_modtime(p, utc)
 
+ok = false;
+if ~isfile(p), return, end
+
+if isdatetime(utc)
+  utc = convertTo(datetime(utc, 'TimeZone', "UTC"), "posixtime");
+end
+
 try
   s = py.os.stat(p);
   py.os.utime(p, py.tuple([s.st_atime, utc]));

+stdlib/+sys/set_modtime.m

@@ -1,5 +1,9 @@
 function ok = set_modtime(p, t)
 
+ok = false;
+
+if ~isfile(p), return, end
+
 if ispc()
   cmd = sprintf('pwsh -Command "(Get-Item ''%s'').LastWriteTime = ''%s''"', p, string(t, "yyyy-MM-dd HH:mm:ss"));
 elseif ismac()

+stdlib/set_modtime.m

@@ -6,32 +6,15 @@
   t (1,1) datetime
 end
 
-try
-  utc = convertTo(datetime(t, 'TimeZone', "UTC"), "posixtime");
-catch e
-  if strcmp(e.identifier, "Octave:undefined-function")
-    utc = t;
-  else
-    rethrow(e);
-  end
-end
+utc = convertTo(datetime(t, 'TimeZone', "UTC"), "posixtime");
 
 % Java or Python assume POSIX epoch time (seconds since Jan 1, 1970)
 if stdlib.has_java()
-  ok = javaObject("java.io.File", p).setLastModified(int64(utc) * 1000);
+  ok = stdlib.java.set_modtime(p, utc);
 elseif stdlib.has_python()
   ok = stdlib.python.set_modtime(p, utc);
-end
-
-if ~ok
+else
   ok = stdlib.sys.set_modtime(p, t);
 end
 
 end
-
-%!test
-%! p = tempname();
-%! t = now();
-%! assert(touch(p, t))
-%! assert(set_modtime(p, t))
-%! delete(p)

test/TestExists.m

@@ -1,5 +1,12 @@
 classdef TestExists < matlab.unittest.TestCase
 
+methods(TestClassSetup)
+function pkg_path(tc)
+p = matlab.unittest.fixtures.PathFixture(fileparts(fileparts(mfilename('fullpath'))));
+tc.applyFixture(p)
+end
+end
+
 properties(TestParameter)
 Ps = {
 {pwd(), true}, ...

test/TestTime.m

@@ -4,7 +4,20 @@
 td
 end
 
+properties (TestParameter)
+set_modtime_fun = {@stdlib.set_modtime, @stdlib.sys.set_modtime, @stdlib.java.set_modtime, @stdlib.python.set_modtime}
+end
+
 methods(TestClassSetup)
+function pkg_path(tc)
+p = matlab.unittest.fixtures.PathFixture(fileparts(fileparts(mfilename('fullpath'))));
+tc.applyFixture(p)
+end
+end
+
+% per-method to avoid race conditions creating and modifying files
+methods(TestMethodSetup)
+
 function set_temp_wd(tc)
 if isMATLABReleaseOlderThan('R2022a')
   tc.td = tempname();
@@ -15,7 +28,7 @@ function set_temp_wd(tc)
 end
 end
 
-methods(TestClassTeardown)
+methods(TestMethodTeardown)
 function remove_temp_wd(tc)
 if isMATLABReleaseOlderThan('R2022a')
   [s, m, i] = rmdir(tc.td, 's');
@@ -31,33 +44,18 @@ function test_get_modtime(tc)
 end
 
 
-function test_touch_modtime(tc)
-fn = tc.td + "/modtime.txt";
-
-tc.verifyTrue(stdlib.touch(fn, datetime("yesterday")))
-t0 = stdlib.get_modtime(fn);
-
-tc.verifyTrue(stdlib.set_modtime(fn, datetime("now")))
-t1 = stdlib.get_modtime(fn);
-
-tc.verifyGreaterThanOrEqual(t1, t0)
-end
-
-end
-
+function test_touch_modtime(tc, set_modtime_fun)
+is_capable(tc, set_modtime_fun)
 
-methods(Test, TestTags="shell")
-
-function test_set_modtime_sys(tc)
 fn = tc.td + "/modtime.txt";
 
 tc.verifyTrue(stdlib.touch(fn, datetime("yesterday")))
 t0 = stdlib.get_modtime(fn);
 
-tc.verifyTrue(stdlib.set_modtime(fn, datetime("now")))
+tc.verifyTrue(set_modtime_fun(fn, datetime("now")))
 t1 = stdlib.get_modtime(fn);
 
-tc.verifyGreaterThanOrEqual(t1, t0);
+tc.verifyGreaterThanOrEqual(t1, t0)
 end
 
 end