allow ell=None default

This is like Pymap3d 2.8.0 and is better UX

Author: scivision

src/pymap3d/aer.py

@@ -21,8 +21,6 @@ def ecef2eci(x, y, z, time: datetime, force_non_astropy: bool = False) -> tuple:
 
 __all__ = ["aer2ecef", "ecef2aer", "geodetic2aer", "aer2geodetic", "eci2aer", "aer2eci"]
 
-ELL = Ellipsoid.from_name("wgs84")
-
 
 def ecef2aer(
     x,
@@ -31,7 +29,7 @@ def ecef2aer(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -81,7 +79,7 @@ def geodetic2aer(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -129,7 +127,7 @@ def aer2geodetic(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -219,7 +217,7 @@ def aer2eci(
     lon0,
     h0,
     t: datetime,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     *,
     deg: bool = True,
 ) -> tuple:
@@ -272,7 +270,7 @@ def aer2ecef(
     lat0,
     lon0,
     alt0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """

src/pymap3d/ecef.py

@@ -28,14 +28,12 @@
     "enu2ecef",
 ]
 
-ELL = Ellipsoid.from_name("wgs84")
-
 
 def geodetic2ecef(
     lat,
     lon,
     alt,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -73,6 +71,9 @@ def geodetic2ecef(
         lat = radians(lat)
         lon = radians(lon)
 
+    if ell is None:
+        ell = Ellipsoid.from_name("wgs84")
+
     # radius of curvature of the prime vertical section
     N = ell.semimajor_axis**2 / hypot(ell.semimajor_axis * cos(lat), ell.semiminor_axis * sin(lat))
     # Compute cartesian (geocentric) coordinates given (curvilinear) geodetic coordinates.
@@ -87,7 +88,7 @@ def ecef2geodetic(
     x,
     y,
     z,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -127,6 +128,9 @@ def ecef2geodetic(
     except NameError:
         pass
 
+    if ell is None:
+        ell = Ellipsoid.from_name("wgs84")
+
     r = sqrt(x**2 + y**2 + z**2)
 
     E = sqrt(ell.semimajor_axis**2 - ell.semiminor_axis**2)
@@ -272,7 +276,7 @@ def ecef2enu(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -398,7 +402,7 @@ def uvw2enu(u, v, w, lat0, lon0, deg: bool = True) -> tuple:
     return East, North, Up
 
 
-def eci2geodetic(x, y, z, t: datetime, ell: Ellipsoid = ELL, *, deg: bool = True) -> tuple:
+def eci2geodetic(x, y, z, t: datetime, ell: Ellipsoid | None = None, *, deg: bool = True) -> tuple:
     """
     convert Earth Centered Internal ECI to geodetic coordinates
 
@@ -436,7 +440,9 @@ def eci2geodetic(x, y, z, t: datetime, ell: Ellipsoid = ELL, *, deg: bool = True
     return ecef2geodetic(xecef, yecef, zecef, ell, deg)
 
 
-def geodetic2eci(lat, lon, alt, t: datetime, ell: Ellipsoid = ELL, *, deg: bool = True) -> tuple:
+def geodetic2eci(
+    lat, lon, alt, t: datetime, ell: Ellipsoid | None = None, *, deg: bool = True
+) -> tuple:
     """
     convert geodetic coordinates to Earth Centered Internal ECI
 
@@ -481,7 +487,7 @@ def enu2ecef(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """

src/pymap3d/enu.py

@@ -15,8 +15,6 @@
 
 __all__ = ["enu2aer", "aer2enu", "enu2geodetic", "geodetic2enu", "enu2ecefv"]
 
-ELL = Ellipsoid.from_name("wgs84")
-
 
 def enu2aer(e, n, u, deg: bool = True) -> tuple:
     """
@@ -118,7 +116,7 @@ def enu2geodetic(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """
@@ -166,7 +164,7 @@ def geodetic2enu(
     lat0,
     lon0,
     h0,
-    ell: Ellipsoid = ELL,
+    ell: Ellipsoid | None = None,
     deg: bool = True,
 ) -> tuple:
     """