Ellipsoid.from_name(unknown) raises KeyError instead of warning

Author: scivision

pyproject.toml

@@ -55,7 +55,7 @@ filterwarnings = [
 
 [tool.coverage.run]
 branch = true
-source = "src/"
+source = ["src/"]
 
 [tool.coverage.report]
 # Regexes for lines to exclude from consideration

src/pymap3d/ellipsoid.py

@@ -4,7 +4,6 @@
 from math import sqrt
 from dataclasses import dataclass, field
 import sys
-import warnings
 from typing import Dict  # for Python < 3.9
 
 if sys.version_info >= (3, 8):
@@ -155,10 +154,6 @@ def __init__(
     def from_name(cls, name: str) -> Ellipsoid | None:
         """Create an Ellipsoid from a name."""
 
-        if name not in cls.models:
-            warnings.warn(f"{name} model not implemented", stacklevel=2)
-            return None
-
         return cls(
             cls.models[name]["a"], cls.models[name]["b"], name=cls.models[name]["name"], model=name
         )

src/pymap3d/tests/test_ellipsoid.py

@@ -48,6 +48,11 @@ def test_reference(model, f):
     assert pm.Ellipsoid.from_name(model).flattening == approx(f)
 
 
+def test_bad_name():
+    with pytest.raises(KeyError):
+        pm.Ellipsoid.from_name("badname")
+
+
 def test_ellipsoid():
 
     assert pm.ecef2geodetic(*xyz0, ell=pm.Ellipsoid.from_name("maupertuis")) == approx(