Skip to content

Commit 7f87df4

Browse files
committed
Fix release permissions, cleanup
Whoops, forgot to add back the pull-request: read permissions while trying to keep a clean history and diff. And I accidentally left a comment that I didn't mean to. Also decided to change the "Push version" action to "Push new version".
1 parent 06107c7 commit 7f87df4

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ jobs:
1313
permissions:
1414
# required for softprops/action-gh-release
1515
contents: write
16+
# required for mikepenz/release-changelog-builder-action
17+
pull-requests: read
1618

1719
steps:
1820
- name: Checkout code
@@ -24,7 +26,6 @@ jobs:
2426
- uses: JS-DevTools/npm-publish@v3
2527
with:
2628
token: ${{ secrets.NPM_TOKEN }}
27-
# see https://github.com/softprops/action-gh-release/pull/372#issuecomment-1642643937
2829
- name: Create release notes
2930
id: build_changelog
3031
uses: mikepenz/release-changelog-builder-action@v5

.github/workflows/version.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Push version
1+
name: Push new version
22

33
on:
44
workflow_dispatch:
@@ -17,7 +17,7 @@ on:
1717
- preminor
1818
- premajor
1919
preId:
20-
description: 'Prerelease identifier (required with pre-*)'
20+
description: 'Prerelease identifier (required with pre*)'
2121
required: false
2222
type: string
2323

@@ -44,7 +44,7 @@ jobs:
4444
uses: actions/checkout@v4
4545
with:
4646
# see https://github.com/orgs/community/discussions/25617#discussioncomment-3248494
47-
token: ${{ secrets.RELEASE_TOKEN }}
47+
token: ${{ secrets.VERSION_TOKEN }}
4848
# requires contents: write permission for this repo
4949
# used by `git push` at the end
5050
- uses: actions/setup-node@v4

0 commit comments

Comments
 (0)