Skip to content

Commit 5927f7b

Browse files
authored
feat: declare feathers and vue as peerDependencies (#58)
additionally use import type for feathers and update sift BREAKING CHANGE: declare feathers and vue as peerDependencies
1 parent eeb221f commit 5927f7b

File tree

7 files changed

+45
-40
lines changed

7 files changed

+45
-40
lines changed

package.json

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,11 @@
2929
"release": "semantic-release"
3030
},
3131
"dependencies": {
32-
"@feathersjs/adapter-commons": "5.0.0-pre.10",
33-
"@feathersjs/feathers": "5.0.0-pre.10",
34-
"sift": "13.5.4",
35-
"vue": "3.0.11"
32+
"sift": "^15.0.0"
3633
},
3734
"devDependencies": {
35+
"@feathersjs/adapter-commons": "5.0.0-pre.14",
36+
"@feathersjs/feathers": "5.0.0-pre.14",
3837
"@geprog/eslint-config": "0.0.1",
3938
"@geprog/semantic-release-config": "1.0.0",
4039
"@jest/types": "26.6.2",
@@ -51,6 +50,12 @@
5150
"semantic-release": "18.0.0",
5251
"ts-jest": "26.5.6",
5352
"ts-node": "10.0.0",
54-
"typescript": "4.2.4"
53+
"typescript": "4.2.4",
54+
"vue": "3.0.11"
55+
},
56+
"peerDependencies": {
57+
"@feathersjs/adapter-commons": "^5.0.0-pre.3",
58+
"@feathersjs/feathers": "^5.0.0-pre.3",
59+
"vue": "^3.0.11"
5560
}
5661
}

src/useFind.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Application, FeathersService, Params, ServiceMethods } from '@feathersjs/feathers';
1+
import type { Application, FeathersService, Params, ServiceMethods } from '@feathersjs/feathers';
22
import sift from 'sift';
33
import { onBeforeUnmount, onMounted, Ref, ref, watch } from 'vue';
44

src/useGet.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Application, FeathersService, Id, ServiceMethods } from '@feathersjs/feathers';
1+
import type { Application, FeathersService, Id, ServiceMethods } from '@feathersjs/feathers';
22
import { onBeforeUnmount, onMounted, Ref, ref, watch } from 'vue';
33

44
import { getId, ServiceModel, ServiceTypes } from './utils';

src/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import { AdapterService } from '@feathersjs/adapter-commons';
2-
import { Application, Id, ServiceMethods } from '@feathersjs/feathers';
1+
import type { AdapterService } from '@feathersjs/adapter-commons';
2+
import type { Application, Id, ServiceMethods } from '@feathersjs/feathers';
33

44
export type PotentialIds = {
55
id?: Id;

test/useFind.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Application, Params } from '@feathersjs/feathers';
1+
import type { Application, Params } from '@feathersjs/feathers';
22
import { nextTick, ref } from 'vue';
33

44
import useFindOriginal, { UseFind } from '~/useFind';

test/useGet.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Application } from '@feathersjs/feathers';
1+
import type { Application } from '@feathersjs/feathers';
22
import { nextTick, ref } from 'vue';
33

44
import useGetOriginal, { UseGet } from '~/useGet';

yarn.lock

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -325,31 +325,31 @@
325325
minimatch "^3.0.4"
326326
strip-json-comments "^3.1.1"
327327

328-
"@feathersjs/[email protected].10":
329-
version "5.0.0-pre.10"
330-
resolved "https://registry.yarnpkg.com/@feathersjs/adapter-commons/-/adapter-commons-5.0.0-pre.10.tgz#1b37391b77e7f55d00b1741084e7a4d2f64669b3"
331-
integrity sha512-x/U7AgtRgHVIp+occYZ+Zyr+c723z/uZ3ql3wXYvwnJr8npQiqgHzigY3Q1+dVknGB01snMt5pP5whIc+qz7Cg==
332-
dependencies:
333-
"@feathersjs/commons" "^5.0.0-pre.10"
334-
"@feathersjs/errors" "^5.0.0-pre.10"
335-
"@feathersjs/feathers" "^5.0.0-pre.10"
336-
337-
"@feathersjs/commons@^5.0.0-pre.10":
338-
version "5.0.0-pre.10"
339-
resolved "https://registry.yarnpkg.com/@feathersjs/commons/-/commons-5.0.0-pre.10.tgz#e7abf6ee26d5da522549f5241dfac492b5a9372e"
340-
integrity sha512-HOZEoLFRwiogbvY53QN94XJdSPpGKsL7VCtyKWKJAvnf5cjCUQ8OpemZnjKz1PPvpCMhEgl1LMTYLRH3ReYsrg==
341-
342-
"@feathersjs/errors@^5.0.0-pre.10":
343-
version "5.0.0-pre.10"
344-
resolved "https://registry.yarnpkg.com/@feathersjs/errors/-/errors-5.0.0-pre.10.tgz#7a2c6a623517818bd6c0d32ce1ac45c586a7cbea"
345-
integrity sha512-xCwWNzll5ovRBmqPPOmgCiEQ0bqENBXdCuXk5AyXdZUJiiOK+VQSPEqvd0QLbibSzLVgR5xH/QyrA3OQZEyUSQ==
346-
347-
"@feathersjs/[email protected].10", "@feathersjs/feathers@^5.0.0-pre.10":
348-
version "5.0.0-pre.10"
349-
resolved "https://registry.yarnpkg.com/@feathersjs/feathers/-/feathers-5.0.0-pre.10.tgz#dcca5f87d85bdcdae163b73ec4fa5656999230b6"
350-
integrity sha512-K0BQgxXzLS9h5oRP5gNY14ZLOnaVLHJ5AhaZCgrSrovFWms9urUyleW9+3l1A0GBI8tQ3o0cTlwTj0+vr10I1Q==
351-
dependencies:
352-
"@feathersjs/commons" "^5.0.0-pre.10"
328+
"@feathersjs/[email protected].14":
329+
version "5.0.0-pre.14"
330+
resolved "https://registry.yarnpkg.com/@feathersjs/adapter-commons/-/adapter-commons-5.0.0-pre.14.tgz#d29602cd48b6ce2e8ed72476f637214237d818a4"
331+
integrity sha512-XGCsyWjK5PmvQ1VfOvZzgtzcbGcr4Op/JXxqhV3EVPpil2zMgqG+T1Dbx8LFWiODCJz+Iu4uZy3Lo6zm6U/nMQ==
332+
dependencies:
333+
"@feathersjs/commons" "^5.0.0-pre.14"
334+
"@feathersjs/errors" "^5.0.0-pre.14"
335+
"@feathersjs/feathers" "^5.0.0-pre.14"
336+
337+
"@feathersjs/commons@^5.0.0-pre.14":
338+
version "5.0.0-pre.14"
339+
resolved "https://registry.yarnpkg.com/@feathersjs/commons/-/commons-5.0.0-pre.14.tgz#b22a108139532944d18532493efdf7f1b846f849"
340+
integrity sha512-WR8eWaNkE5kyo1EUpvJHeIZo+HcSAjoZDnH+EsHme2Z1hX2an9QE7z2LoHcelO0wU5yn2ysgDGYosEVTEZb3sQ==
341+
342+
"@feathersjs/errors@^5.0.0-pre.14":
343+
version "5.0.0-pre.14"
344+
resolved "https://registry.yarnpkg.com/@feathersjs/errors/-/errors-5.0.0-pre.14.tgz#69d97eb68337ccd75a6cf6d20ba387ad8c14c9bd"
345+
integrity sha512-Z6Ktdn+AZHxc569UPsq55Rx5gmOQFLx0uM7z+7Cp7R+1GpLYCcYl+EvKqPWocHU+Mm+mKGUqOTyJw5KoJheeBg==
346+
347+
"@feathersjs/[email protected].14", "@feathersjs/feathers@^5.0.0-pre.14":
348+
version "5.0.0-pre.14"
349+
resolved "https://registry.yarnpkg.com/@feathersjs/feathers/-/feathers-5.0.0-pre.14.tgz#390c2804e86345b067f429051872ab783059ad34"
350+
integrity sha512-JlOaf3Pht4/C+ydgrWgkKCAKK/ZZUJqsP/DMSKzR6OIdkPeVoreufT+LbJTdLRyB/TtcwULSHdxczQhF6SvOHg==
351+
dependencies:
352+
"@feathersjs/commons" "^5.0.0-pre.14"
353353
"@feathersjs/hooks" "^0.6.5"
354354
events "^3.3.0"
355355

@@ -6546,10 +6546,10 @@ side-channel@^1.0.4:
65466546
get-intrinsic "^1.0.2"
65476547
object-inspect "^1.9.0"
65486548

6549-
sift@13.5.4:
6550-
version "13.5.4"
6551-
resolved "https://registry.yarnpkg.com/sift/-/sift-13.5.4.tgz#7b2a67f724c8b2fca121fcfdef4011bb1ea4e3ef"
6552-
integrity sha512-J/d0r/MJlD7vG3j6FZI3/KnN+MxEmPUx2nyKNawysbl2ktisEnAWI5j0AgHM19p4xFA2vDXve4i8TQYYfi9O6Q==
6549+
sift@^15.0.0:
6550+
version "15.0.0"
6551+
resolved "https://registry.yarnpkg.com/sift/-/sift-15.0.0.tgz#e3a809a40ca792bf17ad64700b97a5ed7be5dacd"
6552+
integrity sha512-FrKLXaUad4IYEpIzs9BAaXXNwcRnzg2vPfPTDgPRrKncMhgx9wftFzJrIRh9SCxxz0zHgvSKULQRRGA9JQWcZQ==
65536553

65546554
signal-exit@^3.0.0, signal-exit@^3.0.2, signal-exit@^3.0.3:
65556555
version "3.0.5"

0 commit comments

Comments
 (0)