Skip to content

Commit aa1afdf

Browse files
committed
More diagnostics and updated version number processing.
If the branch created had a '/' in it, we would not actually build properly - the `sed` would crash.
1 parent d303d70 commit aa1afdf

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
- name: Prerequisites for CentOS 8
5454
if: matrix.os == 'centos:8'
5555
run: |
56-
echo "Fixing up centos 8 being EOL'd"
56+
echo "Fixing up centos 8 being EOLd"
5757
for i in /etc/yum.repos.d/* ; do sed -i 's/mirrorlist/#mirrorlist/' $i ; done
5858
for i in /etc/yum.repos.d/* ; do sed -i 's!#baseurl=http://mirror.!baseurl=http://vault.!' $i ; done
5959
@@ -92,18 +92,18 @@ jobs:
9292
crosscompile/setup-riscos-tests.sh
9393
9494
# Zip up the source to send to robuild
95-
echo Zip up our sources
95+
echo +++ Zip up our sources
9696
zip -q9r /tmp/source-archive.zip riscos-bits ROTest,feb .robuild.yaml
9797
9898
# Fetch the build client
99-
echo Fetch the build client
99+
echo +++ Fetch the build client
100100
curl -s -L -o riscos-build-online https://github.com/gerph/robuild-client/releases/download/v0.05/riscos-build-online && chmod +x riscos-build-online
101101
102102
# Send the archive file to build service (with explicit timeout)
103-
echo Run the build
103+
echo +++ Run the build
104104
timeout 660 ./riscos-build-online -i /tmp/source-archive.zip -a off -t 600 -o /tmp/built
105105
106-
# If it didn't report an error, the test was successful.
106+
# If it did not report an error, the test was successful.
107107
108108
export-posix:
109109
runs-on: ubuntu-24.04

crosscompile/build-riscos-tool.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ if [[ -f "${rootdir}/process.pl" ]] ; then
3131
else
3232
tool_file="${rootdir}/riscos-prminxml"
3333
fi
34-
sed "s/VERSION/$version/" "${rootdir}/riscos-prminxml" > "${install_dir}/riscos-prminxml/riscos-prminxml.pl,102"
34+
sed "s!VERSION!$version!" "${rootdir}/riscos-prminxml" > "${install_dir}/riscos-prminxml/riscos-prminxml.pl,102"
3535
cp -R "${rootdir}/catalog" "${install_dir}/riscos-prminxml/catalog"
3636
cp -R "${rootdir}/Resources/!Run,feb" "${install_dir}/riscos-prminxml/!Run,feb"
3737
cp -R "${rootdir}/Resources/perl,ff8" "${install_dir}/riscos-prminxml/perl,ff8"

crosscompile/setup-riscos-prereqs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ fi
5151
source "${scriptdir}/setup-venv.sh"
5252

5353
# Extract them
54-
source "${venvdir}/bin/activate"
54+
echo +++ Extracting xml/xslt tools for RISC OS
5555
riscos-unzip --chdir "${install_dir}" "${download_xml2}"
5656
mv "${install_dir}/README.md" "${install_dir}/README-libxml2.md"
5757
mv "${install_dir}/COPYING" "${install_dir}/COPYING-libxml2"

crosscompile/setup-riscos-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@ if [[ -f "${perlbin}" ]] ; then
2020
fi
2121

2222
# Obtain XSLTProc and LibXML2
23+
echo +++ Setting up prerequisites
2324
"${scriptdir}/setup-riscos-prereqs.sh" "${downloaddir}"
2425

2526
# We don't need the libraries
2627
rm -rf "${downloaddir}/Lib"
2728

2829
# Put our tool in the top level
2930
eval "$(${scriptdir}/ci-vars)"
31+
echo +++ Building RISC OS Tool
3032
"${scriptdir}/build-riscos-tool.sh" "${downloaddir}"
3133

3234
# Put the examples in there

0 commit comments

Comments
 (0)