[Cleanup] Remove rolled out feature flags (#856)

jordanhunt22 · web-flow · commit fe4ab0dd8ffb · 2025-09-10T01:10:28.000Z
Cleaned up a bunch of feature flags that have been rolled out in prod
for months.
diff --git a/app/components/chat/Chat.tsx b/app/components/chat/Chat.tsx
@@ -138,13 +138,10 @@ export const Chat = memo(
     };
     const {
       recordRawPromptsForDebugging,
-      smallFiles,
       maxCollapsedMessagesSize,
       maxRelevantFilesSize,
       minCollapsedMessagesSize,
       useGeminiAuto,
-      enablePreciseEdits,
-      enableEnvironmentVariables,
       enableResend,
       useAnthropicFraction,
     } = useLaunchDarkly();
@@ -368,9 +365,6 @@ export const Chat = memo(
           collapsedMessages,
           promptCharacterCounts: characterCounts,
           featureFlags: {
-            enablePreciseEdits,
-            smallFiles,
-            enableEnvironmentVariables,
             enableResend,
           },
         };
diff --git a/app/lib/.server/chat.ts b/app/lib/.server/chat.ts
@@ -65,14 +65,10 @@ export async function chatAction({ request }: ActionFunctionArgs) {
       | { preference: 'always' | 'quotaExhausted'; value?: string; openai?: string; xai?: string; google?: string }
       | undefined;
     shouldDisableTools: boolean;
-    smallFiles: boolean;
     recordRawPromptsForDebugging?: boolean;
     collapsedMessages: boolean;
     promptCharacterCounts?: PromptCharacterCounts;
     featureFlags: {
-      enablePreciseEdits: boolean;
-      smallFiles: boolean;
-      enableEnvironmentVariables?: boolean;
       enableResend?: boolean;
     };
   };
@@ -184,9 +180,6 @@ export async function chatAction({ request }: ActionFunctionArgs) {
       collapsedMessages: body.collapsedMessages,
       promptCharacterCounts: body.promptCharacterCounts,
       featureFlags: {
-        enablePreciseEdits: body.featureFlags.enablePreciseEdits,
-        smallFiles: body.featureFlags.smallFiles,
-        enableEnvironmentVariables: body.featureFlags.enableEnvironmentVariables ?? false,
         enableResend: body.featureFlags.enableResend ?? false,
       },
     });
diff --git a/app/lib/.server/llm/convex-agent.ts b/app/lib/.server/llm/convex-agent.ts
@@ -56,9 +56,6 @@ export async function convexAgent(args: {
   collapsedMessages: boolean;
   promptCharacterCounts?: PromptCharacterCounts;
   featureFlags: {
-    enablePreciseEdits: boolean;
-    smallFiles: boolean;
-    enableEnvironmentVariables: boolean;
     enableResend: boolean;
   };
 }) {
@@ -88,13 +85,11 @@ export async function convexAgent(args: {
   const provider = getProvider(userApiKey, modelProvider, modelChoice);
   const opts: SystemPromptOptions = {
     enableBulkEdits: true,
-    enablePreciseEdits: featureFlags.enablePreciseEdits,
     includeTemplate: true,
     openaiProxyEnabled: getEnv('OPENAI_PROXY_ENABLED') == '1',
     usingOpenAi: modelProvider == 'OpenAI',
     usingGoogle: modelProvider == 'Google',
     resendProxyEnabled: getEnv('RESEND_PROXY_ENABLED') == '1',
-    smallFiles: featureFlags.smallFiles,
     enableResend: featureFlags.enableResend,
   };
   const tools: ConvexToolSet = {
@@ -103,13 +98,9 @@ export async function convexAgent(args: {
     lookupDocs: lookupDocsTool(),
     getConvexDeploymentName: getConvexDeploymentNameTool,
   };
-  if (featureFlags.enableEnvironmentVariables) {
-    tools.addEnvironmentVariables = addEnvironmentVariablesTool();
-  }
-  if (opts.enablePreciseEdits) {
-    tools.view = viewTool;
-    tools.edit = editTool;
-  }
+  tools.addEnvironmentVariables = addEnvironmentVariablesTool();
+  tools.view = viewTool;
+  tools.edit = editTool;
 
   const messagesForDataStream: CoreMessage[] = [
     {
@@ -160,7 +151,6 @@ export async function convexAgent(args: {
             _startTime: startTime,
             _firstResponseTime: firstResponseTime,
             providerModel: provider.model.modelId,
-            featureFlags,
           });
         },
         onError({ error }) {
@@ -229,7 +219,6 @@ async function onFinishHandler({
   _startTime,
   _firstResponseTime,
   providerModel,
-  featureFlags,
 }: {
   dataStream: DataStreamWriter;
   messages: Messages;
@@ -250,12 +239,6 @@ async function onFinishHandler({
   _startTime: number;
   _firstResponseTime: number | null;
   providerModel: string;
-  featureFlags: {
-    enablePreciseEdits: boolean;
-    smallFiles: boolean;
-    enableEnvironmentVariables: boolean;
-    enableResend: boolean;
-  };
 }) {
   const { providerMetadata } = result;
   // This usage accumulates accross multiple /api/chat calls until finishReason of 'stop'.
@@ -277,9 +260,6 @@ async function onFinishHandler({
     span.setAttribute('usage.completionTokens', usage.completionTokens);
     span.setAttribute('usage.promptTokens', usage.promptTokens);
     span.setAttribute('usage.totalTokens', usage.totalTokens);
-    span.setAttribute('featureFlags.smallFiles', featureFlags.smallFiles);
-    span.setAttribute('featureFlags.enablePreciseEdits', featureFlags.enablePreciseEdits);
-    span.setAttribute('featureFlags.enableEnvironmentVariables', featureFlags.enableEnvironmentVariables);
     span.setAttribute('collapsedMessages', collapsedMessages);
     span.setAttribute('model', providerModel);
 
diff --git a/app/lib/common/prompts/types.ts b/app/lib/common/prompts/types.ts
@@ -1,6 +1,5 @@
 export interface SystemPromptOptions {
   enableBulkEdits: boolean;
-  enablePreciseEdits: boolean;
   includeTemplate: boolean;
   openaiProxyEnabled: boolean;
   usingOpenAi: boolean;
diff --git a/app/lib/hooks/useLaunchDarkly.ts b/app/lib/hooks/useLaunchDarkly.ts
@@ -4,15 +4,12 @@ import { kebabCase } from 'lodash';
 const flagDefaults: {
   maintenanceMode: boolean;
   showUsageAnnotations: boolean;
-  smallFiles: boolean;
   recordRawPromptsForDebugging: boolean;
   maxCollapsedMessagesSize: number;
   maxRelevantFilesSize: number;
   minCollapsedMessagesSize: number;
   useGeminiAuto: boolean;
   notionClonePrompt: boolean;
-  enablePreciseEdits: boolean;
-  enableEnvironmentVariables: boolean;
   newChatFeature: boolean;
   minMessagesForNudge: number;
   enableResend: boolean;
@@ -21,15 +18,12 @@ const flagDefaults: {
 } = {
   maintenanceMode: false,
   showUsageAnnotations: false,
-  smallFiles: true,
   recordRawPromptsForDebugging: false,
   maxCollapsedMessagesSize: 65536,
   maxRelevantFilesSize: 8192,
   minCollapsedMessagesSize: 8192,
   useGeminiAuto: false,
   notionClonePrompt: false,
-  enablePreciseEdits: false,
-  enableEnvironmentVariables: false,
   newChatFeature: false,
   minMessagesForNudge: 40,
   enableResend: false,
diff --git a/chef-agent/prompts/outputInstructions.ts b/chef-agent/prompts/outputInstructions.ts
@@ -201,12 +201,12 @@ function toolsInstructions(options: SystemPromptOptions) {
       message so that the user has time to add the environment variables before the next message.
     </addEnvironmentVariables_tool>
 
-    ${options.enablePreciseEdits ? preciseToolInstructions(options) : ''}
+    ${preciseToolInstructions()}
   </tools>
   `;
 }
 
-function preciseToolInstructions(_options: SystemPromptOptions) {
+function preciseToolInstructions() {
   return stripIndents`
     <view_tool>
       The environment automatically provides relevant files, but you can ask to see particular files by using the view
diff --git a/chef-agent/prompts/solutionConstraints.ts b/chef-agent/prompts/solutionConstraints.ts
@@ -6,7 +6,7 @@ export function solutionConstraints(options: SystemPromptOptions) {
   return stripIndents`
   <solution_constraints>
 
-    ${options.includeTemplate ? templateInfo(options) : ''}
+    ${options.includeTemplate ? templateInfo() : ''}
 
     <convex_guidelines>
       You MUST use Convex for the database, realtime, file storage, functions, scheduling, HTTP handlers,
@@ -176,27 +176,7 @@ export function solutionConstraints(options: SystemPromptOptions) {
   `;
 }
 
-function appTsxInstructions(systemPromptOptions: SystemPromptOptions) {
-  const { smallFiles } = systemPromptOptions;
-  return smallFiles
-    ? stripIndents`
-    <file path="src/App.tsx">
-      This is the main React component for the app. It starts with a simple login form and a button to add a
-      random number to a list. It uses "src/SignInForm.tsx" and "src/SignOutButton.tsx" for the login and
-      logout functionality. Add new React components to their own files in the 'src' directory to avoid
-      cluttering the main file.
-    </file>
-  `
-    : stripIndents`
-    <file path="src/App.tsx">
-      This is the main React component for the app. It starts with a simple login form and a button to add a
-      random number to a list. It uses "src/SignInForm.tsx" and "src/SignOutButton.tsx" for the login and
-      logout functionality. 
-    </file>
-  `;
-}
-
-function templateInfo(systemPromptOptions: SystemPromptOptions) {
+function templateInfo() {
   return stripIndents`
   <template_info>
     The Chef WebContainer environment starts with a full-stack app template fully loaded at '/home/project',
@@ -241,7 +221,13 @@ function templateInfo(systemPromptOptions: SystemPromptOptions) {
       this file. The \`authTables\` object is imported with \`import { authTables } from "@convex-dev/auth/server";\`.
     </file>
 
-    ${appTsxInstructions(systemPromptOptions)}
+    <file path="src/App.tsx">
+      This is the main React component for the app. It starts with a simple login form and a button to add a
+      random number to a list. It uses "src/SignInForm.tsx" and "src/SignOutButton.tsx" for the login and
+      logout functionality. Add new React components to their own files in the 'src' directory to avoid
+      cluttering the main file.
+    </file>
+
     <file path="src/main.tsx">
       This file is the entry point for the app and sets up the 'ConvexAuthProvider'.
 
diff --git a/chef-agent/types.ts b/chef-agent/types.ts
@@ -19,13 +19,11 @@ export type ConvexProject = {
 
 export interface SystemPromptOptions {
   enableBulkEdits: boolean;
-  enablePreciseEdits: boolean;
   includeTemplate: boolean;
   openaiProxyEnabled: boolean;
   usingOpenAi: boolean;
   usingGoogle: boolean;
   resendProxyEnabled: boolean;
-  smallFiles: boolean;
   enableResend: boolean;
 }
 
diff --git a/test-kitchen/chefTask.ts b/test-kitchen/chefTask.ts
@@ -97,7 +97,6 @@ export async function chefTask(model: ChefModel, outputDir: string, userMessage:
     };
     const opts: SystemPromptOptions = {
       enableBulkEdits: true,
-      enablePreciseEdits: true,
       includeTemplate: true,
       usingOpenAi: model.name.startsWith('gpt-'),
       usingGoogle: model.name.startsWith('gemini-'),
@@ -108,7 +107,7 @@ export async function chefTask(model: ChefModel, outputDir: string, userMessage:
       // proxies should never be used in the test kitchen.
       openaiProxyEnabled: true,
       resendProxyEnabled: true,
-      smallFiles: true,
+      enableResend: false,
     };
     const assistantMessage: UIMessage = {
       id: generateId(),
@@ -119,7 +118,7 @@ export async function chefTask(model: ChefModel, outputDir: string, userMessage:
     let numDeploys = 0;
     let success: boolean;
     let lastDeploySuccess = false;
-    let totalUsage: LanguageModelUsage = {
+    const totalUsage: LanguageModelUsage = {
       promptTokens: 0,
       completionTokens: 0,
       totalTokens: 0,
@@ -409,10 +408,8 @@ async function invokeGenerateText(model: ChefModel, opts: SystemPromptOptions, c
           lookupDocs: lookupDocsTool(),
           getConvexDeploymentName: getConvexDeploymentNameTool,
         };
-        if (opts.enablePreciseEdits) {
-          tools.view = viewTool;
-          tools.edit = editTool;
-        }
+        tools.view = viewTool;
+        tools.edit = editTool;
         const result = await generateText({
           model: model.ai,
           maxTokens: model.maxTokens,
