Get rid of TableNamespace::TODO() (#42990)

goffrie · Convex, Inc. · commit 0126dc9cdc75 · 2025-11-13T00:06:28.000Z
GitOrigin-RevId: 61760db83b4ffbabcc6a6729bd13e43083cae62b
diff --git a/crates/isolate/src/isolate2/runner.rs b/crates/isolate/src/isolate2/runner.rs
@@ -1042,7 +1042,7 @@ pub async fn run_isolate_v2_udf<RT: Runtime>(
     let total_timeout = Duration::from_secs(128);
 
     // TODO: Move these into the timeout.
-    let udf_config = UdfConfigModel::new(&mut tx, TableNamespace::TODO())
+    let udf_config = UdfConfigModel::new(&mut tx, path_and_args.path().component.into())
         .get()
         .await?;
     let import_time_seed = SeedData {
diff --git a/crates/value/src/table_mapping.rs b/crates/value/src/table_mapping.rs
@@ -53,13 +53,6 @@ impl TableNamespace {
     pub const fn by_component_TODO() -> Self {
         Self::Global
     }
-
-    /// Namespace that should be passed down, and could be Global, ByComponent,
-    /// or ByComponentDefinition.
-    #[allow(non_snake_case)]
-    pub const fn TODO() -> Self {
-        Self::Global
-    }
 }
 
 // This TableMapping contains the mapping between TableNames and

Original file line number	Diff line number	Diff line change
`@@ -53,13 +53,6 @@ impl TableNamespace {`
`53`	`53`	`pub const fn by_component_TODO() -> Self {`
`54`	`54`	`Self::Global`
`55`	`55`	`}`
`56`		`-`
`57`		`- /// Namespace that should be passed down, and could be Global, ByComponent,`
`58`		`- /// or ByComponentDefinition.`
`59`		`- #[allow(non_snake_case)]`
`60`		`- pub const fn TODO() -> Self {`
`61`		`- Self::Global`
`62`		`- }`
`63`	`56`	`}`
`64`	`57`
`65`	`58`	`// This TableMapping contains the mapping between TableNames and`