don't allow deleting emails that are associated with an identity (#41513)

Disallows deleting emails that are associated with an identity.

GitOrigin-RevId: f779dfaaca0d423ed98b231b0256348edfa71c11

Author: atrakh

npm-packages/dashboard/src/components/profile/ConnectedIdentities.tsx

@@ -38,13 +38,13 @@ export function ConnectedIdentities() {
     <Sheet className="flex flex-col gap-4">
       <h3>Identities</h3>
       <p className="max-w-prose text-sm">
-        These are the identities associated with your account. Identities are
-        used to login to Convex, and are distinct from the emails connected to
-        your account for communication purposes.
+        These are the identities associated with your account.
       </p>
       <p>
-        When you login with an identity, it's email is automatically associated
-        with your account.
+        Identities are used to login to Convex, and are distinct from the emails
+        connected to your account for communication purposes. However, you can
+        only login with identities that are verified emails on your Convex
+        account.
       </p>
       <LoadingTransition loadingProps={{ className: "h-[13rem]" }}>
         {identities && (
@@ -67,11 +67,11 @@ export function ConnectedIdentities() {
           dialogTitle="Unlink Identity"
           dialogBody={
             <div className="flex flex-col gap-1">
+              <p>Are you sure you want to unlink this identity? </p>
               <p>
-                Are you sure you want to unlink this identity? You will no
-                longer be able to sign in with the providers associated with
-                this identity unless the email associated with this identity is
-                verified to your account.
+                After you unlink this identity, you must also delete the
+                associated email to restrict this email from logging in to
+                Convex.
               </p>
               <p>
                 Once you unlink this identity, you will be logged out of the

npm-packages/dashboard/src/components/profile/EmailList.test.tsx

@@ -7,6 +7,7 @@ jest.mock("api/profile", () => ({
   useDeleteProfileEmail: jest.fn(),
   useUpdatePrimaryProfileEmail: jest.fn(),
   useResendProfileEmailVerification: jest.fn(),
+  useIdentities: jest.fn(),
 }));
 
 const mockEmails: MemberEmailResponse[] = [

npm-packages/dashboard/src/components/profile/EmailListItem.test.tsx

@@ -13,6 +13,7 @@ jest.mock("api/profile", () => ({
   useDeleteProfileEmail: jest.fn(),
   useUpdatePrimaryProfileEmail: jest.fn(),
   useResendProfileEmailVerification: jest.fn(),
+  useIdentities: jest.fn(),
 }));
 
 const mockDeleteProfileEmail = useDeleteProfileEmail as jest.Mock;

npm-packages/dashboard/src/components/profile/EmailListItem.tsx

@@ -3,13 +3,18 @@ import { ConfirmationDialog } from "@ui/ConfirmationDialog";
 import { Menu, MenuItem } from "@ui/Menu";
 import {
   useDeleteProfileEmail,
+  useIdentities,
   useResendProfileEmailVerification,
   useUpdatePrimaryProfileEmail,
 } from "api/profile";
 import { useState } from "react";
 import { MemberEmailResponse } from "generatedApi";
 
 export function EmailListItem({ email }: { email: MemberEmailResponse }) {
+  const identities = useIdentities();
+  const emailIsAnIdentity = identities?.some(
+    (identity) => identity.email === email.email,
+  );
   const deleteEmail = useDeleteProfileEmail();
   const updatePrimaryEmail = useUpdatePrimaryProfileEmail();
   const resentEmailVerification = useResendProfileEmailVerification();
@@ -60,12 +65,14 @@ export function EmailListItem({ email }: { email: MemberEmailResponse }) {
         ) : null}
         <MenuItem
           action={() => setShowDeleteConfirmation(true)}
-          disabled={email.isPrimary}
+          disabled={email.isPrimary || emailIsAnIdentity}
           variant="danger"
           tip={
             email.isPrimary
               ? "You cannot delete your primary email."
-              : undefined
+              : emailIsAnIdentity
+                ? "You cannot delete this email because it is associated with an identity on your account. Delete the identity first to remove this email from your account."
+                : undefined
           }
           tipSide="right"
         >