Yet more unnecessary fallible type conversions (#24699)

GitOrigin-RevId: 585f24a57bfe015c830572a2173123ae3870b324

Author: sjudd

crates/common/src/schemas/validator.rs

@@ -1131,7 +1131,7 @@ mod tests {
             Validator::Boolean => assert_val!(false),
             Validator::String => assert_val!(""),
             Validator::Bytes => ConvexValue::Bytes(vec![1, 2, 3].try_into()?),
-            Validator::Literal(literal) => literal.try_into()?,
+            Validator::Literal(literal) => literal.into(),
             Validator::Array(v) => {
                 assert_val!([value_from_validator(*v, id_generator)?])
             },
@@ -1516,7 +1516,7 @@ mod tests {
         // generate an ID so it's in the table mapping
         id_generator.generate(&table1);
         let document_id = id_generator.generate(&table2);
-        let id_v6 = DocumentIdV6::try_from(document_id)?;
+        let id_v6 = DocumentIdV6::from(document_id);
         let value: ConvexValue = id_v6.into();
 
         let err = id_validator

crates/common/src/shapes/tests.rs

@@ -95,11 +95,11 @@ fn test_id_strings() -> anyhow::Result<()> {
     // Create three IDs from three different tables
     let message_id: DocumentIdV6 = id_generator
         .generate(&TableName::from_str("messages")?)
-        .try_into()?;
+        .into();
     let deleted1_table = TableName::from_str("deleted1")?;
     let deleted2_table = TableName::from_str("deleted2")?;
-    let deleted1_id: DocumentIdV6 = id_generator.generate(&deleted1_table).try_into()?;
-    let deleted2_id: DocumentIdV6 = id_generator.generate(&deleted2_table).try_into()?;
+    let deleted1_id: DocumentIdV6 = id_generator.generate(&deleted1_table).into();
+    let deleted2_id: DocumentIdV6 = id_generator.generate(&deleted2_table).into();
 
     // Delete two of the tables
     let deleted1_table_id = id_generator.id(&deleted1_table)?;

crates/convex/examples/convex_chat_client.rs

@@ -142,8 +142,8 @@ async fn main() -> anyhow::Result<()> {
             .mutation(
                 "messages:send",
                 btreemap! {
-                    "body".to_string() => line.try_into()?,
-                    "author".to_string() => sender.clone().try_into()?
+                    "body".to_string() => line.into(),
+                    "author".to_string() => sender.clone().into(),
                 },
             )
             .await?;

crates/convex/src/value/json/mod.rs

@@ -61,7 +61,7 @@ impl TryFrom<JsonValue> for Value {
                     .context("Arbitrary precision JSON integers unsupported")?;
                 Value::from(n)
             },
-            JsonValue::String(s) => Self::try_from(s)?,
+            JsonValue::String(s) => Self::from(s),
             JsonValue::Array(arr) => {
                 let mut out = Vec::with_capacity(arr.len());
                 for a in arr {

crates/indexing/src/tests.rs

@@ -408,7 +408,7 @@ fn test_metadata_index_updates() -> anyhow::Result<()> {
             },
             DatabaseIndexUpdate {
                 index_id: by_author,
-                key: IndexKey::new(vec![33.try_into()?], doc_id.into()),
+                key: IndexKey::new(vec![33.into()], doc_id.into()),
                 value: DatabaseIndexValue::NonClustered(doc_id),
                 is_system_index: false,
             },
@@ -449,7 +449,7 @@ fn test_metadata_index_updates() -> anyhow::Result<()> {
             // will become quite complicated. We can reconsider in the long run.
             DatabaseIndexUpdate {
                 index_id: by_author,
-                key: IndexKey::new(vec![33.try_into()?], doc_id.into()),
+                key: IndexKey::new(vec![33.into()], doc_id.into()),
                 value: DatabaseIndexValue::NonClustered(doc_id),
                 is_system_index: false,
             },
@@ -492,7 +492,7 @@ fn test_metadata_index_updates() -> anyhow::Result<()> {
             },
             DatabaseIndexUpdate {
                 index_id: by_author,
-                key: IndexKey::new(vec![33.try_into()?], doc_id.into()),
+                key: IndexKey::new(vec![33.into()], doc_id.into()),
                 value: DatabaseIndexValue::NonClustered(doc_id),
                 is_system_index: false,
             },
@@ -523,7 +523,7 @@ fn test_metadata_index_updates() -> anyhow::Result<()> {
             },
             DatabaseIndexUpdate {
                 index_id: by_author,
-                key: IndexKey::new(vec![33.try_into()?], doc_id.into()),
+                key: IndexKey::new(vec![33.into()], doc_id.into()),
                 value: DatabaseIndexValue::Deleted,
                 is_system_index: false,
             },

crates/keybroker/src/broker.rs

@@ -991,7 +991,7 @@ mod tests {
         let mut journal_with_cursor = QueryJournal::new();
         journal_with_cursor.end_cursor = Some(Cursor {
             position: CursorPosition::After(
-                IndexKey::new(vec![100.try_into()?], DeveloperDocumentId::min()).into_bytes(),
+                IndexKey::new(vec![100.into()], DeveloperDocumentId::min()).into_bytes(),
             ),
             query_fingerprint: query.fingerprint(&IndexedFields::creation_time())?,
         });
@@ -1053,7 +1053,7 @@ mod tests {
 
         #[test]
         fn test_identity_proto_roundtrips(identity in any::<Identity>()) {
-            let proto: pb::convex_identity::Identity = identity.clone().try_into().unwrap();
+            let proto: pb::convex_identity::Identity = identity.clone().into();
             let roundtripped = Identity::from_proto_unchecked(proto).unwrap();
             assert_eq!(identity, roundtripped);
         }
@@ -1062,8 +1062,7 @@ mod tests {
         fn test_admin_identity_proto_roundtrips(admin_identity in any::<AdminIdentity>()) {
             let proto: pb::convex_identity::AdminIdentity = admin_identity
                 .clone()
-                .try_into()
-                .unwrap();
+                .into();
             let roundtripped = AdminIdentity::from_proto_unchecked(proto).unwrap();
             assert_eq!(admin_identity, roundtripped);
         }