Remove a bunch of unecessary fallible conversions (#24678)

GitOrigin-RevId: 25c1bf89e85737c0f0c36af88bc0f54d6d30dd9f

Author: sjudd

crates/common/src/bootstrap_model/index/vector_index/backfill_state.rs

@@ -45,10 +45,7 @@ impl TryFrom<VectorIndexBackfillState> for SerializedVectorIndexBackfillState {
                     .collect::<anyhow::Result<Vec<_>>>()?,
             ),
             document_cursor: backfill_state.cursor.map(|id| id.to_string()),
-            backfill_snapshot_ts: backfill_state
-                .backfill_snapshot_ts
-                .map(|ts| ts.try_into())
-                .transpose()?,
+            backfill_snapshot_ts: backfill_state.backfill_snapshot_ts.map(|ts| ts.into()),
         })
     }
 }

crates/common/src/bootstrap_model/index/vector_index/segment.rs

@@ -119,9 +119,9 @@ impl TryFrom<FragmentedVectorSegment> for pb::searchlight::FragmentedVectorSegme
 
     fn try_from(value: FragmentedVectorSegment) -> Result<Self, Self::Error> {
         Ok(Self {
-            segment_key: value.segment_key.try_into()?,
-            id_tracker_key: value.id_tracker_key.try_into()?,
-            deleted_bitset_key: value.deleted_bitset_key.try_into()?,
+            segment_key: value.segment_key.into(),
+            id_tracker_key: value.id_tracker_key.into(),
+            deleted_bitset_key: value.deleted_bitset_key.into(),
             num_vectors: value.num_vectors,
             num_deleted: value.num_deleted,
             id: value.id,

crates/common/src/errors.rs

@@ -362,7 +362,7 @@ impl TryFrom<JsError> for JsErrorProto {
             message: Some(message),
             custom_data: custom_data
                 .map(|v| {
-                    let json = JsonValue::try_from(v)?;
+                    let json = JsonValue::from(v);
                     anyhow::Ok::<Vec<u8>>(serde_json::to_vec(&json)?)
                 })
                 .transpose()?,

crates/common/src/log_streaming.rs

@@ -58,7 +58,7 @@ pub struct LogEvent {
 impl LogEvent {
     pub fn default_for_verification<RT: Runtime>(runtime: &RT) -> anyhow::Result<Self> {
         let mut payload = serde_json::Map::new();
-        payload.insert("message".to_string(), "Convex connection test".try_into()?);
+        payload.insert("message".to_string(), "Convex connection test".into());
         Ok(Self {
             topic: LogTopic::Verification,
             source: EventSource::System,
@@ -124,16 +124,16 @@ impl TryFrom<LogEvent> for serde_json::Map<String, JsonValue> {
         // Global system fields
         fields.insert("_topic".to_string(), event.topic.try_into()?);
         let ms = event.timestamp.as_ms_since_epoch()?;
-        fields.insert("_timestamp".to_string(), ms.try_into()?);
+        fields.insert("_timestamp".to_string(), ms.into());
         // Source system fields
         match event.source {
             EventSource::Function(f) => {
-                fields.insert("_functionPath".to_string(), f.path.try_into()?);
+                fields.insert("_functionPath".to_string(), f.path.into());
                 fields.insert(
                     "_functionType".to_string(),
                     serde_json::to_value(f.udf_type)?,
                 );
-                fields.insert("_functionCached".to_string(), f.cached.try_into()?);
+                fields.insert("_functionCached".to_string(), f.cached.into());
             },
             EventSource::System => {},
         }

crates/common/src/schemas/json.rs

@@ -116,7 +116,7 @@ impl TryFrom<ConvexValue> for DatabaseSchema {
     type Error = anyhow::Error;
 
     fn try_from(v: ConvexValue) -> anyhow::Result<Self> {
-        JsonValue::try_from(v)?.try_into()
+        JsonValue::from(v).try_into()
     }
 }
 

crates/value/src/lib.rs

@@ -204,9 +204,7 @@ impl From<ConvexObject> for ConvexValue {
 
 impl From<ResolvedDocumentId> for ConvexValue {
     fn from(value: ResolvedDocumentId) -> Self {
-        DocumentIdV6::try_from(value)
-            .expect("Could not create IDV6 from DocumentId")
-            .into()
+        DocumentIdV6::from(value).into()
     }
 }
 

crates/value/src/sha256.rs

@@ -117,12 +117,7 @@ impl Sha256 {
     }
 
     pub fn finalize(self) -> Sha256Digest {
-        Sha256Digest(
-            self.inner
-                .finalize()
-                .try_into()
-                .expect("Sha256 wasn't 32 bytes?"),
-        )
+        Sha256Digest(self.inner.finalize().into())
     }
 }