Remove backill single index from vector flusher (#26361)

GitOrigin-RevId: b42e6245922fd9bf4766fdd0f99780dbc1d3eb19

Author: sjudd

crates/database/src/tests/vector_tests.rs

@@ -32,7 +32,6 @@ use common::{
     types::{
         unchecked_repeatable_ts,
         IndexName,
-        TabletIndexName,
     },
 };
 use itertools::Itertools;
@@ -214,19 +213,12 @@ impl<RT: Runtime> Scenario<RT> {
     }
 
     async fn backfill(&self) -> anyhow::Result<()> {
-        let snapshot = self.database.latest_snapshot()?;
-        let table_id = snapshot
-            .table_mapping()
-            .namespace(TABLE_NAMESPACE)
-            .id(&TABLE_NAME.parse()?)?
-            .tablet_id;
-        VectorIndexFlusher::build_index_in_test(
-            TabletIndexName::new(table_id, INDEX_DESCRIPTOR.parse()?)?,
-            TABLE_NAME.parse()?,
+        VectorIndexFlusher::backfill_all_in_test(
             self.rt.clone(),
             self.database.clone(),
             self.reader.clone(),
             self.search_storage.clone(),
+            0,
         )
         .await?;
         Ok(())

crates/database/src/vector_index_worker/flusher.rs

@@ -74,71 +74,6 @@ impl<RT: Runtime> VectorIndexFlusher<RT> {
         self.flusher.step().await
     }
 
-    #[cfg(any(test, feature = "testing"))]
-    pub async fn build_index_in_test(
-        index_name: TabletIndexName,
-        table_name: value::TableName,
-        runtime: RT,
-        database: Database<RT>,
-        reader: Arc<dyn PersistenceReader>,
-        storage: Arc<dyn Storage>,
-    ) -> anyhow::Result<()> {
-        use anyhow::Context;
-        use common::types::IndexName;
-        use keybroker::Identity;
-        use value::TableNamespace;
-
-        use crate::{
-            index_workers::{
-                index_meta::SearchIndexConfigParser,
-                search_flusher::IndexBuild,
-                BuildReason,
-            },
-            IndexModel,
-        };
-
-        let mut tx = database.begin(Identity::system()).await?;
-        let index_name_ = IndexName::new(table_name.clone(), index_name.descriptor().clone())?;
-        let mut index_model = IndexModel::new(&mut tx);
-        let namespace = TableNamespace::Global;
-        let pending_metadata = index_model.pending_index_metadata(namespace, &index_name_)?;
-        let enabled_metadata = index_model.enabled_index_metadata(namespace, &index_name_)?;
-        let metadata = pending_metadata.unwrap_or_else(|| enabled_metadata.unwrap());
-        let index_config = VectorIndexConfigParser::get_config(metadata.config.clone())
-            .context("Not a vector index?")?;
-        let by_id = IndexName::by_id(table_name.clone());
-        let Some(by_id_metadata) =
-            IndexModel::new(&mut tx).enabled_index_metadata(namespace, &by_id)?
-        else {
-            anyhow::bail!("Missing by_id index for {index_name:?}");
-        };
-        let writer = SearchIndexMetadataWriter::new(
-            runtime.clone(),
-            database.clone(),
-            storage.clone(),
-            SearchType::Vector,
-        );
-        let worker = Self::new(runtime, database, reader, storage, writer);
-        let job = IndexBuild {
-            index_name,
-            index_id: metadata.clone().into_id_and_value().0.internal_id(),
-            by_id: by_id_metadata.id().internal_id(),
-            index_config,
-            metadata_id: metadata.clone().id(),
-            build_reason: BuildReason::TooLarge,
-        };
-        worker
-            .flusher
-            .build_one(
-                job,
-                BuildVectorIndexArgs {
-                    full_scan_threshold_bytes: *VECTOR_INDEX_SIZE_SOFT_LIMIT,
-                },
-            )
-            .await?;
-        Ok(())
-    }
-
     /// Backfills all search indexes that are in a "backfilling" state.
     #[cfg(any(test, feature = "testing"))]
     pub async fn backfill_all_in_test(