fix error propagation through ConvexValue serde (#25129)

unwrap the `anyhow::Error` in all public functions, and don't expose the internal `Error` type at all if we can help it (especially not for `Serialize` which is the thing that can throw bad_request errors).

added regression test

GitOrigin-RevId: e77c9774e3bcf3e492c68cc0c82b79e8688aa833

Author: ldanilek

crates/value/src/serde/de.rs

@@ -768,10 +768,18 @@ impl<'de> serde::Deserializer<'de> for MapKeyDeserializer {
     }
 }
 
-pub fn from_value<T: DeserializeOwned>(value: ConvexValue) -> Result<T, Error> {
-    T::deserialize(value)
+pub fn from_value<T: DeserializeOwned>(value: ConvexValue) -> anyhow::Result<T> {
+    match T::deserialize(value) {
+        Err(Error::Anyhow(e)) => Err(e),
+        Err(e) => Err(e.into()),
+        Ok(value) => Ok(value),
+    }
 }
 
-pub fn from_object<T: DeserializeOwned>(value: ConvexObject) -> Result<T, Error> {
-    T::deserialize(ConvexValue::Object(value))
+pub fn from_object<T: DeserializeOwned>(value: ConvexObject) -> anyhow::Result<T> {
+    match T::deserialize(ConvexValue::Object(value)) {
+        Err(Error::Anyhow(e)) => Err(e),
+        Err(e) => Err(e.into()),
+        Ok(value) => Ok(value),
+    }
 }

crates/value/src/serde/mod.rs

@@ -27,7 +27,7 @@ macro_rules! codegen_convex_serialization {
             type Error = anyhow::Error;
 
             fn try_from(s: $struct) -> anyhow::Result<value::ConvexObject> {
-                Ok(value::serde::to_object($serialized_struct::try_from(s)?)?)
+                value::serde::to_object($serialized_struct::try_from(s)?)
             }
         }
 

crates/value/src/serde/ser.rs

@@ -22,7 +22,7 @@ use crate::{
 };
 
 #[derive(thiserror::Error)]
-pub enum Error {
+enum Error {
     #[error("Integer isn't in range for ConvexValue::Int64: {0:?}.")]
     IntegerOutofRange(#[from] TryFromIntError),
 
@@ -668,10 +668,14 @@ impl serde::ser::SerializeStruct for SerializeObject {
     }
 }
 
-pub fn to_value<T: Serialize>(value: T) -> Result<ConvexValue> {
-    value.serialize(Serializer)
+pub fn to_value<T: Serialize>(value: T) -> anyhow::Result<ConvexValue> {
+    match value.serialize(Serializer) {
+        Err(Error::Anyhow(e)) => Err(e),
+        Err(e) => Err(e.into()),
+        Ok(value) => Ok(value),
+    }
 }
 
-pub fn to_object<T: Serialize>(value: T) -> Result<ConvexObject> {
-    Ok(to_value(value)?.try_into()?)
+pub fn to_object<T: Serialize>(value: T) -> anyhow::Result<ConvexObject> {
+    to_value(value)?.try_into()
 }

crates/value/src/serde/value.rs

@@ -192,7 +192,9 @@ impl<'de> Deserialize<'de> for FieldName {
 
 #[cfg(test)]
 mod tests {
+    use errors::ErrorMetadataAnyhowExt;
     use proptest::prelude::*;
+    use serde_json::json;
 
     use crate::{
         serde::{
@@ -225,4 +227,13 @@ mod tests {
             assert_eq!(start, deserialized);
         }
     }
+
+    #[test]
+    fn test_error_metadata() {
+        // Regression test, checking that error metadata is piped through.
+        let big_json = json!("a".repeat(64_000_000));
+        let serialize_result = to_value(big_json);
+        let anyhow_err: anyhow::Error = serialize_result.unwrap_err();
+        assert!(anyhow_err.is_bad_request());
+    }
 }