[Open Source] Make chef deploy secret required (#41033)

GitOrigin-RevId: ddad380da1801823257085103d912ca1f6364916

Author: jordanhunt22

crates/common/src/http/mod.rs

@@ -1109,15 +1109,19 @@ where
 pub const CONVEX_CHEF_DEPLOY_SECRET_HEADER: HeaderName =
     HeaderName::from_static("convex-chef-deploy-secret");
 
-pub struct ExtractChefDeploySecret(pub Option<String>);
+pub struct ExtractChefDeploySecret(pub String);
 
-fn chef_deploy_secret_from_req_parts(parts: &mut axum::http::request::Parts) -> Option<String> {
-    // TODO(jordan): Once chef is pushed, this should no longer be optional and we
-    // should throw an error if it's not present
+fn chef_deploy_secret_from_req_parts(
+    parts: &mut axum::http::request::Parts,
+) -> anyhow::Result<String> {
     parts
         .headers
         .get(CONVEX_CHEF_DEPLOY_SECRET_HEADER)
         .and_then(|h| h.to_str().ok().map(|s| s.to_string()))
+        .context(ErrorMetadata::bad_request(
+            "InvalidChefDeploySecret",
+            "convex-chef-deploy-secret header is not set",
+        ))
 }
 
 impl<S> FromRequestParts<S> for ExtractChefDeploySecret
@@ -1130,7 +1134,7 @@ where
         parts: &mut axum::http::request::Parts,
         _state: &S,
     ) -> Result<Self, Self::Rejection> {
-        let shared_secret = chef_deploy_secret_from_req_parts(parts);
+        let shared_secret = chef_deploy_secret_from_req_parts(parts)?;
         Ok(Self(shared_secret))
     }
 }