Skip to content

Commit 3345cef

Browse files
goffrieConvex, Inc.
authored andcommitted
Raise MAX_FUNRUN_RUN_FUNCTION_REQUEST_MESSAGE_SIZE to 64MiB (#41058)
GitOrigin-RevId: 6d90f12b39a821f154a79cf6220914e55dc47016
1 parent 2e52c7e commit 3345cef

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

crates/common/src/knobs.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,15 +1139,18 @@ pub static SEARCH_COMPACTOR_MAX_BACKOFF: LazyLock<Duration> =
11391139
pub static SEARCH_COMPACTOR_INITIAL_BACKOFF: LazyLock<Duration> =
11401140
LazyLock::new(|| Duration::from_secs(env_config("SEARCH_COMPACTOR_INITIAL_BACKOFF", 60)));
11411141

1142-
/// The maximum size for Funrun run function request messages. This is 8MiB for
1143-
/// path and args, plus a buffer for the smaller fields. Note that analyze has a
1144-
/// much higher limit because it includes user source code.
1142+
/// The maximum size for Funrun run function request messages. The user-level
1143+
/// limit is 16MiB for args (as counted by ConvexValue::size), but the actual
1144+
/// wire encoding can be 3-4x that, so we set a higher limit here.
1145+
///
1146+
/// Note that analyze has a much higher limit because it includes user source
1147+
/// code.
11451148
pub static MAX_FUNRUN_RUN_FUNCTION_REQUEST_MESSAGE_SIZE: LazyLock<usize> = LazyLock::new(|| {
11461149
env_config(
11471150
"MAX_FUNRUN_RUN_FUNCTION_REQUEST_MESSAGE_SIZE",
1148-
(1 << 24) + 2000,
1151+
1 << 26, // 64MiB
11491152
)
1150-
}); // 16 MiB + buffer
1153+
});
11511154

11521155
/// The maximum size for Funrun run function response messages. 8MiB for reads +
11531156
/// 16 MiB for writes + 16MiB for function result + 8MiB for log lines and a 8

0 commit comments

Comments
 (0)