Switch to edition 2024 (#42346)

... except `convex` and `sync_types` which have a defined MSRV.

GitOrigin-RevId: d2160aa9b0878747aacf8a5b88e1fdb8607f1677

Author: goffrie

crates/application/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "application"
 version = "0.1.0"
-edition = "2021"
+edition = "2024"
 license = "LicenseRef-FSL-1.1-Apache-2.0"
 
 [lib]

crates/application/src/application_function_runner/http_routing.rs

@@ -354,10 +354,10 @@ impl<RT: Runtime> ApplicationFunctionRunner<RT> {
 
             // First, try matching an exact path from `http.js`, which will always
             // be the most specific match.
-            if let Some(ref http_routes) = http_routes {
-                if http_routes.route_exact(&routed_path[..], method) {
-                    return Ok(Some((current_component_path, routed_path)));
-                }
+            if let Some(ref http_routes) = http_routes
+                && http_routes.route_exact(&routed_path[..], method)
+            {
+                return Ok(Some((current_component_path, routed_path)));
             }
 
             // Next, try finding the most specific prefix match from both `http.js`
@@ -368,10 +368,10 @@ impl<RT: Runtime> ApplicationFunctionRunner<RT> {
             }
             let mut longest_match = None;
 
-            if let Some(ref http_routes) = http_routes {
-                if let Some(match_suffix) = http_routes.route_prefix(&routed_path, method) {
-                    longest_match = Some((match_suffix, CurrentMatch::CurrentHttpJs));
-                }
+            if let Some(ref http_routes) = http_routes
+                && let Some(match_suffix) = http_routes.route_prefix(&routed_path, method)
+            {
+                longest_match = Some((match_suffix, CurrentMatch::CurrentHttpJs));
             }
             for (mount_path, reference) in &definition.http_mounts {
                 let Some(match_suffix) = routed_path.strip_prefix(&mount_path[..]) else {

crates/application/src/application_function_runner/mod.rs

@@ -1421,16 +1421,15 @@ impl<RT: Runtime> ApplicationFunctionRunner<RT> {
 
                 timer.finish();
 
-                if let Ok(ref mut node_outcome) = node_outcome_result {
-                    if let Ok(ref output) = node_outcome.result {
-                        if let Some(js_err) = returns_validator.check_output(
-                            output,
-                            &table_mapping,
-                            &virtual_system_mapping,
-                        ) {
-                            node_outcome.result = Err(js_err);
-                        }
-                    }
+                if let Ok(ref mut node_outcome) = node_outcome_result
+                    && let Ok(ref output) = node_outcome.result
+                    && let Some(js_err) = returns_validator.check_output(
+                        output,
+                        &table_mapping,
+                        &virtual_system_mapping,
+                    )
+                {
+                    node_outcome.result = Err(js_err);
                 }
 
                 node_outcome_result.map(|node_outcome| {

crates/application/src/lib.rs

@@ -1,6 +1,5 @@
 #![feature(try_blocks)]
 #![feature(iterator_try_collect)]
-#![feature(let_chains)]
 #![feature(coroutines)]
 #![feature(round_char_boundary)]
 #![feature(duration_constructors)]

crates/application/src/tests/scheduled_jobs.rs

@@ -1,4 +1,7 @@
-use std::str::FromStr;
+use std::{
+    str::FromStr,
+    time::Duration,
+};
 
 use common::{
     components::{
@@ -8,7 +11,6 @@ use common::{
         PublicFunctionPath,
     },
     execution_context::ExecutionContext,
-    knobs::SCHEDULED_JOB_RETENTION,
     pause::{
         HoldGuard,
         PauseController,
@@ -185,6 +187,8 @@ async fn test_scheduled_jobs_garbage_collection(
     rt: TestRuntime,
     pause_controller: PauseController,
 ) -> anyhow::Result<()> {
+    // TODO: this is sketchy and could interfere with other tests in this process
+    unsafe { std::env::set_var("SCHEDULED_JOB_RETENTION", "30") };
     let application = Application::new_for_tests(&rt).await?;
     application.load_udf_tests_modules().await?;
 
@@ -213,7 +217,7 @@ async fn test_scheduled_jobs_garbage_collection(
     );
 
     // Wait for garbage collector to clean up the job
-    rt.wait(*SCHEDULED_JOB_RETENTION * 2).await;
+    rt.wait(Duration::from_secs(60)).await;
     tx = application.begin(Identity::system()).await?;
     let state = SchedulerModel::new(&mut tx, TableNamespace::test_user())
         .check_status(job_id)

crates/async_lru/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "async_lru"
 version = "0.1.0"
-edition = "2021"
+edition = "2024"
 license = "LicenseRef-FSL-1.1-Apache-2.0"
 
 [dependencies]

crates/async_lru/src/lib.rs

@@ -1,4 +1,3 @@
-#![feature(let_chains)]
 pub mod async_lru;
 mod metrics;
 pub mod multi_type_async_lru;

crates/authentication/Cargo.toml

@@ -2,7 +2,7 @@
 name = "authentication"
 version = "0.1.0"
 authors = ["Convex, Inc. <[email protected]>"]
-edition = "2021"
+edition = "2024"
 license = "LicenseRef-FSL-1.1-Apache-2.0"
 
 [lib]

crates/aws_s3/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "aws_s3"
 version = "0.1.0"
-edition = "2021"
+edition = "2024"
 license = "LicenseRef-FSL-1.1-Apache-2.0"
 
 [lib]

crates/aws_s3/src/lib.rs

@@ -1,5 +1,4 @@
 #![feature(future_join)]
-#![feature(let_chains)]
 #![feature(coroutines)]
 #![feature(iter_from_coroutine)]
 #![feature(iterator_try_collect)]