Avoid some unused locals in convex-js (#39873)

GitOrigin-RevId: 587b36cf5687f9676f4e479e3cc9f341573eee1b

Author: thomasballinger

npm-packages/convex/package.json

@@ -194,7 +194,7 @@
     "postpack": "node scripts/postpack.mjs",
     "test": "vitest --silent",
     "test-not-silent": "vitest",
-    "new-test": "vitest",
+    "typecheck": "tsc --noEmit --emitDeclarationOnly false",
     "test-esm": "node ./scripts/test-esm.mjs && ./scripts/checkdeps.mjs && ./scripts/checkimports.mjs"
   },
   "files": [

npm-packages/convex/src/browser/logging.ts

@@ -109,7 +109,7 @@ export function instantiateDefaultLogger(options: {
         console.error(...args);
         break;
       default: {
-        const _typecheck: never = level;
+        level satisfies never;
         console.log(...args);
       }
     }

npm-packages/convex/src/browser/sync/authentication_manager.ts

@@ -449,7 +449,7 @@ export class AuthenticationManager {
       case "initialRefetch":
         break;
       default: {
-        const _typeCheck: never = newAuth;
+        newAuth satisfies never;
       }
     }
     if (this.authState.state === "waitingForScheduledRefetch") {

npm-packages/convex/src/browser/sync/client.ts

@@ -467,7 +467,7 @@ export class BaseConvexClient {
             case "Ping":
               break; // do nothing
             default: {
-              const _typeCheck: never = serverMessage;
+              serverMessage satisfies never;
             }
           }
 

npm-packages/convex/src/browser/sync/local_state.ts

@@ -157,7 +157,7 @@ export class LocalSyncState {
         }
         default: {
           // Enforce that the switch-case is exhaustive.
-          const _: never = modification;
+          modification satisfies never;
           throw new Error(`Invalid modification ${(modification as any).type}`);
         }
       }

npm-packages/convex/src/browser/sync/protocol.ts

@@ -48,7 +48,7 @@ export function parseServerMessage(
       };
     }
     default: {
-      const _exhaustivenessCheck: never = encoded;
+      encoded satisfies never;
     }
   }
   return undefined as never;
@@ -76,7 +76,7 @@ export function encodeClientMessage(
       }
     }
     default: {
-      const _exhaustivenessCheck: never = message;
+      message satisfies never;
     }
   }
   return undefined as never;

npm-packages/convex/src/browser/sync/remote_query_set.ts

@@ -78,7 +78,7 @@ export class RemoteQuerySet {
         }
         default: {
           // Enforce that the switch-case is exhaustive.
-          const _: never = modification;
+          modification satisfies never;
           throw new Error(`Invalid modification ${(modification as any).type}`);
         }
       }

npm-packages/convex/src/browser/sync/web_socket_manager.ts

@@ -412,7 +412,7 @@ export class WebSocketManager {
       }
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
       }
     }
   }
@@ -457,7 +457,7 @@ export class WebSocketManager {
       }
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
         return Promise.resolve();
       }
     }
@@ -483,7 +483,7 @@ export class WebSocketManager {
       }
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
         throw new Error(
           `Invalid websocket state: ${(this.socket as any).state}`,
         );
@@ -506,7 +506,7 @@ export class WebSocketManager {
       }
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
         return Promise.resolve();
       }
     }
@@ -528,7 +528,7 @@ export class WebSocketManager {
         return;
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
       }
     }
     this.connect();
@@ -548,7 +548,7 @@ export class WebSocketManager {
       }
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
         return;
       }
     }
@@ -581,7 +581,7 @@ export class WebSocketManager {
         return;
       default: {
         // Enforce that the switch-case is exhaustive.
-        const _: never = this.socket;
+        this.socket satisfies never;
       }
     }
     this.connect();

npm-packages/convex/src/cli/lib/api.ts

@@ -239,7 +239,7 @@ export async function checkAccessToSelectedProject(
       // it will instead fail as soon as we try to use the key.
       return { kind: "unknown" };
     default: {
-      const _exhaustivenessCheck: never = projectSelection;
+      projectSelection satisfies never;
       return await ctx.crash({
         exitCode: 1,
         errorType: "fatal",
@@ -424,7 +424,7 @@ async function handleOwnDev(
       };
     }
     default: {
-      const _exhaustivenessCheck: never = projectSelection;
+      projectSelection satisfies never;
       return ctx.crash({
         exitCode: 1,
         errorType: "fatal",
@@ -573,7 +573,7 @@ async function fetchDeploymentCredentialsWithinCurrentProject(
         projectSelection,
       );
     default: {
-      const _exhaustivenessCheck: never = deploymentSelection;
+      deploymentSelection satisfies never;
       return ctx.crash({
         exitCode: 1,
         errorType: "fatal",
@@ -737,7 +737,7 @@ export async function loadSelectedDeploymentCredentials(
       };
     }
     default: {
-      const _exhaustivenessCheck: never = deploymentSelection;
+      deploymentSelection satisfies never;
       return await ctx.crash({
         exitCode: 1,
         errorType: "fatal",

npm-packages/convex/src/cli/lib/convexExport.ts

@@ -76,7 +76,7 @@ export async function exportFromDeployment(
       });
     }
     default: {
-      const _: never = snapshotExportState;
+      snapshotExportState satisfies never;
       return await ctx.crash({
         exitCode: 1,
         errorType: "fatal",
@@ -137,7 +137,7 @@ async function waitForStableExportState(
             onDone();
             break;
           default: {
-            const _: never = snapshotExportState;
+            snapshotExportState satisfies never;
             onDone();
           }
         }